From: Heikki Krogerus <heikki.krogerus@linux•intel.com>
To: Chaoyi Chen <kernel@airkyi•com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
Dmitry Baryshkov <dmitry.baryshkov@oss•qualcomm.com>,
Peter Chen <hzpeterchen@gmail•com>,
Luca Ceresoli <luca.ceresoli@bootlin•com>,
Rob Herring <robh@kernel•org>,
Krzysztof Kozlowski <krzk+dt@kernel•org>,
Conor Dooley <conor+dt@kernel•org>, Vinod Koul <vkoul@kernel•org>,
Kishon Vijay Abraham I <kishon@kernel•org>,
Heiko Stuebner <heiko@sntech•de>,
Sandy Huang <hjc@rock-chips•com>,
Andy Yan <andy.yan@rock-chips•com>,
Yubing Zhang <yubing.zhang@rock-chips•com>,
Frank Wang <frank.wang@rock-chips•com>,
Andrzej Hajda <andrzej.hajda@intel•com>,
Neil Armstrong <neil.armstrong@linaro•org>,
Robert Foss <rfoss@kernel•org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard•com>,
Jonas Karlman <jonas@kwiboo•se>,
Jernej Skrabec <jernej.skrabec@gmail•com>,
Maarten Lankhorst <maarten.lankhorst@linux•intel.com>,
Maxime Ripard <mripard@kernel•org>,
Thomas Zimmermann <tzimmermann@suse•de>,
David Airlie <airlied@gmail•com>, Simona Vetter <simona@ffwll•ch>,
Amit Sunil Dhamne <amitsd@google•com>,
Chaoyi Chen <chaoyi.chen@rock-chips•com>,
Dragan Simic <dsimic@manjaro•org>,
Johan Jonker <jbx6244@gmail•com>,
Diederik de Haas <didi.debian@cknow•org>,
Peter Robinson <pbrobinson@gmail•com>,
linux-usb@vger•kernel.org, devicetree@vger•kernel.org,
linux-kernel@vger•kernel.org, linux-phy@lists•infradead.org,
linux-arm-kernel@lists•infradead.org,
linux-rockchip@lists•infradead.org,
dri-devel@lists•freedesktop.org
Subject: Re: [PATCH v11 03/11] drm/bridge: Implement generic USB Type-C DP HPD bridge
Date: Thu, 4 Dec 2025 15:18:48 +0200 [thread overview]
Message-ID: <aTGKODdf7vsHFY72@kuha> (raw)
In-Reply-To: <20251128020405.90-4-kernel@airkyi.com>
Hi,
Fri, Nov 28, 2025 at 10:03:57AM +0800, Chaoyi Chen kirjoitti:
> diff --git a/drivers/gpu/drm/bridge/aux-hpd-typec-dp-bridge.c b/drivers/gpu/drm/bridge/aux-hpd-typec-dp-bridge.c
> new file mode 100644
> index 000000000000..94be3d5f69e9
> --- /dev/null
> +++ b/drivers/gpu/drm/bridge/aux-hpd-typec-dp-bridge.c
> @@ -0,0 +1,51 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +#include <linux/of.h>
> +#include <linux/usb/typec_altmode.h>
> +#include <linux/usb/typec_dp.h>
> +
> +#include <drm/bridge/aux-bridge.h>
> +
> +static int drm_typec_bus_event(struct notifier_block *nb,
> + unsigned long action, void *data)
> +{
> + struct device *dev = (struct device *)data;
> + struct typec_altmode *alt = to_typec_altmode(dev);
> +
> + if (action != BUS_NOTIFY_ADD_DEVICE)
> + goto done;
> +
> + if (is_typec_partner_altmode(&alt->dev) || alt->svid != USB_TYPEC_DP_SID)
> + goto done;
There are also plug altmodes. Just make sure it's a plug altmode.
if (!is_typec_plug_altmode(&alt->dev) || alt->svid != USB_TYPEC_DP_SID)
goto done;
> + /*
> + * alt->dev.parent->parent : USB-C controller device
> + * alt->dev.parent : USB-C connector device
> + */
> + drm_dp_hpd_bridge_register(alt->dev.parent->parent,
> + to_of_node(alt->dev.parent->fwnode));
> +
> +done:
> + return NOTIFY_OK;
> +}
> +
> +static struct notifier_block drm_typec_event_nb = {
> + .notifier_call = drm_typec_bus_event,
> +};
> +
> +static void drm_aux_hpd_typec_dp_bridge_module_exit(void)
> +{
> + bus_unregister_notifier(&typec_bus, &drm_typec_event_nb);
> +}
> +
> +static int __init drm_aux_hpd_typec_dp_bridge_module_init(void)
> +{
> + bus_register_notifier(&typec_bus, &drm_typec_event_nb);
> +
> + return 0;
> +}
> +
> +module_init(drm_aux_hpd_typec_dp_bridge_module_init);
> +module_exit(drm_aux_hpd_typec_dp_bridge_module_exit);
> +
> +MODULE_DESCRIPTION("DRM TYPEC DP HPD BRIDGE");
> +MODULE_LICENSE("GPL");
thanks,
--
heikki
next prev parent reply other threads:[~2025-12-04 13:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-28 2:03 [PATCH v11 00/11] Add Type-C DP support for RK3399 EVB IND board Chaoyi Chen
2025-11-28 2:03 ` [PATCH v11 01/11] usb: typec: Set the bus also for the port and plug altmodes Chaoyi Chen
2025-11-28 5:51 ` Greg Kroah-Hartman
2025-11-28 6:15 ` Chaoyi Chen
2025-11-28 2:03 ` [PATCH v11 02/11] usb: typec: Export typec bus and typec altmode device type Chaoyi Chen
2025-11-28 2:03 ` [PATCH v11 03/11] drm/bridge: Implement generic USB Type-C DP HPD bridge Chaoyi Chen
2025-12-04 13:18 ` Heikki Krogerus [this message]
2025-11-28 2:03 ` [PATCH v11 04/11] drm/bridge: aux: Add drm_aux_bridge_register_from_node() Chaoyi Chen
2025-11-28 2:03 ` [PATCH v11 05/11] dt-bindings: phy: rockchip: rk3399-typec-phy: Support mode-switch Chaoyi Chen
2025-11-28 3:17 ` Rob Herring (Arm)
2025-11-28 2:04 ` [PATCH v11 06/11] phy: rockchip: phy-rockchip-typec: Add typec_mux/typec_switch support Chaoyi Chen
2025-11-28 2:04 ` [PATCH v11 07/11] phy: rockchip: phy-rockchip-typec: Add DRM AUX bridge Chaoyi Chen
2025-11-28 2:04 ` [PATCH v11 08/11] drm/rockchip: cdn-dp: Support handle lane info without extcon Chaoyi Chen
2025-11-28 2:04 ` [PATCH v11 09/11] drm/rockchip: cdn-dp: Add multiple bridges to support PHY port selection Chaoyi Chen
2025-11-28 2:04 ` [PATCH v11 10/11] arm64: dts: rockchip: Add missing dp_out port for RK3399 CDN-DP Chaoyi Chen
2025-11-28 2:04 ` [PATCH v11 11/11] arm64: dts: rockchip: rk3399-evb-ind: Add support for DisplayPort Chaoyi Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aTGKODdf7vsHFY72@kuha \
--to=heikki.krogerus@linux$(echo .)intel.com \
--cc=Laurent.pinchart@ideasonboard$(echo .)com \
--cc=airlied@gmail$(echo .)com \
--cc=amitsd@google$(echo .)com \
--cc=andrzej.hajda@intel$(echo .)com \
--cc=andy.yan@rock-chips$(echo .)com \
--cc=chaoyi.chen@rock-chips$(echo .)com \
--cc=conor+dt@kernel$(echo .)org \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=didi.debian@cknow$(echo .)org \
--cc=dmitry.baryshkov@oss$(echo .)qualcomm.com \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=dsimic@manjaro$(echo .)org \
--cc=frank.wang@rock-chips$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=heiko@sntech$(echo .)de \
--cc=hjc@rock-chips$(echo .)com \
--cc=hzpeterchen@gmail$(echo .)com \
--cc=jbx6244@gmail$(echo .)com \
--cc=jernej.skrabec@gmail$(echo .)com \
--cc=jonas@kwiboo$(echo .)se \
--cc=kernel@airkyi$(echo .)com \
--cc=kishon@kernel$(echo .)org \
--cc=krzk+dt@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-phy@lists$(echo .)infradead.org \
--cc=linux-rockchip@lists$(echo .)infradead.org \
--cc=linux-usb@vger$(echo .)kernel.org \
--cc=luca.ceresoli@bootlin$(echo .)com \
--cc=maarten.lankhorst@linux$(echo .)intel.com \
--cc=mripard@kernel$(echo .)org \
--cc=neil.armstrong@linaro$(echo .)org \
--cc=pbrobinson@gmail$(echo .)com \
--cc=rfoss@kernel$(echo .)org \
--cc=robh@kernel$(echo .)org \
--cc=simona@ffwll$(echo .)ch \
--cc=tzimmermann@suse$(echo .)de \
--cc=vkoul@kernel$(echo .)org \
--cc=yubing.zhang@rock-chips$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox