Subject: Re: [PATCH v7 1/5] i2c: core: add callback to change bus frequency

From: Andy Shevchenko <[email-masked]>
Date: Mon, 23 Feb 2026 16:55:36 +0200

On Mon, Feb 23, 2026 at 04:54:01PM +0200, Andy Shevchenko wrote:
> On Mon, Feb 23, 2026 at 03:33:50PM +0100, Marcus Folkesson wrote:

...

> > +	/*
> > +	 * If the adapter is a root adapter without set_clk_freq implemented, this feature is not

.set_clk_freq()

> > +	 * supported

Please, also respect English grammar and punctuation: Missed period here.

> > +	 */
> > +	if (!i2c_parent_is_i2c_adapter(adapter))
> > +		return -EOPNOTSUPP;
> > +
> > +	/* Update the clock_hz for non-root adapters, even if set_clk_freq is not implemented,

.set_clk_freq()

> > +	 * to allow * the clock frequency to be propagated to root adapters that do support it.
> > +	 */
> 
> /*
>  * Please, keep the style of multi-line comment consistent
>  * and as per above.

...including one thing ^^^

>  */
> 
> > +	adapter->clock_hz = clock_hz;
> > +	return 0;

-- 
With Best Regards,
Andy Shevchenko