From: Dan Carpenter <dan.carpenter@linaro•org>
To: Andy Shevchenko <andriy.shevchenko@intel•com>
Cc: Sanjay Chitroda <sanjayembeddedse@gmail•com>,
jic23@kernel•org, m.tretter@pengutronix•de, mchehab@kernel•org,
p.zabel@pengutronix•de, tiffany.lin@mediatek•com,
andrew-ct.chen@mediatek•com, yunfei.dong@mediatek•com,
matthias.bgg@gmail•com, angelogioacchino.delregno@collabora•com,
johan@kernel•org, elder@kernel•org, gregkh@linuxfoundation•org,
pure.logic@nexus-software•ie, dlechner@baylibre•com,
nuno.sa@analog•com, andy@kernel•org, kernel@pengutronix•de,
kees@kernel•org, nabijaczleweli@nabijaczleweli•xyz,
marcelo.schmitt1@gmail•com, maudspierings@gocontroll•com,
hverkuil+cisco@kernel•org, ribalda@chromium•org,
straube.linux@gmail•com, lukagejak5@gmail•com,
ethantidmore06@gmail•com, samasth.norway.ananda@oracle•com,
karanja99erick@gmail•com, s9430939@naver•com, tglx@kernel•org,
mingo@kernel•org, sun.jian.kdev@gmail•com, weibu@redadmin•org,
linux-iio@vger•kernel.org, linux-kernel@vger•kernel.org,
linux-media@vger•kernel.org,
linux-arm-kernel@lists•infradead.org,
linux-mediatek@lists•infradead.org, greybus-dev@lists•linaro.org,
linux-staging@lists•linux.dev, skhan@linuxfoundation•org
Subject: Re: [PATCH 1/7] staging: greybus: simplify cleanup using __free
Date: Wed, 11 Mar 2026 09:51:20 +0300 [thread overview]
Message-ID: <abEQ6HA0CGGCyV1B@stanley.mountain> (raw)
In-Reply-To: <abCIBPZzZBfMoOtm@ashevche-desk.local>
On Tue, Mar 10, 2026 at 11:07:16PM +0200, Andy Shevchenko wrote:
> On Wed, Mar 11, 2026 at 01:35:07AM +0530, Sanjay Chitroda wrote:
>
> > Replace manual cleanup logic with __free attribute from cleanup.h. This
> > removes explicit kfree() calls and simplifies the error handling paths.
> >
> > No functional change intended for kmalloc().
>
> ...
>
> > + struct gb_camera_configure_streams_request *req __free(kfree) =
> > + kmalloc(req_size, GFP_KERNEL);
> > + struct gb_camera_configure_streams_response *resp __free(kfree) =
> > + kmalloc(resp_size, GFP_KERNEL);
> > if (!req || !resp) {
>
> Now this check should be done in a better way.
>
Yeah, two if statements, right? Drop the curly braces at a minimum.
> > - kfree(req);
> > - kfree(resp);
> > return -ENOMEM;
> > }
> >
>
> > done_skip_pm_put:
> > mutex_unlock(&gcam->mutex);
>
> To complete this, one may add a prerequisite to use guard()() first.
>
I don't think we're encouraging people to re-write existing staging
code to use cleanup.h magic... It's unclear if I have to review these
patches or if they're auto NAKed because we're not doing the conversions.
regards,
dan carpenter
next prev parent reply other threads:[~2026-03-11 6:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-10 20:05 [PATCH 0/7] drivers: Simplify cleanup paths using __free Sanjay Chitroda
2026-03-10 20:05 ` [PATCH 1/7] staging: greybus: simplify cleanup " Sanjay Chitroda
2026-03-10 21:07 ` Andy Shevchenko
2026-03-11 6:51 ` Dan Carpenter [this message]
2026-03-11 7:06 ` Greg KH
2026-03-10 20:05 ` [PATCH 2/7] iio: ssp_sensors: " Sanjay Chitroda
2026-03-10 21:11 ` Andy Shevchenko
2026-03-10 20:05 ` [PATCH 3/7] iio: st_sensors: " Sanjay Chitroda
2026-03-11 0:04 ` David Lechner
2026-03-10 20:05 ` [PATCH 4/7] media: mediatek: vcodec: " Sanjay Chitroda
2026-03-19 21:08 ` Nicolas Dufresne
2026-03-10 20:05 ` [PATCH 5/7] media: chips-media: coda: " Sanjay Chitroda
2026-03-10 20:05 ` [PATCH 6/7] media: allegro: " Sanjay Chitroda
2026-03-10 20:05 ` [PATCH 7/7] staging: rtl8723bs: " Sanjay Chitroda
2026-03-10 21:42 ` Andrew Lunn
2026-03-11 6:45 ` Greg KH
2026-03-10 21:04 ` [PATCH 0/7] drivers: Simplify cleanup paths " Andy Shevchenko
2026-03-10 21:52 ` David Lechner
2026-03-11 1:57 ` Sanjay Chitroda
2026-03-11 5:42 ` Luka Gejak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abEQ6HA0CGGCyV1B@stanley.mountain \
--to=dan.carpenter@linaro$(echo .)org \
--cc=andrew-ct.chen@mediatek$(echo .)com \
--cc=andriy.shevchenko@intel$(echo .)com \
--cc=andy@kernel$(echo .)org \
--cc=angelogioacchino.delregno@collabora$(echo .)com \
--cc=dlechner@baylibre$(echo .)com \
--cc=elder@kernel$(echo .)org \
--cc=ethantidmore06@gmail$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=greybus-dev@lists$(echo .)linaro.org \
--cc=hverkuil+cisco@kernel$(echo .)org \
--cc=jic23@kernel$(echo .)org \
--cc=johan@kernel$(echo .)org \
--cc=karanja99erick@gmail$(echo .)com \
--cc=kees@kernel$(echo .)org \
--cc=kernel@pengutronix$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-iio@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-media@vger$(echo .)kernel.org \
--cc=linux-mediatek@lists$(echo .)infradead.org \
--cc=linux-staging@lists$(echo .)linux.dev \
--cc=lukagejak5@gmail$(echo .)com \
--cc=m.tretter@pengutronix$(echo .)de \
--cc=marcelo.schmitt1@gmail$(echo .)com \
--cc=matthias.bgg@gmail$(echo .)com \
--cc=maudspierings@gocontroll$(echo .)com \
--cc=mchehab@kernel$(echo .)org \
--cc=mingo@kernel$(echo .)org \
--cc=nabijaczleweli@nabijaczleweli$(echo .)xyz \
--cc=nuno.sa@analog$(echo .)com \
--cc=p.zabel@pengutronix$(echo .)de \
--cc=pure.logic@nexus-software$(echo .)ie \
--cc=ribalda@chromium$(echo .)org \
--cc=s9430939@naver$(echo .)com \
--cc=samasth.norway.ananda@oracle$(echo .)com \
--cc=sanjayembeddedse@gmail$(echo .)com \
--cc=skhan@linuxfoundation$(echo .)org \
--cc=straube.linux@gmail$(echo .)com \
--cc=sun.jian.kdev@gmail$(echo .)com \
--cc=tglx@kernel$(echo .)org \
--cc=tiffany.lin@mediatek$(echo .)com \
--cc=weibu@redadmin$(echo .)org \
--cc=yunfei.dong@mediatek$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox