From: Nicolas Saenz Julienne <nsaenzjulienne@suse•de>
To: matthias.bgg@kernel•org, Florian Fainelli <f.fainelli@gmail•com>,
"David S . Miller" <davem@davemloft•net>
Cc: Doug Berger <opendmb@gmail•com>,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
Matthias Brugger <mbrugger@suse•com>,
bcm-kernel-feedback-list@broadcom•com,
linux-rpi-kernel@lists•infradead.org,
linux-arm-kernel@lists•infradead.org,
Stefan Wahren <wahrenst@gmx•net>
Subject: Re: [PATCH v1 2/3] net: bcmgenet: use optional max DMA burst size property
Date: Fri, 11 Oct 2019 21:01:45 +0200 [thread overview]
Message-ID: <aba8aee4c78523e652e0605db844b793214b7674.camel@suse.de> (raw)
In-Reply-To: <20191011184822.866-3-matthias.bgg@kernel.org>
[-- Attachment #1.1: Type: text/plain, Size: 2816 bytes --]
Hi Matthias!
One small comment, I'll test everything later on.
On Fri, 2019-10-11 at 20:48 +0200, matthias.bgg@kernel•org wrote:
> From: Matthias Brugger <mbrugger@suse•com>
>
> Depending on the HW, the maximal usable DMA burst size can vary.
> If not set accordingly a timeout in the transmit queue happens and no
> package can be sent. Read to optional max-burst-sz property, if not
> present, fallback to the standard value.
>
> Signed-off-by: Matthias Brugger <mbrugger@suse•com>
> ---
>
> drivers/net/ethernet/broadcom/genet/bcmgenet.c | 13 +++++++++++--
> drivers/net/ethernet/broadcom/genet/bcmgenet.h | 1 +
> 2 files changed, 12 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c
> b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
> index 12cb77ef1081..a7bb822a6d83 100644
> --- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c
> +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
> @@ -2576,7 +2576,8 @@ static int bcmgenet_init_dma(struct bcmgenet_priv *priv)
> }
>
> /* Init rDma */
> - bcmgenet_rdma_writel(priv, DMA_MAX_BURST_LENGTH, DMA_SCB_BURST_SIZE);
> + bcmgenet_rdma_writel(priv, priv->dma_max_burst_length,
> + DMA_SCB_BURST_SIZE);
>
> /* Initialize Rx queues */
> ret = bcmgenet_init_rx_queues(priv->dev);
> @@ -2589,7 +2590,8 @@ static int bcmgenet_init_dma(struct bcmgenet_priv *priv)
> }
>
> /* Init tDma */
> - bcmgenet_tdma_writel(priv, DMA_MAX_BURST_LENGTH, DMA_SCB_BURST_SIZE);
> + bcmgenet_tdma_writel(priv, priv->dma_max_burst_length,
> + DMA_SCB_BURST_SIZE);
>
> /* Initialize Tx queues */
> bcmgenet_init_tx_queues(priv->dev);
> @@ -3522,6 +3524,13 @@ static int bcmgenet_probe(struct platform_device *pdev)
>
> clk_prepare_enable(priv->clk);
>
> + if (dn) {
> + of_property_read_u32(dn, "dma-burst-sz",
> + &priv->dma_max_burst_length);
You set the 'dma-burst-sz' binding as optional, though this assumes that if a
device node is available dma_max_burst_length comes from the device tree. I
think you should check of_property_read_u32's return value and on failure
default to DMA_MAX_BURST_LENGTH.
> + } else {
> + priv->dma_max_burst_length = DMA_MAX_BURST_LENGTH;
> + }
> +
> bcmgenet_set_hw_params(priv);
>
> /* Mii wait queue */
> diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.h
> b/drivers/net/ethernet/broadcom/genet/bcmgenet.h
> index 4a8fc03d82fd..897f356eb376 100644
> --- a/drivers/net/ethernet/broadcom/genet/bcmgenet.h
> +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.h
> @@ -663,6 +663,7 @@ struct bcmgenet_priv {
> bool crc_fwd_en;
>
> unsigned int dma_rx_chk_bit;
> + unsigned int dma_max_burst_length;
>
> u32 msg_enable;
>
Regards,
Nicolas
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-11 19:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 18:48 [PATCH v1 0/3] This series adds ethernet support for RPi4 matthias.bgg
2019-10-11 18:48 ` [PATCH v1 1/3] dt-bindings: net: bcmgenet add property for max DMA burst size matthias.bgg
2019-10-11 19:07 ` Florian Fainelli
2019-10-11 18:48 ` [PATCH v1 2/3] net: bcmgenet: use optional max DMA burst size property matthias.bgg
2019-10-11 19:01 ` Nicolas Saenz Julienne [this message]
2019-10-11 18:48 ` [PATCH v1 3/3] ARM: dts: bcm2711: Enable GENET support for the RPi4 matthias.bgg
2019-10-11 19:31 ` Florian Fainelli
2019-10-13 18:41 ` Stefan Wahren
2019-10-13 19:19 ` Florian Fainelli
2019-10-15 19:35 ` Stefan Wahren
2019-10-15 19:39 ` Florian Fainelli
2019-10-11 23:09 ` Stefan Wahren
2019-10-11 23:11 ` Florian Fainelli
2019-10-12 17:05 ` Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aba8aee4c78523e652e0605db844b793214b7674.camel@suse.de \
--to=nsaenzjulienne@suse$(echo .)de \
--cc=bcm-kernel-feedback-list@broadcom$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=f.fainelli@gmail$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-rpi-kernel@lists$(echo .)infradead.org \
--cc=matthias.bgg@kernel$(echo .)org \
--cc=mbrugger@suse$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=opendmb@gmail$(echo .)com \
--cc=wahrenst@gmx$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox