From: Wolfram Sang <wsa+renesas@sang-engineering•com>
To: Douglas Anderson <dianders@chromium•org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
"Rafael J . Wysocki" <rafael@kernel•org>,
Danilo Krummrich <dakr@kernel•org>,
stable@vger•kernel.org, Andrew Lunn <andrew@lunn•ch>,
Andy Shevchenko <andriy.shevchenko@linux•intel.com>,
Daniel Scally <djrscally@gmail•com>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Fabio Estevam <festevam@gmail•com>, Frank Li <Frank.Li@nxp•com>,
Heikki Krogerus <heikki.krogerus@linux•intel.com>,
Heiner Kallweit <hkallweit1@gmail•com>,
Jakub Kicinski <kuba@kernel•org>, Len Brown <lenb@kernel•org>,
Mark Brown <broonie@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
Pengutronix Kernel Team <kernel@pengutronix•de>,
Rob Herring <robh@kernel•org>,
Russell King <linux@armlinux•org.uk>,
Sakari Ailus <sakari.ailus@linux•intel.com>,
Saravana Kannan <saravanak@kernel•org>,
Sascha Hauer <s.hauer@pengutronix•de>,
devicetree@vger•kernel.org, driver-core@lists•linux.dev,
imx@lists•linux.dev, linux-acpi@vger•kernel.org,
linux-arm-kernel@lists•infradead.org, linux-i2c@vger•kernel.org,
linux-kernel@vger•kernel.org, linux-spi@vger•kernel.org,
netdev@vger•kernel.org
Subject: Re: [PATCH] device property: Make modifications of fwnode "flags" thread safe
Date: Tue, 17 Mar 2026 08:26:53 +0100 [thread overview]
Message-ID: <abkCPU3rxHI49N4_@shikoro> (raw)
In-Reply-To: <20260316154159.1.I0a4d03104ecd5103df3d76f66c8d21b1d15a2e38@changeid>
Hi Doug,
thanks for tackling this issue! I agree it should be fixed, just
wondered about one thing:
> While flags are often modified while under the "fwnode_link_lock",
> this is not universally true.
Is it a possibility to use the lock in all code paths instead?
Because...
> struct list_head consumers;
> - u8 flags;
> + unsigned long flags;
... this change costs some memory on every system. Maybe it can be
avoided?
Happy hacking,
Wolfram
next prev parent reply other threads:[~2026-03-17 7:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-16 22:42 [PATCH] device property: Make modifications of fwnode "flags" thread safe Douglas Anderson
2026-03-17 7:10 ` Andy Shevchenko
2026-03-17 7:26 ` Wolfram Sang [this message]
2026-03-17 7:34 ` Andy Shevchenko
2026-03-17 7:42 ` Wolfram Sang
2026-03-17 8:04 ` Andy Shevchenko
2026-03-17 8:05 ` Andy Shevchenko
2026-03-17 8:42 ` Wolfram Sang
2026-03-17 10:02 ` Danilo Krummrich
2026-03-17 10:16 ` Andy Shevchenko
2026-03-17 10:34 ` Wolfram Sang
2026-03-17 10:44 ` Rafael J. Wysocki
2026-03-17 14:27 ` Wolfram Sang
2026-03-18 8:41 ` Geert Uytterhoeven
2026-03-18 9:06 ` Andy Shevchenko
2026-03-17 13:42 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abkCPU3rxHI49N4_@shikoro \
--to=wsa+renesas@sang-engineering$(echo .)com \
--cc=Frank.Li@nxp$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=andriy.shevchenko@linux$(echo .)intel.com \
--cc=broonie@kernel$(echo .)org \
--cc=dakr@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=dianders@chromium$(echo .)org \
--cc=djrscally@gmail$(echo .)com \
--cc=driver-core@lists$(echo .)linux.dev \
--cc=edumazet@google$(echo .)com \
--cc=festevam@gmail$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=heikki.krogerus@linux$(echo .)intel.com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=imx@lists$(echo .)linux.dev \
--cc=kernel@pengutronix$(echo .)de \
--cc=kuba@kernel$(echo .)org \
--cc=lenb@kernel$(echo .)org \
--cc=linux-acpi@vger$(echo .)kernel.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-i2c@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-spi@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=rafael@kernel$(echo .)org \
--cc=robh@kernel$(echo .)org \
--cc=s.hauer@pengutronix$(echo .)de \
--cc=sakari.ailus@linux$(echo .)intel.com \
--cc=saravanak@kernel$(echo .)org \
--cc=stable@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox