From: Mehdi Djait <mehdi.djait@linux•intel.com>
To: michael.riesch@collabora•com
Cc: "Laurent Pinchart" <laurent.pinchart@ideasonboard•com>,
"Mauro Carvalho Chehab" <mchehab@kernel•org>,
"Rob Herring" <robh@kernel•org>,
"Krzysztof Kozlowski" <krzk+dt@kernel•org>,
"Conor Dooley" <conor+dt@kernel•org>,
"Heiko Stuebner" <heiko@sntech•de>,
"Kever Yang" <kever.yang@rock-chips•com>,
"Jagan Teki" <jagan@amarulasolutions•com>,
"Кузнецов Михаил" <mai.kuznetsov.misha@gmail•com>,
"Sebastian Reichel" <sebastian.reichel@collabora•com>,
"Nicolas Dufresne" <nicolas.dufresne@collabora•com>,
"Collabora Kernel Team" <kernel@collabora•com>,
"Sakari Ailus" <sakari.ailus@linux•intel.com>,
linux-media@vger•kernel.org, devicetree@vger•kernel.org,
linux-arm-kernel@lists•infradead.org,
linux-rockchip@lists•infradead.org, linux-kernel@vger•kernel.org
Subject: Re: [PATCH v2 3/9] media: rockchip: rkcif: add support for rk3588 vicap mipi capture
Date: Tue, 17 Mar 2026 14:08:33 +0100 [thread overview]
Message-ID: <ablRBViDR996euua@mdjait-mobl> (raw)
In-Reply-To: <20250430-rk3588-vicap-v2-3-77de5ee9048e@collabora.com>
Hi Michael,
Thank you for this nice patch!
On Tue, Mar 17, 2026 at 10:32:21AM +0100, Michael Riesch via B4 Relay wrote:
> From: Michael Riesch <michael.riesch@collabora•com>
>
> The RK3588 Video Capture (VICAP) unit features a Digital Video Port
> (DVP) and six MIPI CSI-2 capture interfaces. Add initial support
> for this variant to the rkcif driver and enable the MIPI CSI-2
> capture interfaces.
>
> Signed-off-by: Michael Riesch <michael.riesch@collabora•com>
[...]
> static inline unsigned int rkcif_mipi_get_reg(struct rkcif_interface *interface,
> unsigned int index)
> {
> @@ -631,6 +765,8 @@ static int rkcif_mipi_start_streaming(struct rkcif_stream *stream)
> rkcif_mipi_stream_write(stream, RKCIF_MIPI_CTRL1, ctrl1);
> rkcif_mipi_stream_write(stream, RKCIF_MIPI_CTRL0, ctrl0);
>
> + rkcif_mipi_write(interface, RKCIF_MIPI_CTRL, RKCIF_MIPI_CTRL_CAP_EN);
> +
while this is the correct solution for rk3588, for the rk3568 vicap this
will write 0x1 to the VICAP_MIPI_CTRL : 0x00A0 which will enable the water line.
--
Kind Regards
Mehdi Djait
next prev parent reply other threads:[~2026-03-17 13:08 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-17 9:32 [PATCH v2 0/9] media: rockchip: rkcif: add support for rk3588 vicap Michael Riesch via B4 Relay
2026-03-17 9:32 ` [PATCH v2 1/9] Documentation: admin-guide: media: add " Michael Riesch via B4 Relay
2026-03-17 13:25 ` Mehdi Djait
2026-03-19 19:30 ` Charalampos Mitrodimas
2026-03-17 9:32 ` [PATCH v2 2/9] media: dt-bindings: add rockchip " Michael Riesch via B4 Relay
2026-03-18 17:52 ` Conor Dooley
2026-03-19 8:04 ` Michael Riesch
2026-03-19 14:38 ` Conor Dooley
2026-03-17 9:32 ` [PATCH v2 3/9] media: rockchip: rkcif: add support for rk3588 vicap mipi capture Michael Riesch via B4 Relay
2026-03-17 13:08 ` Mehdi Djait [this message]
2026-03-17 13:21 ` Michael Riesch
2026-03-17 13:28 ` Mehdi Djait
2026-03-25 8:04 ` Michael Riesch
2026-03-25 9:00 ` Mehdi Djait
2026-03-17 9:32 ` [PATCH DONOTMERGE v2 4/9] media: dt-bindings: rockchip,rk3568-mipi-csi2: add rk3588 compatible Michael Riesch via B4 Relay
2026-03-17 9:32 ` [PATCH DONOTMERGE v2 5/9] arm64: dts: rockchip: add mipi csi-2 receiver nodes to rk3588 Michael Riesch via B4 Relay
2026-03-17 9:32 ` [PATCH v2 6/9] arm64: dts: rockchip: add vicap node " Michael Riesch via B4 Relay
2026-03-17 9:32 ` [PATCH v2 7/9] arm64: dts: rockchip: add radxa camera 4k on rock 5b+ cam0 Michael Riesch via B4 Relay
2026-03-17 9:32 ` [PATCH v2 8/9] arm64: dts: rockchip: add radxa camera 4k on rock 5b+ cam1 Michael Riesch via B4 Relay
2026-03-17 9:32 ` [PATCH v2 9/9] arm64: defconfig: enable designware mipi csi-2 receiver Michael Riesch via B4 Relay
2026-03-17 13:23 ` Mehdi Djait
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ablRBViDR996euua@mdjait-mobl \
--to=mehdi.djait@linux$(echo .)intel.com \
--cc=conor+dt@kernel$(echo .)org \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=heiko@sntech$(echo .)de \
--cc=jagan@amarulasolutions$(echo .)com \
--cc=kernel@collabora$(echo .)com \
--cc=kever.yang@rock-chips$(echo .)com \
--cc=krzk+dt@kernel$(echo .)org \
--cc=laurent.pinchart@ideasonboard$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-media@vger$(echo .)kernel.org \
--cc=linux-rockchip@lists$(echo .)infradead.org \
--cc=mai.kuznetsov.misha@gmail$(echo .)com \
--cc=mchehab@kernel$(echo .)org \
--cc=michael.riesch@collabora$(echo .)com \
--cc=nicolas.dufresne@collabora$(echo .)com \
--cc=robh@kernel$(echo .)org \
--cc=sakari.ailus@linux$(echo .)intel.com \
--cc=sebastian.reichel@collabora$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox