From: Dan Carpenter <error27@gmail•com>
To: Andrey Skvortsov <andrej.skvortzov@gmail•com>
Cc: Maxime Ripard <mripard@kernel•org>,
Paul Kocialkowski <paulk@sys-base•io>,
Mauro Carvalho Chehab <mchehab@kernel•org>,
Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
Chen-Yu Tsai <wens@kernel•org>,
Jernej Skrabec <jernej.skrabec@gmail•com>,
Samuel Holland <samuel@sholland•org>,
Hans Verkuil <hverkuil@kernel•org>,
linux-media@vger•kernel.org, linux-staging@lists•linux.dev,
linux-arm-kernel@lists•infradead.org,
linux-sunxi@lists•linux.dev, linux-kernel@vger•kernel.org
Subject: Re: [PATCH 2/2] media: cedrus: Fix failure to clean up hardware on probe failure
Date: Thu, 2 Apr 2026 16:00:41 +0300 [thread overview]
Message-ID: <ac5oecJ05oZD25VF@stanley.mountain> (raw)
In-Reply-To: <20260401191441.1217646-2-andrej.skvortzov@gmail.com>
On Wed, Apr 01, 2026 at 10:14:41PM +0300, Andrey Skvortsov wrote:
> From: Samuel Holland <samuel@sholland•org>
>
> From: Samuel Holland <samuel@sholland•org>
>
git am isn't set up to deal with two From: headers.
> cedrus_hw_remove undoes, that was done by cedrus_hw_probe previously,
> like disabling runtime power management, releasing claimed sram.
The first part of this sentence is missing.
Otherwise, the patch itself looks okay.
regards,
dan carpenter
next prev parent reply other threads:[~2026-04-02 13:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-01 19:14 [PATCH 1/2] media: cedrus: Fix missing cleanup in error path Andrey Skvortsov
2026-04-01 19:14 ` [PATCH 2/2] media: cedrus: Fix failure to clean up hardware on probe failure Andrey Skvortsov
2026-04-02 13:00 ` Dan Carpenter [this message]
2026-04-06 21:31 ` Andrey Skvortsov
2026-04-02 13:09 ` [PATCH 1/2] media: cedrus: Fix missing cleanup in error path Dan Carpenter
2026-04-06 21:23 ` Andrey Skvortsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac5oecJ05oZD25VF@stanley.mountain \
--to=error27@gmail$(echo .)com \
--cc=andrej.skvortzov@gmail$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=hverkuil@kernel$(echo .)org \
--cc=jernej.skrabec@gmail$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-media@vger$(echo .)kernel.org \
--cc=linux-staging@lists$(echo .)linux.dev \
--cc=linux-sunxi@lists$(echo .)linux.dev \
--cc=mchehab@kernel$(echo .)org \
--cc=mripard@kernel$(echo .)org \
--cc=paulk@sys-base$(echo .)io \
--cc=samuel@sholland$(echo .)org \
--cc=wens@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox