From: Lorenzo Stoakes <ljs@kernel•org>
To: Shinichiro Kawasaki <shinichiro.kawasaki@wdc•com>
Cc: Andrew Morton <akpm@linux-foundation•org>,
Jonathan Corbet <corbet@lwn•net>,
Clemens Ladisch <clemens@ladisch•de>,
Arnd Bergmann <arnd@arndb•de>,
Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
"K . Y . Srinivasan" <kys@microsoft•com>,
Haiyang Zhang <haiyangz@microsoft•com>,
Wei Liu <wei.liu@kernel•org>, Dexuan Cui <decui@microsoft•com>,
Long Li <longli@microsoft•com>,
Alexander Shishkin <alexander.shishkin@linux•intel.com>,
Maxime Coquelin <mcoquelin.stm32@gmail•com>,
Alexandre Torgue <alexandre.torgue@foss•st.com>,
Miquel Raynal <miquel.raynal@bootlin•com>,
Richard Weinberger <richard@nod•at>,
Vignesh Raghavendra <vigneshr@ti•com>,
Bodo Stroesser <bostroesser@gmail•com>,
"Martin K . Petersen" <martin.petersen@oracle•com>,
David Howells <dhowells@redhat•com>,
Marc Dionne <marc.dionne@auristor•com>,
Alexander Viro <viro@zeniv•linux.org.uk>,
Christian Brauner <brauner@kernel•org>, Jan Kara <jack@suse•cz>,
David Hildenbrand <david@kernel•org>,
"Liam R . Howlett" <Liam.Howlett@oracle•com>,
Vlastimil Babka <vbabka@kernel•org>,
Mike Rapoport <rppt@kernel•org>,
Suren Baghdasaryan <surenb@google•com>,
Michal Hocko <mhocko@suse•com>, Jann Horn <jannh@google•com>,
Pedro Falcato <pfalcato@suse•de>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
"linux-doc@vger•kernel.org" <linux-doc@vger•kernel.org>,
"linux-hyperv@vger•kernel.org" <linux-hyperv@vger•kernel.org>,
"linux-stm32@st-md-mailman•stormreply.com"
<linux-stm32@st-md-mailman•stormreply.com>,
"linux-arm-kernel@lists•infradead.org"
<linux-arm-kernel@lists•infradead.org>,
"linux-mtd@lists•infradead.org" <linux-mtd@lists•infradead.org>,
"linux-staging@lists•linux.dev" <linux-staging@lists•linux.dev>,
"linux-scsi@vger•kernel.org" <linux-scsi@vger•kernel.org>,
"target-devel@vger•kernel.org" <target-devel@vger•kernel.org>,
"linux-afs@lists•infradead.org" <linux-afs@lists•infradead.org>,
"linux-fsdevel@vger•kernel.org" <linux-fsdevel@vger•kernel.org>,
"linux-mm@kvack•org" <linux-mm@kvack•org>,
Ryan Roberts <ryan.roberts@arm•com>
Subject: Re: [PATCH v4 19/21] uio: replace deprecated mmap hook with mmap_prepare in uio_info
Date: Mon, 13 Apr 2026 06:37:41 +0100 [thread overview]
Message-ID: <adyAzdYVm95MZny2@lucifer> (raw)
In-Reply-To: <adx2ws5z0NMIe5Yj@shinmob>
On Mon, Apr 13, 2026 at 05:14:08AM +0000, Shinichiro Kawasaki wrote:
> On Mar 20, 2026 / 22:39, Lorenzo Stoakes (Oracle) wrote:
> > The f_op->mmap interface is deprecated, so update uio_info to use its
> > successor, mmap_prepare.
> >
> > Therefore, replace the uio_info->mmap hook with a new
> > uio_info->mmap_prepare hook, and update its one user, target_core_user,
> > to both specify this new mmap_prepare hook and also to use the new
> > vm_ops->mapped() hook to continue to maintain a correct udev->kref
> > refcount.
> >
> > Then update uio_mmap() to utilise the mmap_prepare compatibility layer to
> > invoke this callback from the uio mmap invocation.
> >
> > Signed-off-by: Lorenzo Stoakes (Oracle) <ljs@kernel•org>
>
> Hello Lorenzo, since two weeks ago, I observe a failure during my kernel test
> set targeting Linux for-next branch. On failure, kernel reported a WARN at
> __vma_check_mmap_hook [1]. I bisected and found that this patch is the trigger.
> Here I share my observations of the failure. Actions or advices for fix will be
> appreciated.
Ugh yeah thanks, this actually needs to account for use of compatibility layer,
so probably we shouldn't even assert this as that isn't easily detectable.
I'll send a hotfix for this that can be bundled up with 7.1 patches.
Cheers, Lorenzo
next prev parent reply other threads:[~2026-04-13 5:38 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-20 22:39 [PATCH v4 00/21] mm: expand mmap_prepare functionality and usage Lorenzo Stoakes (Oracle)
2026-03-20 22:39 ` [PATCH v4 01/21] mm: various small mmap_prepare cleanups Lorenzo Stoakes (Oracle)
2026-03-24 10:46 ` Vlastimil Babka (SUSE)
2026-03-20 22:39 ` [PATCH v4 02/21] mm: add documentation for the mmap_prepare file operation callback Lorenzo Stoakes (Oracle)
2026-03-20 22:39 ` [PATCH v4 03/21] mm: document vm_operations_struct->open the same as close() Lorenzo Stoakes (Oracle)
2026-03-20 22:39 ` [PATCH v4 04/21] mm: avoid deadlock when holding rmap on mmap_prepare error Lorenzo Stoakes (Oracle)
2026-03-24 10:55 ` Vlastimil Babka (SUSE)
2026-03-20 22:39 ` [PATCH v4 05/21] mm: switch the rmap lock held option off in compat layer Lorenzo Stoakes (Oracle)
2026-03-24 14:26 ` Vlastimil Babka (SUSE)
2026-03-24 16:35 ` Lorenzo Stoakes (Oracle)
2026-03-20 22:39 ` [PATCH v4 06/21] mm/vma: remove superfluous map->hold_file_rmap_lock Lorenzo Stoakes (Oracle)
2026-03-24 14:31 ` Vlastimil Babka (SUSE)
2026-03-20 22:39 ` [PATCH v4 07/21] mm: have mmap_action_complete() handle the rmap lock and unmap Lorenzo Stoakes (Oracle)
2026-03-24 14:38 ` Vlastimil Babka (SUSE)
2026-03-20 22:39 ` [PATCH v4 08/21] mm: add vm_ops->mapped hook Lorenzo Stoakes (Oracle)
2026-03-24 15:32 ` Vlastimil Babka (SUSE)
2026-03-20 22:39 ` [PATCH v4 09/21] fs: afs: revert mmap_prepare() change Lorenzo Stoakes (Oracle)
2026-03-25 9:06 ` Vlastimil Babka (SUSE)
2026-03-20 22:39 ` [PATCH v4 10/21] fs: afs: restore mmap_prepare implementation Lorenzo Stoakes (Oracle)
2026-03-25 9:47 ` Vlastimil Babka (SUSE)
2026-03-20 22:39 ` [PATCH v4 11/21] mm: add mmap_action_simple_ioremap() Lorenzo Stoakes (Oracle)
2026-03-25 9:58 ` Vlastimil Babka (SUSE)
2026-03-20 22:39 ` [PATCH v4 12/21] misc: open-dice: replace deprecated mmap hook with mmap_prepare Lorenzo Stoakes (Oracle)
2026-03-25 10:04 ` Vlastimil Babka (SUSE)
2026-03-25 10:14 ` Vlastimil Babka (SUSE)
2026-03-20 22:39 ` [PATCH v4 13/21] hpet: " Lorenzo Stoakes (Oracle)
2026-03-25 10:17 ` Vlastimil Babka (SUSE)
2026-03-20 22:39 ` [PATCH v4 14/21] mtdchar: replace deprecated mmap hook with mmap_prepare, clean up Lorenzo Stoakes (Oracle)
2026-03-25 10:20 ` Vlastimil Babka (SUSE)
2026-03-20 22:39 ` [PATCH v4 15/21] stm: replace deprecated mmap hook with mmap_prepare Lorenzo Stoakes (Oracle)
2026-03-25 10:24 ` Vlastimil Babka (SUSE)
2026-03-20 22:39 ` [PATCH v4 16/21] staging: vme_user: " Lorenzo Stoakes (Oracle)
2026-03-25 10:34 ` Vlastimil Babka (SUSE)
2026-03-20 22:39 ` [PATCH v4 17/21] mm: allow handling of stacked mmap_prepare hooks in more drivers Lorenzo Stoakes (Oracle)
2026-03-25 13:43 ` Vlastimil Babka (SUSE)
2026-03-20 22:39 ` [PATCH v4 18/21] drivers: hv: vmbus: replace deprecated mmap hook with mmap_prepare Lorenzo Stoakes (Oracle)
2026-03-23 4:16 ` Michael Kelley
2026-03-23 9:13 ` Lorenzo Stoakes (Oracle)
2026-03-25 13:57 ` Vlastimil Babka (SUSE)
2026-03-20 22:39 ` [PATCH v4 19/21] uio: replace deprecated mmap hook with mmap_prepare in uio_info Lorenzo Stoakes (Oracle)
2026-03-25 14:13 ` Vlastimil Babka (SUSE)
2026-04-13 5:14 ` Shinichiro Kawasaki
2026-04-13 5:37 ` Lorenzo Stoakes [this message]
2026-03-20 22:39 ` [PATCH v4 20/21] mm: add mmap_action_map_kernel_pages[_full]() Lorenzo Stoakes (Oracle)
2026-03-26 10:44 ` Vlastimil Babka (SUSE)
2026-03-20 22:39 ` [PATCH v4 21/21] mm: on remap assert that input range within the proposed VMA Lorenzo Stoakes (Oracle)
2026-03-26 10:46 ` Vlastimil Babka (SUSE)
2026-03-21 2:42 ` [PATCH v4 00/21] mm: expand mmap_prepare functionality and usage Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adyAzdYVm95MZny2@lucifer \
--to=ljs@kernel$(echo .)org \
--cc=Liam.Howlett@oracle$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=alexander.shishkin@linux$(echo .)intel.com \
--cc=alexandre.torgue@foss$(echo .)st.com \
--cc=arnd@arndb$(echo .)de \
--cc=bostroesser@gmail$(echo .)com \
--cc=brauner@kernel$(echo .)org \
--cc=clemens@ladisch$(echo .)de \
--cc=corbet@lwn$(echo .)net \
--cc=david@kernel$(echo .)org \
--cc=decui@microsoft$(echo .)com \
--cc=dhowells@redhat$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=haiyangz@microsoft$(echo .)com \
--cc=jack@suse$(echo .)cz \
--cc=jannh@google$(echo .)com \
--cc=kys@microsoft$(echo .)com \
--cc=linux-afs@lists$(echo .)infradead.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-doc@vger$(echo .)kernel.org \
--cc=linux-fsdevel@vger$(echo .)kernel.org \
--cc=linux-hyperv@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linux-mtd@lists$(echo .)infradead.org \
--cc=linux-scsi@vger$(echo .)kernel.org \
--cc=linux-staging@lists$(echo .)linux.dev \
--cc=linux-stm32@st-md-mailman$(echo .)stormreply.com \
--cc=longli@microsoft$(echo .)com \
--cc=marc.dionne@auristor$(echo .)com \
--cc=martin.petersen@oracle$(echo .)com \
--cc=mcoquelin.stm32@gmail$(echo .)com \
--cc=mhocko@suse$(echo .)com \
--cc=miquel.raynal@bootlin$(echo .)com \
--cc=pfalcato@suse$(echo .)de \
--cc=richard@nod$(echo .)at \
--cc=rppt@kernel$(echo .)org \
--cc=ryan.roberts@arm$(echo .)com \
--cc=shinichiro.kawasaki@wdc$(echo .)com \
--cc=surenb@google$(echo .)com \
--cc=target-devel@vger$(echo .)kernel.org \
--cc=vbabka@kernel$(echo .)org \
--cc=vigneshr@ti$(echo .)com \
--cc=viro@zeniv$(echo .)linux.org.uk \
--cc=wei.liu@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox