From: Thorsten Blum <thorsten.blum@linux•dev>
To: Lothar Rubusch <l.rubusch@gmail•com>
Cc: herbert@gondor•apana.org.au, davem@davemloft•net,
nicolas.ferre@microchip•com, alexandre.belloni@bootlin•com,
claudiu.beznea@tuxon•dev, ardb@kernel•org, linusw@kernel•org,
linux-crypto@vger•kernel.org,
linux-arm-kernel@lists•infradead.org,
linux-kernel@vger•kernel.org
Subject: Re: [PATCH v3 1/3] crypto: atmel-sha204a - fix memory leak at non-blocking RNG work_data
Date: Sun, 26 Apr 2026 15:33:03 +0200 [thread overview]
Message-ID: <ae4UD-JGUarmSMiK@linux.dev> (raw)
In-Reply-To: <20260422210936.20095-2-l.rubusch@gmail.com>
On Wed, Apr 22, 2026 at 09:09:34PM +0000, Lothar Rubusch wrote:
> The driver allocated memory for work_data in the non-blocking read
> path but never free'd it again.
Yes, 'work_data' is allocated once on the first nonblocking RNG request
and reused for subsequent requests, but the memory is eventually freed
on device removal in atmel_sha204a_remove().
The memory might be retained unnecessarily after use when the device is
idle (probably negligible), but it's not a memory leak.
Best,
Thorsten
next prev parent reply other threads:[~2026-04-26 13:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-22 21:09 [PATCH v3 0/3] crypto: atmel-sha204a - multiple RNG fixes Lothar Rubusch
2026-04-22 21:09 ` [PATCH v3 1/3] crypto: atmel-sha204a - fix memory leak at non-blocking RNG work_data Lothar Rubusch
2026-04-23 7:43 ` Ard Biesheuvel
2026-04-26 13:33 ` Thorsten Blum [this message]
2026-04-26 16:16 ` Lothar Rubusch
2026-04-22 21:09 ` [PATCH v3 2/3] crypto: atmel-sha204a - fix truncated 32-byte blocking read Lothar Rubusch
2026-04-23 7:55 ` Ard Biesheuvel
2026-04-25 13:46 ` Thorsten Blum
2026-04-25 14:08 ` Thorsten Blum
2026-04-25 14:11 ` Lothar Rubusch
2026-04-28 15:35 ` Thorsten Blum
2026-04-22 21:09 ` [PATCH v3 3/3] crypto: atmel-sha204a - fix non-blocking read logic Lothar Rubusch
2026-04-23 7:56 ` Ard Biesheuvel
2026-04-23 9:25 ` [PATCH v3 0/3] crypto: atmel-sha204a - multiple RNG fixes Ard Biesheuvel
2026-04-25 13:34 ` Lothar Rubusch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae4UD-JGUarmSMiK@linux.dev \
--to=thorsten.blum@linux$(echo .)dev \
--cc=alexandre.belloni@bootlin$(echo .)com \
--cc=ardb@kernel$(echo .)org \
--cc=claudiu.beznea@tuxon$(echo .)dev \
--cc=davem@davemloft$(echo .)net \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=l.rubusch@gmail$(echo .)com \
--cc=linusw@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-crypto@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=nicolas.ferre@microchip$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox