Subject: Re: [PATCH v6] drm/bridge: imx8qxp-pxl2dpi: avoid ERR_PTR with device_node cleanup

From: Liu Ying <[email-masked]>
Date: Thu, 7 May 2026 10:20:07 +0800

On Wed, May 06, 2026 at 10:24:34PM +0800, Guangshuo Li wrote:

[...]

> Initialize the output
> argument to NULL so callers using cleanup variables hold either NULL or
> a valid device_node pointer on error paths.

I'd rephrase:
Initialize the output argument to NULL so callers hold either NULL on
error paths or a valid device_node pointer on successful path.

> 
> Keep explicit of_node_put() usage in the helper and in
> imx8qxp_pxl2dpi_set_pixel_link_sel() so the fix avoids adding more
> cleanup action usage there.

This sentence is not necessary, so I prefer to dropping it.

With these fixed:
Reviewed-by: Liu Ying <[email-masked]>
Thanks!

-- 
Regards,
Liu Ying