From: Michael Tretter <m.tretter@pengutronix•de>
To: "Sven Püschel" <s.pueschel@pengutronix•de>
Cc: Jacob Chen <jacob-chen@iotwrt•com>,
Ezequiel Garcia <ezequiel@vanguardiasur•com.ar>,
Mauro Carvalho Chehab <mchehab@kernel•org>,
Heiko Stuebner <heiko@sntech•de>, Rob Herring <robh@kernel•org>,
Krzysztof Kozlowski <krzk+dt@kernel•org>,
Conor Dooley <conor+dt@kernel•org>,
Hans Verkuil <hverkuil@kernel•org>,
linux-media@vger•kernel.org, linux-rockchip@lists•infradead.org,
linux-arm-kernel@lists•infradead.org,
linux-kernel@vger•kernel.org, devicetree@vger•kernel.org,
kernel@pengutronix•de, nicolas@ndufresne•ca,
sebastian.reichel@collabora•com, p.zabel@pengutronix•de,
Nicolas Dufresne <nicolas.dufresne@collabora•com>
Subject: Re: [PATCH v7 08/28] media: rockchip: rga: use stride for offset calculation
Date: Thu, 21 May 2026 14:52:58 +0200 [thread overview]
Message-ID: <ag8AKgcwkZTuI3H9@pengutronix.de> (raw)
In-Reply-To: <20260521-spu-rga3-v7-8-3f33e8c7145f@pengutronix.de>
On Thu, 21 May 2026 00:44:13 +0200, Sven Püschel wrote:
> Use the stride instead of the width for the offset calculation. This
> ensures that the bytesperline value doesn't need to match the width
> value of the image.
>
> Furthermore this patch removes the dependency on the uv_factor property
> and instead reuses the v4l2_format_info to determine the correct
> division factor.
>
> Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora•com>
> Signed-off-by: Sven Püschel <s.pueschel@pengutronix•de>
Reviewed-by: Michael Tretter <m.tretter@pengutronix•de>
> ---
> drivers/media/platform/rockchip/rga/rga-buf.c | 14 +++++++++-----
> drivers/media/platform/rockchip/rga/rga.c | 16 ----------------
> drivers/media/platform/rockchip/rga/rga.h | 1 -
> 3 files changed, 9 insertions(+), 22 deletions(-)
>
> diff --git a/drivers/media/platform/rockchip/rga/rga-buf.c b/drivers/media/platform/rockchip/rga/rga-buf.c
> index bb575873f2b24..65fc0d5b4aa10 100644
> --- a/drivers/media/platform/rockchip/rga/rga-buf.c
> +++ b/drivers/media/platform/rockchip/rga/rga-buf.c
> @@ -14,7 +14,6 @@
> #include <media/videobuf2-dma-sg.h>
> #include <media/videobuf2-v4l2.h>
>
> -#include "rga-hw.h"
> #include "rga.h"
>
> static ssize_t fill_descriptors(struct rga_dma_desc *desc, size_t max_desc,
> @@ -95,14 +94,19 @@ static int rga_buf_init(struct vb2_buffer *vb)
> return 0;
> }
>
> -static int get_plane_offset(struct rga_frame *f, int plane)
> +static int get_plane_offset(struct rga_frame *f,
> + const struct v4l2_format_info *info,
> + int plane)
> {
> + u32 stride = f->pix.plane_fmt[0].bytesperline;
> +
> if (plane == 0)
> return 0;
> if (plane == 1)
> - return f->width * f->height;
> + return stride * f->height;
> if (plane == 2)
> - return f->width * f->height + (f->width * f->height / f->fmt->uv_factor);
> + return stride * f->height +
> + (stride * f->height / info->hdiv / info->vdiv);
>
> return -EINVAL;
> }
> @@ -148,7 +152,7 @@ static int rga_buf_prepare(struct vb2_buffer *vb)
> /* Fill the remaining planes */
> info = v4l2_format_info(f->fmt->fourcc);
> for (i = info->mem_planes; i < info->comp_planes; i++)
> - offsets[i] = get_plane_offset(f, i);
> + offsets[i] = get_plane_offset(f, info, i);
>
> rbuf->offset.y_off = offsets[0];
> rbuf->offset.u_off = offsets[1];
> diff --git a/drivers/media/platform/rockchip/rga/rga.c b/drivers/media/platform/rockchip/rga/rga.c
> index 4e710a050cb7c..c07207edffdb6 100644
> --- a/drivers/media/platform/rockchip/rga/rga.c
> +++ b/drivers/media/platform/rockchip/rga/rga.c
> @@ -190,7 +190,6 @@ static struct rga_fmt formats[] = {
> .color_swap = RGA_COLOR_ALPHA_SWAP,
> .hw_format = RGA_COLOR_FMT_ABGR8888,
> .depth = 32,
> - .uv_factor = 1,
> .y_div = 1,
> .x_div = 1,
> },
> @@ -199,7 +198,6 @@ static struct rga_fmt formats[] = {
> .color_swap = RGA_COLOR_RB_SWAP,
> .hw_format = RGA_COLOR_FMT_ABGR8888,
> .depth = 32,
> - .uv_factor = 1,
> .y_div = 1,
> .x_div = 1,
> },
> @@ -208,7 +206,6 @@ static struct rga_fmt formats[] = {
> .color_swap = RGA_COLOR_RB_SWAP,
> .hw_format = RGA_COLOR_FMT_XBGR8888,
> .depth = 32,
> - .uv_factor = 1,
> .y_div = 1,
> .x_div = 1,
> },
> @@ -217,7 +214,6 @@ static struct rga_fmt formats[] = {
> .color_swap = RGA_COLOR_NONE_SWAP,
> .hw_format = RGA_COLOR_FMT_RGB888,
> .depth = 24,
> - .uv_factor = 1,
> .y_div = 1,
> .x_div = 1,
> },
> @@ -226,7 +222,6 @@ static struct rga_fmt formats[] = {
> .color_swap = RGA_COLOR_RB_SWAP,
> .hw_format = RGA_COLOR_FMT_RGB888,
> .depth = 24,
> - .uv_factor = 1,
> .y_div = 1,
> .x_div = 1,
> },
> @@ -235,7 +230,6 @@ static struct rga_fmt formats[] = {
> .color_swap = RGA_COLOR_RB_SWAP,
> .hw_format = RGA_COLOR_FMT_ABGR4444,
> .depth = 16,
> - .uv_factor = 1,
> .y_div = 1,
> .x_div = 1,
> },
> @@ -244,7 +238,6 @@ static struct rga_fmt formats[] = {
> .color_swap = RGA_COLOR_RB_SWAP,
> .hw_format = RGA_COLOR_FMT_ABGR1555,
> .depth = 16,
> - .uv_factor = 1,
> .y_div = 1,
> .x_div = 1,
> },
> @@ -253,7 +246,6 @@ static struct rga_fmt formats[] = {
> .color_swap = RGA_COLOR_RB_SWAP,
> .hw_format = RGA_COLOR_FMT_BGR565,
> .depth = 16,
> - .uv_factor = 1,
> .y_div = 1,
> .x_div = 1,
> },
> @@ -262,7 +254,6 @@ static struct rga_fmt formats[] = {
> .color_swap = RGA_COLOR_UV_SWAP,
> .hw_format = RGA_COLOR_FMT_YUV420SP,
> .depth = 12,
> - .uv_factor = 4,
> .y_div = 2,
> .x_div = 1,
> },
> @@ -271,7 +262,6 @@ static struct rga_fmt formats[] = {
> .color_swap = RGA_COLOR_UV_SWAP,
> .hw_format = RGA_COLOR_FMT_YUV422SP,
> .depth = 16,
> - .uv_factor = 2,
> .y_div = 1,
> .x_div = 1,
> },
> @@ -280,7 +270,6 @@ static struct rga_fmt formats[] = {
> .color_swap = RGA_COLOR_NONE_SWAP,
> .hw_format = RGA_COLOR_FMT_YUV420SP,
> .depth = 12,
> - .uv_factor = 4,
> .y_div = 2,
> .x_div = 1,
> },
> @@ -289,7 +278,6 @@ static struct rga_fmt formats[] = {
> .color_swap = RGA_COLOR_NONE_SWAP,
> .hw_format = RGA_COLOR_FMT_YUV420SP,
> .depth = 12,
> - .uv_factor = 4,
> .y_div = 2,
> .x_div = 1,
> },
> @@ -298,7 +286,6 @@ static struct rga_fmt formats[] = {
> .color_swap = RGA_COLOR_NONE_SWAP,
> .hw_format = RGA_COLOR_FMT_YUV422SP,
> .depth = 16,
> - .uv_factor = 2,
> .y_div = 1,
> .x_div = 1,
> },
> @@ -307,7 +294,6 @@ static struct rga_fmt formats[] = {
> .color_swap = RGA_COLOR_NONE_SWAP,
> .hw_format = RGA_COLOR_FMT_YUV420P,
> .depth = 12,
> - .uv_factor = 4,
> .y_div = 2,
> .x_div = 2,
> },
> @@ -316,7 +302,6 @@ static struct rga_fmt formats[] = {
> .color_swap = RGA_COLOR_NONE_SWAP,
> .hw_format = RGA_COLOR_FMT_YUV422P,
> .depth = 16,
> - .uv_factor = 2,
> .y_div = 1,
> .x_div = 2,
> },
> @@ -325,7 +310,6 @@ static struct rga_fmt formats[] = {
> .color_swap = RGA_COLOR_UV_SWAP,
> .hw_format = RGA_COLOR_FMT_YUV420P,
> .depth = 12,
> - .uv_factor = 4,
> .y_div = 2,
> .x_div = 2,
> },
> diff --git a/drivers/media/platform/rockchip/rga/rga.h b/drivers/media/platform/rockchip/rga/rga.h
> index 2db10acecb405..477cf5b62bbb2 100644
> --- a/drivers/media/platform/rockchip/rga/rga.h
> +++ b/drivers/media/platform/rockchip/rga/rga.h
> @@ -17,7 +17,6 @@
> struct rga_fmt {
> u32 fourcc;
> int depth;
> - u8 uv_factor;
> u8 y_div;
> u8 x_div;
> u8 color_swap;
>
> --
> 2.54.0
>
>
next prev parent reply other threads:[~2026-05-21 12:53 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-20 22:44 [PATCH v7 00/28] media: platform: rga: Add RGA3 support Sven Püschel
2026-05-20 22:44 ` [PATCH v7 01/28] media: dt-bindings: media: rockchip-rga: add rockchip,rk3588-rga3 Sven Püschel
2026-05-20 22:44 ` [PATCH v7 02/28] media: v4l2-common: sort RGB formats in v4l2_format_info Sven Püschel
2026-05-20 22:44 ` [PATCH v7 03/28] media: v4l2-common: add missing 1 and 2 byte RGB formats to v4l2_format_info Sven Püschel
2026-05-20 22:44 ` [PATCH v7 04/28] media: v4l2-common: add has_alpha " Sven Püschel
2026-05-20 22:44 ` [PATCH v7 05/28] media: v4l2-common: add v4l2_fill_pixfmt_mp_aligned helper Sven Püschel
2026-05-20 23:48 ` Nicolas Dufresne
2026-05-20 22:44 ` [PATCH v7 06/28] media: rockchip: rga: fix too small buffer size Sven Püschel
2026-05-21 12:44 ` Michael Tretter
2026-05-20 22:44 ` [PATCH v7 07/28] media: rockchip: rga: use clk_bulk api Sven Püschel
2026-05-21 12:48 ` Michael Tretter
2026-05-20 22:44 ` [PATCH v7 08/28] media: rockchip: rga: use stride for offset calculation Sven Püschel
2026-05-21 12:52 ` Michael Tretter [this message]
2026-05-20 22:44 ` [PATCH v7 09/28] media: rockchip: rga: remove redundant rga_frame variables Sven Püschel
2026-05-21 13:03 ` Michael Tretter
2026-05-20 22:44 ` [PATCH v7 10/28] media: rockchip: rga: announce and sync colorimetry Sven Püschel
2026-05-21 13:44 ` Michael Tretter
2026-05-20 22:44 ` [PATCH v7 11/28] media: rockchip: rga: move hw specific parts to a dedicated struct Sven Püschel
2026-05-21 13:56 ` Michael Tretter
2026-05-20 22:44 ` [PATCH v7 12/28] media: rockchip: rga: avoid odd frame sizes for YUV formats Sven Püschel
2026-05-21 14:11 ` Michael Tretter
2026-05-20 22:44 ` [PATCH v7 13/28] media: rockchip: rga: calculate x_div/y_div using v4l2_format_info Sven Püschel
2026-05-21 14:17 ` Michael Tretter
2026-05-20 22:44 ` [PATCH v7 14/28] media: rockchip: rga: move cmdbuf to rga_ctx Sven Püschel
2026-05-21 14:20 ` Michael Tretter
2026-05-20 22:44 ` [PATCH v7 15/28] media: rockchip: rga: align stride to 4 bytes Sven Püschel
2026-05-21 14:22 ` Michael Tretter
2026-05-20 22:44 ` [PATCH v7 16/28] media: rockchip: rga: reuse cmdbuf contents Sven Püschel
2026-05-20 23:55 ` Nicolas Dufresne
2026-05-21 14:39 ` Michael Tretter
2026-05-20 22:44 ` [PATCH v7 17/28] media: rockchip: rga: check scaling factor Sven Püschel
2026-05-20 23:58 ` Nicolas Dufresne
2026-05-21 14:55 ` Michael Tretter
2026-05-20 22:44 ` [PATCH v7 18/28] media: rockchip: rga: use card type to specify rga type Sven Püschel
2026-05-21 14:28 ` Michael Tretter
2026-05-20 22:44 ` [PATCH v7 19/28] media: rockchip: rga: change offset to dma_addresses Sven Püschel
2026-05-21 15:16 ` Michael Tretter
2026-05-20 22:44 ` [PATCH v7 20/28] media: rockchip: rga: support external iommus Sven Püschel
2026-05-20 22:44 ` [PATCH v7 21/28] media: rockchip: rga: share the interrupt when an external iommu is used Sven Püschel
2026-05-20 22:44 ` [PATCH v7 22/28] media: rockchip: rga: remove size from rga_frame Sven Püschel
2026-05-20 22:44 ` [PATCH v7 23/28] media: rockchip: rga: remove stride " Sven Püschel
2026-05-20 22:44 ` [PATCH v7 24/28] media: rockchip: rga: move rga_fmt to rga-hw.h Sven Püschel
2026-05-20 22:44 ` [PATCH v7 25/28] media: rockchip: rga: add feature flags Sven Püschel
2026-05-20 22:44 ` [PATCH v7 26/28] media: rockchip: rga: disable multi-core support Sven Püschel
2026-05-20 22:44 ` [PATCH v7 27/28] media: rockchip: rga: add rga3 support Sven Püschel
2026-05-20 22:44 ` [PATCH v7 28/28] arm64: dts: rockchip: add rga3 dt nodes Sven Püschel
2026-05-27 13:34 ` (subset) [PATCH v7 00/28] media: platform: rga: Add RGA3 support Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ag8AKgcwkZTuI3H9@pengutronix.de \
--to=m.tretter@pengutronix$(echo .)de \
--cc=conor+dt@kernel$(echo .)org \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=ezequiel@vanguardiasur$(echo .)com.ar \
--cc=heiko@sntech$(echo .)de \
--cc=hverkuil@kernel$(echo .)org \
--cc=jacob-chen@iotwrt$(echo .)com \
--cc=kernel@pengutronix$(echo .)de \
--cc=krzk+dt@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-media@vger$(echo .)kernel.org \
--cc=linux-rockchip@lists$(echo .)infradead.org \
--cc=mchehab@kernel$(echo .)org \
--cc=nicolas.dufresne@collabora$(echo .)com \
--cc=nicolas@ndufresne$(echo .)ca \
--cc=p.zabel@pengutronix$(echo .)de \
--cc=robh@kernel$(echo .)org \
--cc=s.pueschel@pengutronix$(echo .)de \
--cc=sebastian.reichel@collabora$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox