From: Yeoreum Yun <yeoreum.yun@arm•com>
To: Suzuki K Poulose <suzuki.poulose@arm•com>
Cc: Leo Yan <leo.yan@arm•com>,
coresight@lists•linaro.org, linux-arm-kernel@lists•infradead.org,
linux-kernel@vger•kernel.org, mike.leach@arm•com,
james.clark@linaro•org, alexander.shishkin@linux•intel.com,
jie.gan@oss•qualcomm.com
Subject: Re: [PATCH v7 09/13] coresight: etm4x: missing cscfg_csdev_disable_active_config() in perf enable
Date: Mon, 1 Jun 2026 17:41:50 +0100 [thread overview]
Message-ID: <ah22TjH0yWKd4T3Q@e129823.arm.com> (raw)
In-Reply-To: <0fe7c30c-85e4-4205-930c-0c496d6263b8@arm.com>
> On 28/05/2026 17:01, Yeoreum Yun wrote:
> > > On Thu, May 28, 2026 at 03:43:40PM +0100, Yeoreum Yun wrote:
> > >
> > > [...]
> > >
> > > > > @@ -931,6 +919,18 @@ static int etm4_enable_perf(struct coresight_device *csdev,
> > > > > if (ret)
> > > > > goto err;
> > > > > + /*
> > > > > + * Set any selected configuration and preset. A zero configid means no
> > > > > + * configuration active, preset = 0 means no preset selected.
> > > > > + */
> > > > > + cfg_hash = ATTR_CFG_GET_FLD(attr, configid);
> > > > > + if (cfg_hash) {
> > > > > + preset = ATTR_CFG_GET_FLD(attr, preset);
> > > > > + ret = cscfg_csdev_enable_active_config(csdev, cfg_hash, preset);
> > > > > + if (ret)
> > > > > + goto err;
> > > > > + }
> > > > > +
> > >
> > > > No. since preset overrides the "perf configuratoin" formerly but
> > > > this code makes it vice versa.
> > >
> > > The above proposed change applies cfgfs after calling
> > > etm4_parse_event_config(). This is just use preset to override the
> > > config. Do I miss anything?
> >
> > Ah sorry. I've misread the code location that was my bad.
> >
> > >
> > > > Also, cfg_hash and prest is also part of
> > > > etm4_parse_event_config(), and it doesn't seem to good to separate
> > > > cfgfs handling from that function.
> > > >
> > > > IMHO, It would be better to keep this as it is.
> > >
> > > I have another version to give a try. I'd leave to you and maintainers
> > > to choose which is better.
> >
> > Funcionally, Code works. However, To be honest, the pairing between
> > etm4_parse_event_config() and etm4_clean_event_config() feels a bit artificial to me.
> >
> > So here I have simply followed the principle that,
> > if etm4_parse_event_config() fails, the configuration it touched should be
> > cleaned up within that function; and if a failure happens after
> > etm4_parse_event_config() has succeeded, the caller should perform the cleanup.
> >
> > Renaming etm4_parse_event_config() and splitting out the
> > CSCFG-related handling as suggested would be possible,
> > although I still feel it may not be strictly necessary.
> >
> > My preference would be to keep this as-is, but Suzuki, what do you think?
>
> I prefer the end result with Leo's patch applied. That kind of indicates
> clearly that we need to cleanup something from the event config parsing
> and keeps the disabling only once, rather than spreading it.
>
Okay. Then I'll apply with a little bit of modification.
Thanks
--
Sincerely,
Yeoreum Yun
next prev parent reply other threads:[~2026-06-01 16:42 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-19 15:47 [PATCH v7 00/13] fix several inconsistencies with sysfs configuration in etmX Yeoreum Yun
2026-05-19 15:48 ` [PATCH v7 01/13] coresight: etm4x: fix wrong check of etm4x_sspcicrn_present() Yeoreum Yun
2026-05-19 15:48 ` [PATCH v7 02/13] coresight: etm4x: fix underflow for nrseqstate Yeoreum Yun
2026-06-01 9:40 ` Suzuki K Poulose
2026-06-01 10:08 ` Yeoreum Yun
2026-06-01 10:13 ` Suzuki K Poulose
2026-06-01 10:15 ` Yeoreum Yun
2026-06-01 9:52 ` Suzuki K Poulose
2026-06-01 10:12 ` Yeoreum Yun
2026-05-19 15:48 ` [PATCH v7 03/13] coresight: etm4x: introduce ETM_MAX_SEQ_TRANSITIONS Yeoreum Yun
2026-05-28 12:58 ` Leo Yan
2026-05-28 13:47 ` Yeoreum Yun
2026-06-01 9:53 ` Suzuki K Poulose
2026-06-01 11:14 ` Yeoreum Yun
2026-05-19 15:48 ` [PATCH v7 04/13] coresight: etm4x: introduce struct etm4_caps Yeoreum Yun
2026-05-19 15:48 ` [PATCH v7 05/13] coresight: etm4x: exclude ss_status from drvdata->config Yeoreum Yun
2026-05-28 13:30 ` Leo Yan
2026-05-28 13:46 ` Yeoreum Yun
2026-06-01 11:27 ` Suzuki K Poulose
2026-06-01 11:52 ` Yeoreum Yun
2026-06-04 9:15 ` Suzuki K Poulose
2026-05-19 15:48 ` [PATCH v7 06/13] coresight: etm4x: remove redundant fields in etmv4_save_state Yeoreum Yun
2026-05-19 15:48 ` [PATCH v7 07/13] coresight: etm4x: fix leaked trace id Yeoreum Yun
2026-05-19 15:48 ` [PATCH v7 08/13] coresight: etm4x: fix inconsistencies with sysfs configuration Yeoreum Yun
2026-05-28 14:09 ` Leo Yan
2026-05-28 14:26 ` Yeoreum Yun
2026-05-28 14:56 ` Leo Yan
2026-05-28 15:22 ` Yeoreum Yun
2026-06-01 15:38 ` Suzuki K Poulose
2026-05-19 15:48 ` [PATCH v7 09/13] coresight: etm4x: missing cscfg_csdev_disable_active_config() in perf enable Yeoreum Yun
2026-05-28 14:33 ` Leo Yan
2026-05-28 14:43 ` Yeoreum Yun
2026-05-28 15:26 ` Leo Yan
2026-05-28 16:01 ` Yeoreum Yun
2026-06-01 16:11 ` Suzuki K Poulose
2026-06-01 16:41 ` Yeoreum Yun [this message]
2026-05-19 15:48 ` [PATCH v7 10/13] coresight: etm3x: change drvdata->spinlock type to raw_spin_lock_t Yeoreum Yun
2026-05-19 15:48 ` [PATCH v7 11/13] coresight: etm3x: introduce struct etm_caps Yeoreum Yun
2026-05-19 15:48 ` [PATCH v7 12/13] coresight: etm3x: fix inconsistencies with sysfs configuration Yeoreum Yun
2026-05-19 15:48 ` [PATCH v7 13/13] coresight: etm3x: remove redundant cpu online check on etm_enable_sysfs() Yeoreum Yun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ah22TjH0yWKd4T3Q@e129823.arm.com \
--to=yeoreum.yun@arm$(echo .)com \
--cc=alexander.shishkin@linux$(echo .)intel.com \
--cc=coresight@lists$(echo .)linaro.org \
--cc=james.clark@linaro$(echo .)org \
--cc=jie.gan@oss$(echo .)qualcomm.com \
--cc=leo.yan@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=mike.leach@arm$(echo .)com \
--cc=suzuki.poulose@arm$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox