From: Will Deacon <will@kernel•org>
To: Rong Xu <xur@google•com>
Cc: Nathan Chancellor <nathan@kernel•org>,
Yabin Cui <yabinc@google•com>, Han Shen <shenhan@google•com>,
Thomas Gleixner <tglx@linutronix•de>,
Ingo Molnar <mingo@redhat•com>, Borislav Petkov <bp@alien8•de>,
Dave Hansen <dave.hansen@linux•intel.com>,
"H. Peter Anvin" <hpa@zytor•com>, Kees Cook <kees@kernel•org>,
Nicolas Schier <nicolas.schier@linux•dev>,
Linus Walleij <linusw@kernel•org>, Arnd Bergmann <arnd@arndb•de>,
Mathieu Desnoyers <mathieu.desnoyers@efficios•com>,
Miguel Ojeda <ojeda@kernel•org>,
Peter Zijlstra <peterz@infradead•org>,
Jinjie Ruan <ruanjinjie@huawei•com>,
Lukas Bulwahn <lukas.bulwahn@redhat•com>,
linux-kernel@vger•kernel.org, Juergen Gross <jgross@suse•com>,
Helge Deller <deller@gmx•de>, Ryan Roberts <ryan.roberts@arm•com>,
Marc Zyngier <maz@kernel•org>, Ard Biesheuvel <ardb@kernel•org>,
Vincent Donnefort <vdonnefort@google•com>,
Alice Ryhl <aliceryhl@google•com>,
x86@kernel•org, linux-arm-kernel@lists•infradead.org
Subject: Re: [PATCH v3 2/2] kconfig: Remove the architecture specific config for Propeller
Date: Tue, 2 Jun 2026 10:43:18 +0100 [thread overview]
Message-ID: <ah6ltnOk2ol8_2ly@willie-the-truck> (raw)
In-Reply-To: <CAF1bQ=RNokHJtf=8RGKyP12jNPKUvyztJVRaDZ2fnXSVzZ3L5g@mail.gmail.com>
On Mon, Jun 01, 2026 at 11:18:27AM -0700, Rong Xu wrote:
> On Fri, May 29, 2026 at 5:47 PM Nathan Chancellor <nathan@kernel•org> wrote:
> > On Wed, 27 May 2026 14:45:08 -0700, xur@google•com <xur@google•com> wrote:
> > > diff --git a/arch/Kconfig b/arch/Kconfig
> > > index e510c585ea84..e4eaca9c917c 100644
> > > --- a/arch/Kconfig
> > > +++ b/arch/Kconfig
> > > @@ -879,12 +879,8 @@ config AUTOFDO_CLANG
> > >
> > > If unsure, say N.
> > >
> > > -config ARCH_SUPPORTS_PROPELLER_CLANG
> > > - bool
> > > -
> > > config PROPELLER_CLANG
> > > bool "Enable Clang's Propeller build"
> > > - depends on ARCH_SUPPORTS_PROPELLER_CLANG
> >
> > It does not look like '' or its predecessor,
> > '-fbasic-block-sections=labels', are supported by all architectures?
> > This will break allmodconfig for some architectures in that case, so
> > this needs to addressed with some other dependency.
>
> Thanks for catching this. Yes. -fbasic-block-address-map currently
> only supports Arm64 and X86_64 as of now.
> We thought people would only enable this config if they knew Propeller
> was supported on that architecture.
> But the allmodconfig build breaks this assumption. I think I have to
> keep this config for propeller, and make arm64 opt-in.
>
> >
> > | $ make -skj"$(nproc)" ARCH=arm LLVM=1 mrproper allmodconfig all
> > | ...
> > | clang: error: unsupported option '-fbasic-block-address-map' for target 'armv6k-unknown-linux-gnueabi'
> > | ...
> > |
> > | $ make -skj"$(nproc)" ARCH=s390 LLVM=1 mrproper allmodconfig all
> > | ...
> > | clang: error: unsupported option '-fbasic-block-address-map' for target 's390x-unknown-linux-gnu'
> > | ...
> >
> > Maybe something like
> >
> > depends on CC_IS_CLANG && $(cc-option,-fbasic-block-address-map)
> >
> > then cleaning up scripts/Makefile.propeller to use it exclusively?
>
> I think keep ARCH_SUPPORTS_PROPELLER_CLANG is cleaner.
I still don't think it has anything to do with the arch. If the compiler
supports the option, then we can use it. The arch code in the kernel
doesn't need to do anything, right? So can you just check if the
compiler accepts the option using a 'depends on $(cc-option, ...)' line?
Will
next prev parent reply other threads:[~2026-06-02 9:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-27 21:45 [PATCH v3 0/2] kconfig: Remove the architecture specific config for AutoFDO and Propeller xur
2026-05-27 21:45 ` [PATCH v3 1/2] kconfig: Remove the architecture specific config for AutoFDO xur
2026-05-30 0:47 ` Nathan Chancellor
2026-06-01 16:52 ` Rong Xu
2026-06-01 19:24 ` Nathan Chancellor
2026-05-27 21:45 ` [PATCH v3 2/2] kconfig: Remove the architecture specific config for Propeller xur
2026-05-30 0:47 ` Nathan Chancellor
2026-06-01 18:18 ` Rong Xu
2026-06-02 9:43 ` Will Deacon [this message]
2026-06-02 17:52 ` Rong Xu
2026-06-03 1:53 ` Nathan Chancellor
2026-06-03 22:15 ` Rong Xu
2026-06-04 14:39 ` Will Deacon
2026-05-29 16:32 ` [PATCH v3 0/2] kconfig: Remove the architecture specific config for AutoFDO and Propeller Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ah6ltnOk2ol8_2ly@willie-the-truck \
--to=will@kernel$(echo .)org \
--cc=aliceryhl@google$(echo .)com \
--cc=ardb@kernel$(echo .)org \
--cc=arnd@arndb$(echo .)de \
--cc=bp@alien8$(echo .)de \
--cc=dave.hansen@linux$(echo .)intel.com \
--cc=deller@gmx$(echo .)de \
--cc=hpa@zytor$(echo .)com \
--cc=jgross@suse$(echo .)com \
--cc=kees@kernel$(echo .)org \
--cc=linusw@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=lukas.bulwahn@redhat$(echo .)com \
--cc=mathieu.desnoyers@efficios$(echo .)com \
--cc=maz@kernel$(echo .)org \
--cc=mingo@redhat$(echo .)com \
--cc=nathan@kernel$(echo .)org \
--cc=nicolas.schier@linux$(echo .)dev \
--cc=ojeda@kernel$(echo .)org \
--cc=peterz@infradead$(echo .)org \
--cc=ruanjinjie@huawei$(echo .)com \
--cc=ryan.roberts@arm$(echo .)com \
--cc=shenhan@google$(echo .)com \
--cc=tglx@linutronix$(echo .)de \
--cc=vdonnefort@google$(echo .)com \
--cc=x86@kernel$(echo .)org \
--cc=xur@google$(echo .)com \
--cc=yabinc@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox