From: Pranjal Shrivastava <praan@google•com>
To: Nicolin Chen <nicolinc@nvidia•com>
Cc: iommu@lists•linux.dev, Will Deacon <will@kernel•org>,
Joerg Roedel <joro@8bytes•org>,
Robin Murphy <robin.murphy@arm•com>,
Jason Gunthorpe <jgg@ziepe•ca>,
Mostafa Saleh <smostafa@google•com>,
Daniel Mentz <danielmentz@google•com>,
Ashish Mhetre <amhetre@nvidia•com>,
linux-arm-kernel@lists•infradead.org
Subject: Re: [PATCH v8 00/10] iommu/arm-smmu-v3: Implement Runtime/System Sleep ops
Date: Tue, 2 Jun 2026 12:04:07 +0000 [thread overview]
Message-ID: <ah7Gt8pZbMbbE45X@google.com> (raw)
In-Reply-To: <ah5yPciJTVTjkMfJ@Asurada-Nvidia>
On Mon, Jun 01, 2026 at 11:03:41PM -0700, Nicolin Chen wrote:
> On Mon, Jun 01, 2026 at 09:58:57PM +0000, Pranjal Shrivastava wrote:
> > [v8]
> > - Centralized elision logic: dropped redundant checks from invalidation
> > call-sites; elision is now authoritative within the CMDQ layer.
> > - Renamed elision helper to arm_smmu_cmdq_can_elide() and preserved it
> > only for diagnostic/safety paths (ATC, GERROR, Page Response).
> > - Consolidated implementation-specific gating and draining into a
> > unified quiesce_and_drain_queues callback.
> > - Updated tegra241-cmdqv to gate virtual queues before draining,
> > addressing non-deterministic timeouts from guest-side submissions.
> > - Re-ordered probe sequence to enable pm_runtime only at the end,
> > aligning with SMMUv2 and simplifying error paths.
> > - Refactored KUnit tests for better, addressed Nicolin's comments & added
> > a multi-threaded kthread race test.
> > - Refactored RPM helpers to use early-return patterns for improved clarity.
> > - Collected R-bs from Nicolin.
>
> FWIW, v8 is still missing a base-commit and Sashiko fails to review:
> https://sashiko.dev/#/patchset/20260601215909.3958732-1-praan%40google.com
>
> Please make sure v9 patches are formatted with "--base=" and a public
> commit.
Ah :/ that's a shame.. I gave --base=74fa4c177ad0 to format patch which
worked for a different series [1] but not this one for some reason?
I'll ensure to add it in v9.
[1] https://lore.kernel.org/all/20260601134204.2150602-1-praan@google.com/
Thanks,
Praan
prev parent reply other threads:[~2026-06-02 12:04 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-01 21:58 [PATCH v8 00/10] iommu/arm-smmu-v3: Implement Runtime/System Sleep ops Pranjal Shrivastava
2026-06-01 21:58 ` [PATCH v8 01/12] iommu/arm-smmu-v3: Refactor arm_smmu_setup_irqs Pranjal Shrivastava
2026-06-01 21:58 ` [PATCH v8 02/12] iommu/arm-smmu-v3: Add a helper to drain cmd queues Pranjal Shrivastava
2026-06-02 0:12 ` Nicolin Chen
2026-06-02 3:28 ` Pranjal Shrivastava
2026-06-02 5:21 ` Daniel Mentz
2026-06-01 21:59 ` [PATCH v8 03/12] iommu/tegra241-cmdqv: Add a helper to drain VCMDQs Pranjal Shrivastava
2026-06-01 21:59 ` [PATCH v8 04/12] iommu/tegra241-cmdqv: Restore PROD and CONS after resume Pranjal Shrivastava
2026-06-01 21:59 ` [PATCH v8 05/12] iommu/arm-smmu-v3: Cache and restore MSI config Pranjal Shrivastava
2026-06-01 21:59 ` [PATCH v8 06/12] iommu/arm-smmu-v3: Handle gerror during suspend Pranjal Shrivastava
2026-06-02 0:15 ` Nicolin Chen
2026-06-02 3:31 ` Pranjal Shrivastava
2026-06-01 21:59 ` [PATCH v8 07/12] iommu/arm-smmu-v3: Add CMDQ_PROD_STOP_FLAG to gate CMDQ submissions Pranjal Shrivastava
2026-06-01 21:59 ` [PATCH v8 08/12] iommu/tegra241-cmdqv: Add a helper to quiesce VCMDQs Pranjal Shrivastava
2026-06-02 0:14 ` Nicolin Chen
2026-06-02 3:37 ` Pranjal Shrivastava
2026-06-02 5:59 ` Nicolin Chen
2026-06-02 6:21 ` Pranjal Shrivastava
2026-06-02 6:29 ` Nicolin Chen
2026-06-01 21:59 ` [PATCH v8 09/12] iommu/arm-smmu-v3: Implement pm_runtime & system sleep ops Pranjal Shrivastava
2026-06-02 5:25 ` Daniel Mentz
2026-06-02 12:12 ` Pranjal Shrivastava
2026-06-02 15:27 ` Daniel Mentz
2026-06-01 21:59 ` [PATCH v8 10/12] iommu/arm-smmu-v3: Enable pm_runtime and setup devlinks Pranjal Shrivastava
2026-06-01 21:59 ` [PATCH v8 11/12] iommu/arm-smmu-v3: Invoke pm_runtime before hw access Pranjal Shrivastava
2026-06-02 0:24 ` Nicolin Chen
2026-06-02 3:59 ` Pranjal Shrivastava
2026-06-02 5:51 ` Nicolin Chen
2026-06-02 6:24 ` Pranjal Shrivastava
2026-06-03 20:28 ` Daniel Mentz
2026-06-04 6:27 ` Pranjal Shrivastava
2026-06-01 21:59 ` [PATCH v8 12/12] iommu/arm-smmu-v3: Add KUnit unit tests for Runtime PM Pranjal Shrivastava
2026-06-02 6:03 ` [PATCH v8 00/10] iommu/arm-smmu-v3: Implement Runtime/System Sleep ops Nicolin Chen
2026-06-02 12:04 ` Pranjal Shrivastava [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ah7Gt8pZbMbbE45X@google.com \
--to=praan@google$(echo .)com \
--cc=amhetre@nvidia$(echo .)com \
--cc=danielmentz@google$(echo .)com \
--cc=iommu@lists$(echo .)linux.dev \
--cc=jgg@ziepe$(echo .)ca \
--cc=joro@8bytes$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=nicolinc@nvidia$(echo .)com \
--cc=robin.murphy@arm$(echo .)com \
--cc=smostafa@google$(echo .)com \
--cc=will@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox