From: Catalin Marinas <catalin.marinas@arm•com>
To: Andrew Morton <akpm@linux-foundation•org>
Cc: Alistair Popple <apopple@nvidia•com>,
linux-arm-kernel@lists•infradead.org,
linux-kernel@vger•kernel.org, linux-mm@kvack•org,
will@kernel•org, david@kernel•org
Subject: Re: [PATCH] arm64: mm: call pagetable dtor when freeing hot-removed page tables
Date: Fri, 22 May 2026 08:32:32 +0100 [thread overview]
Message-ID: <ahAGkM_I30ruK3tN@arm.com> (raw)
In-Reply-To: <ahACfQ6kCfONqz5h@arm.com>
On Fri, May 22, 2026 at 08:15:09AM +0100, Catalin Marinas wrote:
> On Thu, May 21, 2026 at 03:31:30PM -0700, Andrew Morton wrote:
> > On Thu, 21 May 2026 13:27:30 +1000 Alistair Popple <apopple@nvidia•com> wrote:
> > > diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c
> > > index 8e1d80a7033e..0c24fe650e95 100644
> > > --- a/arch/arm64/mm/mmu.c
> > > +++ b/arch/arm64/mm/mmu.c
> > > @@ -1422,6 +1422,7 @@ static void free_hotplug_page_range(struct page *page, size_t size,
> > >
> > > static void free_hotplug_pgtable_page(struct page *page)
> > > {
> > > + pagetable_dtor(page_ptdesc(page));
> > > free_hotplug_page_range(page, PAGE_SIZE, NULL);
> > > }
> >
> > I'd of course prefer that arm maintainers handle this. But
> > 5e8eb9aeeda3 came via myself so convention kinda-dictates that I get to
> > fix it.
>
> That's fine but Sashiko has some points:
>
> https://sashiko.dev/#/patchset/20260521032730.2104017-1-apopple@nvidia.com
The other Sashiko find looks like a false positive. vmemmap_*_populate()
do not allocate the page table from altmap, only the page pointed at by
the vmemmap pte.
--
Catalin
next prev parent reply other threads:[~2026-05-22 7:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-21 3:27 [PATCH] arm64: mm: call pagetable dtor when freeing hot-removed page tables Alistair Popple
2026-05-21 22:31 ` Andrew Morton
2026-05-21 23:50 ` Alistair Popple
2026-05-22 7:15 ` Catalin Marinas
2026-05-22 7:32 ` Catalin Marinas [this message]
2026-05-22 9:36 ` Vishal Moola
2026-05-26 11:54 ` Kevin Brodsky
2026-05-26 12:31 ` David Hildenbrand (Arm)
2026-05-27 7:34 ` Kevin Brodsky
2026-05-27 9:22 ` Vishal Moola
2026-05-31 19:29 ` David Hildenbrand (Arm)
2026-05-26 15:07 ` Will Deacon
2026-05-27 7:35 ` Kevin Brodsky
2026-05-27 9:30 ` Vishal Moola
2026-05-28 8:05 ` Kevin Brodsky
2026-05-29 10:16 ` Vishal Moola
2026-06-02 4:22 ` Andrew Morton
2026-06-02 13:12 ` Will Deacon
2026-06-02 17:06 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ahAGkM_I30ruK3tN@arm.com \
--to=catalin.marinas@arm$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=apopple@nvidia$(echo .)com \
--cc=david@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=will@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox