From: "Ville Syrjälä" <ville.syrjala@linux•intel.com>
To: Nicolas Frattaroli <nicolas.frattaroli@collabora•com>
Cc: "Harry Wentland" <harry.wentland@amd•com>,
"Leo Li" <sunpeng.li@amd•com>,
"Rodrigo Siqueira" <siqueira@igalia•com>,
"Alex Deucher" <alexander.deucher@amd•com>,
"Christian König" <christian.koenig@amd•com>,
"David Airlie" <airlied@gmail•com>,
"Simona Vetter" <simona@ffwll•ch>,
"Maarten Lankhorst" <maarten.lankhorst@linux•intel.com>,
"Maxime Ripard" <mripard@kernel•org>,
"Thomas Zimmermann" <tzimmermann@suse•de>,
"Andrzej Hajda" <andrzej.hajda@intel•com>,
"Neil Armstrong" <neil.armstrong@linaro•org>,
"Robert Foss" <rfoss@kernel•org>,
"Laurent Pinchart" <Laurent.pinchart@ideasonboard•com>,
"Jonas Karlman" <jonas@kwiboo•se>,
"Jernej Skrabec" <jernej.skrabec@gmail•com>,
"Sandy Huang" <hjc@rock-chips•com>,
"Heiko Stübner" <heiko@sntech•de>,
"Andy Yan" <andy.yan@rock-chips•com>,
"Jani Nikula" <jani.nikula@linux•intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel•com>,
"Joonas Lahtinen" <joonas.lahtinen@linux•intel.com>,
"Tvrtko Ursulin" <tursulin@ursulin•net>,
"Dmitry Baryshkov" <lumag@kernel•org>,
"Sascha Hauer" <s.hauer@pengutronix•de>,
"Rob Herring" <robh@kernel•org>,
"Jonathan Corbet" <corbet@lwn•net>,
"Shuah Khan" <skhan@linuxfoundation•org>,
"Daniel Stone" <daniel@fooishbar•org>,
kernel@collabora•com, amd-gfx@lists•freedesktop.org,
dri-devel@lists•freedesktop.org, linux-kernel@vger•kernel.org,
linux-arm-kernel@lists•infradead.org,
linux-rockchip@lists•infradead.org,
intel-gfx@lists•freedesktop.org, intel-xe@lists•freedesktop.org,
linux-doc@vger•kernel.org, wayland-devel@lists•freedesktop.org
Subject: Re: [PATCH v15 12/28] drm/i915/dp: Add YCBCR444 handling for sink formats
Date: Fri, 22 May 2026 22:19:14 +0300 [thread overview]
Message-ID: <ahCsMhvKzUU-3x7b@intel.com> (raw)
In-Reply-To: <20260522-color-format-v15-12-21fb136c9df2@collabora.com>
On Fri, May 22, 2026 at 02:32:03PM +0200, Nicolas Frattaroli wrote:
> In anticipation of userspace being able to explicitly select supported
> sink formats, add handling of the YCBCR444 sink format. The AUTO path
> does not choose this format, but with explicit format selection added to
> the driver, it becomes a possibility.
>
> Check for both source and sink support of YCBCR444 in
> intel_dp_sink_format_valid.
>
> Acked-by: Daniel Stone <daniel@fooishbar•org>
> Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@collabora•com>
> ---
> drivers/gpu/drm/i915/display/intel_dp.c | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index 1920d2f02666..143ed85224be 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -1344,6 +1344,20 @@ intel_dp_mode_valid_downstream(struct intel_connector *connector,
> 8, sink_format, true);
> }
>
> +static bool
> +intel_dp_can_ycbcr444(struct intel_dp *intel_dp)
> +{
> + if (source_can_output(intel_dp, INTEL_OUTPUT_FORMAT_YCBCR444) &&
> + !drm_dp_is_branch(intel_dp->dpcd))
> + return true;
> +
> + if (source_can_output(intel_dp, INTEL_OUTPUT_FORMAT_RGB) &&
> + dfp_can_convert_from_rgb(intel_dp, INTEL_OUTPUT_FORMAT_YCBCR444))
IIRC my previous conclusion was that we don't want the dfp convert
stuff here, at least initially. So this should just are about
source_can_output().
> + return true;
> +
> + return false;
> +}
> +
> static enum drm_mode_status
> intel_dp_sink_format_valid(struct intel_connector *connector,
> const struct drm_display_mode *mode,
> @@ -1364,6 +1378,13 @@ intel_dp_sink_format_valid(struct intel_connector *connector,
>
> return MODE_OK;
Again, would prefer a cleanr 420->444->rgb order.
> case INTEL_OUTPUT_FORMAT_RGB:
> + return MODE_OK;
> + case INTEL_OUTPUT_FORMAT_YCBCR444:
> + if (!(info->color_formats & BIT(DRM_OUTPUT_COLOR_FORMAT_YCBCR444)))
> + return MODE_BAD;
> + if (!intel_dp_can_ycbcr444(intel_dp))
> + return MODE_BAD;
These two ifs are swapped when compared to the HDMI version for no
good reason that I can see.
And missing the has_hdmi_sink check here as well.
> +
> return MODE_OK;
> default:
> MISSING_CASE(sink_format);
>
> --
> 2.54.0
--
Ville Syrjälä
Intel
next prev parent reply other threads:[~2026-05-22 19:19 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-22 12:31 [PATCH v15 00/28] Add new general DRM property "color format" Nicolas Frattaroli
2026-05-22 12:31 ` [PATCH v15 01/28] drm/amd/display: Remove unnecessary SIGNAL_TYPE_HDMI_TYPE_A check Nicolas Frattaroli
2026-05-22 12:31 ` [PATCH v15 02/28] drm/display: hdmi-state-helper: Use default case for unsupported formats Nicolas Frattaroli
2026-05-22 12:31 ` [PATCH v15 03/28] drm: Add new general DRM property "color format" Nicolas Frattaroli
2026-05-22 12:31 ` [PATCH v15 04/28] drm/connector: Let connectors have a say in their color format Nicolas Frattaroli
2026-05-22 12:31 ` [PATCH v15 05/28] drm/display: bridge_connector: Use HDMI color format for HDMI conns Nicolas Frattaroli
2026-05-22 12:31 ` [PATCH v15 06/28] drm/bridge: Act on the DRM color format property Nicolas Frattaroli
2026-05-22 12:31 ` [PATCH v15 07/28] drm/atomic-helper: Add HDMI bridge output bus formats helper Nicolas Frattaroli
2026-05-22 12:31 ` [PATCH v15 08/28] drm/display: hdmi-state-helper: Act on color format DRM property Nicolas Frattaroli
2026-05-22 12:32 ` [PATCH v15 09/28] drm/display: hdmi-state-helper: Try subsampling in mode_valid Nicolas Frattaroli
2026-05-22 12:32 ` [PATCH v15 10/28] drm/amdgpu: Implement "color format" DRM property Nicolas Frattaroli
2026-05-22 12:32 ` [PATCH v15 11/28] drm/i915/hdmi: Add YCBCR444 handling for sink formats Nicolas Frattaroli
2026-05-22 19:12 ` Ville Syrjälä
2026-05-22 12:32 ` [PATCH v15 12/28] drm/i915/dp: " Nicolas Frattaroli
2026-05-22 19:19 ` Ville Syrjälä [this message]
2026-05-22 12:32 ` [PATCH v15 13/28] drm/i915/hdmi: Implement "color format" DRM property Nicolas Frattaroli
2026-05-22 12:32 ` [PATCH v15 14/28] drm/i915/dp: " Nicolas Frattaroli
2026-05-22 12:32 ` [PATCH v15 15/28] drm/rockchip: Add YUV422 output mode constants for VOP2 Nicolas Frattaroli
2026-05-22 12:32 ` [PATCH v15 16/28] drm/rockchip: vop2: Add RK3576 to the RG swap special case Nicolas Frattaroli
2026-05-22 12:32 ` [PATCH v15 17/28] drm/rockchip: vop2: Recognise 10-bit YUV422 as YUV format Nicolas Frattaroli
2026-05-22 12:32 ` [PATCH v15 18/28] drm/rockchip: vop2: Set correct output format for RK3576 YUV422 Nicolas Frattaroli
2026-05-22 12:32 ` [PATCH v15 19/28] drm/bridge: dw-hdmi-qp: Use common HDMI output bus fmts helper Nicolas Frattaroli
2026-05-22 12:32 ` [PATCH v15 20/28] drm/rockchip: dw_hdmi_qp: Implement "color format" DRM property Nicolas Frattaroli
2026-05-22 12:32 ` [PATCH v15 21/28] drm/rockchip: dw_hdmi_qp: Set supported_formats platdata Nicolas Frattaroli
2026-05-22 12:32 ` [PATCH v15 22/28] drm/connector: Register color format property on HDMI connectors Nicolas Frattaroli
2026-05-22 12:32 ` [PATCH v15 23/28] drm/tests: hdmi: Add tests for the color_format property Nicolas Frattaroli
2026-05-22 12:32 ` [PATCH v15 24/28] drm/tests: hdmi: Add tests for HDMI helper's mode_valid Nicolas Frattaroli
2026-05-22 12:32 ` [PATCH v15 25/28] drm/tests: bridge: Add KUnit tests for bridge chain format selection Nicolas Frattaroli
2026-05-22 12:32 ` [PATCH v15 26/28] drm/tests: bridge: Add test for HDMI output bus formats helper Nicolas Frattaroli
2026-05-22 12:32 ` [PATCH v15 27/28] drm/bridge: Document bridge chain format selection Nicolas Frattaroli
2026-05-22 12:32 ` [PATCH v15 28/28] drm/connector: Update docs of "colorspace" for color format prop Nicolas Frattaroli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ahCsMhvKzUU-3x7b@intel.com \
--to=ville.syrjala@linux$(echo .)intel.com \
--cc=Laurent.pinchart@ideasonboard$(echo .)com \
--cc=airlied@gmail$(echo .)com \
--cc=alexander.deucher@amd$(echo .)com \
--cc=amd-gfx@lists$(echo .)freedesktop.org \
--cc=andrzej.hajda@intel$(echo .)com \
--cc=andy.yan@rock-chips$(echo .)com \
--cc=christian.koenig@amd$(echo .)com \
--cc=corbet@lwn$(echo .)net \
--cc=daniel@fooishbar$(echo .)org \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=harry.wentland@amd$(echo .)com \
--cc=heiko@sntech$(echo .)de \
--cc=hjc@rock-chips$(echo .)com \
--cc=intel-gfx@lists$(echo .)freedesktop.org \
--cc=intel-xe@lists$(echo .)freedesktop.org \
--cc=jani.nikula@linux$(echo .)intel.com \
--cc=jernej.skrabec@gmail$(echo .)com \
--cc=jonas@kwiboo$(echo .)se \
--cc=joonas.lahtinen@linux$(echo .)intel.com \
--cc=kernel@collabora$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-doc@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-rockchip@lists$(echo .)infradead.org \
--cc=lumag@kernel$(echo .)org \
--cc=maarten.lankhorst@linux$(echo .)intel.com \
--cc=mripard@kernel$(echo .)org \
--cc=neil.armstrong@linaro$(echo .)org \
--cc=nicolas.frattaroli@collabora$(echo .)com \
--cc=rfoss@kernel$(echo .)org \
--cc=robh@kernel$(echo .)org \
--cc=rodrigo.vivi@intel$(echo .)com \
--cc=s.hauer@pengutronix$(echo .)de \
--cc=simona@ffwll$(echo .)ch \
--cc=siqueira@igalia$(echo .)com \
--cc=skhan@linuxfoundation$(echo .)org \
--cc=sunpeng.li@amd$(echo .)com \
--cc=tursulin@ursulin$(echo .)net \
--cc=tzimmermann@suse$(echo .)de \
--cc=wayland-devel@lists$(echo .)freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox