From: Paul Kocialkowski <paulk@sys-base•io>
To: Arash Golgol <arash.golgol@gmail•com>
Cc: linux-media@vger•kernel.org, yong.deng@magewell•com,
mchehab@kernel•org, wens@kernel•org, jernej.skrabec@gmail•com,
samuel@sholland•org, laurent.pinchart@ideasonboard•com,
linux-arm-kernel@lists•infradead.org,
linux-sunxi@lists•linux.dev
Subject: Re: [PATCH] media: sun6i-csi: bridge: Remove duplicate mbus format entries
Date: Thu, 28 May 2026 09:41:38 +0200 [thread overview]
Message-ID: <ahfxskMC340jUtbQ@shepard> (raw)
In-Reply-To: <20260527124552.33815-1-arash.golgol@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2222 bytes --]
Hi Arash,
On Wed 27 May 26, 16:15, Arash Golgol wrote:
> The driver reports MEDIA_BUS_FMT_UYVY8_2X8 and
> MEDIA_BUS_FMT_UYVY8_1X16 twice when enumerating supported media bus
> codes.
>
> Remove the duplicated entries from sun6i_csi_bridge_formats[].
Looks good to me, thanks for taking care of this!
> Signed-off-by: Arash Golgol <arash.golgol@gmail•com>
Reviewed-by: Paul Kocialkowski <paulk@sys-base•io>
All the best,
Paul
> ---
> .../platform/sunxi/sun6i-csi/sun6i_csi_bridge.c | 12 ------------
> 1 file changed, 12 deletions(-)
>
> diff --git a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi_bridge.c b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi_bridge.c
> index d006d9dd0170..0bec0cd7620e 100644
> --- a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi_bridge.c
> +++ b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi_bridge.c
> @@ -113,12 +113,6 @@ static const struct sun6i_csi_bridge_format sun6i_csi_bridge_formats[] = {
> .input_yuv_seq = SUN6I_CSI_INPUT_YUV_SEQ_YVYU,
> .input_yuv_seq_invert = SUN6I_CSI_INPUT_YUV_SEQ_YUYV,
> },
> - {
> - .mbus_code = MEDIA_BUS_FMT_UYVY8_2X8,
> - .input_format = SUN6I_CSI_INPUT_FMT_YUV422,
> - .input_yuv_seq = SUN6I_CSI_INPUT_YUV_SEQ_UYVY,
> - .input_yuv_seq_invert = SUN6I_CSI_INPUT_YUV_SEQ_VYUY,
> - },
> {
> .mbus_code = MEDIA_BUS_FMT_VYUY8_2X8,
> .input_format = SUN6I_CSI_INPUT_FMT_YUV422,
> @@ -143,12 +137,6 @@ static const struct sun6i_csi_bridge_format sun6i_csi_bridge_formats[] = {
> .input_yuv_seq = SUN6I_CSI_INPUT_YUV_SEQ_YVYU,
> .input_yuv_seq_invert = SUN6I_CSI_INPUT_YUV_SEQ_YUYV,
> },
> - {
> - .mbus_code = MEDIA_BUS_FMT_UYVY8_1X16,
> - .input_format = SUN6I_CSI_INPUT_FMT_YUV422,
> - .input_yuv_seq = SUN6I_CSI_INPUT_YUV_SEQ_UYVY,
> - .input_yuv_seq_invert = SUN6I_CSI_INPUT_YUV_SEQ_VYUY,
> - },
> {
> .mbus_code = MEDIA_BUS_FMT_VYUY8_1X16,
> .input_format = SUN6I_CSI_INPUT_FMT_YUV422,
> --
> 2.34.1
>
--
Paul Kocialkowski,
Independent contractor - sys-base - https://www.sys-base.io/
Free software developer - https://www.paulk.fr/
Expert in multimedia, graphics and embedded hardware support with Linux.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2026-05-28 7:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-27 12:45 [PATCH] media: sun6i-csi: bridge: Remove duplicate mbus format entries Arash Golgol
2026-05-28 7:41 ` Paul Kocialkowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ahfxskMC340jUtbQ@shepard \
--to=paulk@sys-base$(echo .)io \
--cc=arash.golgol@gmail$(echo .)com \
--cc=jernej.skrabec@gmail$(echo .)com \
--cc=laurent.pinchart@ideasonboard$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-media@vger$(echo .)kernel.org \
--cc=linux-sunxi@lists$(echo .)linux.dev \
--cc=mchehab@kernel$(echo .)org \
--cc=samuel@sholland$(echo .)org \
--cc=wens@kernel$(echo .)org \
--cc=yong.deng@magewell$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox