From: "Uwe Kleine-König (The Capable Hub)" <u.kleine-koenig@baylibre•com>
To: Joshua Peisach <jpeisach@ubuntu•com>
Cc: Sebastian Reichel <sre@kernel•org>, Yixun Lan <dlan@kernel•org>,
Andreas Kemnade <andreas@kemnade•info>,
Matti Vaittinen <mazziesaccount@gmail•com>,
Sven Peter <sven@kernel•org>, Janne Grunau <j@jannau•net>,
Neal Gompa <neal@gompa•dev>,
Amit Sunil Dhamne <amitsd@google•com>,
Samuel Kayode <samkay014@gmail•com>,
linux-pm@vger•kernel.org, linux-riscv@lists•infradead.org,
spacemit@lists•linux.dev, linux-kernel@vger•kernel.org,
asahi@lists•linux.dev, linux-arm-kernel@lists•infradead.org,
imx@lists•linux.dev
Subject: Re: [PATCH v1 4/6] power: Use named initializers for platform_device_id arrays
Date: Fri, 29 May 2026 20:49:22 +0200 [thread overview]
Message-ID: <ahnev6lMK5tiUybP@monoceros> (raw)
In-Reply-To: <DIV4J6UGUQGG.28KL8EGBZWJSJ@ubuntu.com>
[-- Attachment #1: Type: text/plain, Size: 681 bytes --]
Hello Joshua,
On Fri, May 29, 2026 at 07:29:08AM -0400, Joshua Peisach wrote:
> For macsmc-power,
>
> Reviewed-by: Joshua Peisach <jpeisach@ubuntu•com>
Thanks!
> (I'm not sure if one can "Review-by" a specific section of a singular
> patch, but also the other changes in the patch look fine to me, so
> consider it reviewed as well.)
I think what you did is quite usual. The restriction doesn't make it
into git history this way though. Another usual idiom that can be found
often in git-log is:
Reviewed-by_ Joshua Peisach <jpeisach@ubuntu•com> # macsmc-power
(intentionally added did s/:/_/ to not make tools pick up this line).
Best regards
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-05-29 18:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-29 10:18 [PATCH v1 0/6] power: Use named initializers for platform_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-05-29 10:18 ` [PATCH v1 1/6] power: Drop unused assignment of platform_device_id driver data Uwe Kleine-König (The Capable Hub)
2026-05-29 22:02 ` Tzung-Bi Shih
2026-05-29 10:18 ` [PATCH v1 4/6] power: Use named initializers for platform_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-05-29 11:29 ` Joshua Peisach
2026-05-29 18:49 ` Uwe Kleine-König (The Capable Hub) [this message]
2026-06-01 6:48 ` Matti Vaittinen
2026-05-29 10:18 ` [PATCH v1 5/6] power: supply: mt6360_charger: Use of match table unconditionally Uwe Kleine-König (The Capable Hub)
2026-06-03 20:46 ` (subset) [PATCH v1 0/6] power: Use named initializers for platform_device_id arrays Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ahnev6lMK5tiUybP@monoceros \
--to=u.kleine-koenig@baylibre$(echo .)com \
--cc=amitsd@google$(echo .)com \
--cc=andreas@kemnade$(echo .)info \
--cc=asahi@lists$(echo .)linux.dev \
--cc=dlan@kernel$(echo .)org \
--cc=imx@lists$(echo .)linux.dev \
--cc=j@jannau$(echo .)net \
--cc=jpeisach@ubuntu$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-pm@vger$(echo .)kernel.org \
--cc=linux-riscv@lists$(echo .)infradead.org \
--cc=mazziesaccount@gmail$(echo .)com \
--cc=neal@gompa$(echo .)dev \
--cc=samkay014@gmail$(echo .)com \
--cc=spacemit@lists$(echo .)linux.dev \
--cc=sre@kernel$(echo .)org \
--cc=sven@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox