From: Oliver Upton <oupton@kernel•org>
To: Hyunwoo Kim <imv4bel@gmail•com>
Cc: maz@kernel•org, joey.gouly@arm•com, seiden@linux•ibm.com,
suzuki.poulose@arm•com, yuzenghui@huawei•com,
catalin.marinas@arm•com, will@kernel•org,
linux-arm-kernel@lists•infradead.org, kvmarm@lists•linux.dev,
stable@vger•kernel.org
Subject: Re: [PATCH v2] KVM: arm64: Take the SRCU lock for page table walks in fault injection and AT emulation
Date: Wed, 3 Jun 2026 16:07:50 -0700 [thread overview]
Message-ID: <aiCzxtzmx1BIw3RE@kernel.org> (raw)
In-Reply-To: <aiAZfdeyanIvP8SD@v4bel>
On Wed, Jun 03, 2026 at 09:09:33PM +0900, Hyunwoo Kim wrote:
> walk_s1() and kvm_walk_nested_s2() expect to be called while holding
> kvm->srcu to guard against memslot changes. While this is generally
> the case, __kvm_at_s12() and __kvm_find_s1_desc_level() call into the
> respective walkers without taking kvm->srcu.
>
> Fix by acquiring kvm->srcu prior to the table walk in both instances.
>
> Cc: stable@vger•kernel.org
> Fixes: 50f77dc87f13 ("KVM: arm64: Populate level on S1PTW SEA injection")
> Fixes: be04cebf3e78 ("KVM: arm64: nv: Add emulation of AT S12E{0,1}{R,W}")
> Suggested-by: Oliver Upton <oupton@kernel•org>
> Signed-off-by: Hyunwoo Kim <imv4bel@gmail•com>
Reviewed-by: Oliver Upton <oupton@kernel•org>
--
Thanks,
Oliver
prev parent reply other threads:[~2026-06-03 23:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-03 12:09 [PATCH v2] KVM: arm64: Take the SRCU lock for page table walks in fault injection and AT emulation Hyunwoo Kim
2026-06-03 23:07 ` Oliver Upton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aiCzxtzmx1BIw3RE@kernel.org \
--to=oupton@kernel$(echo .)org \
--cc=catalin.marinas@arm$(echo .)com \
--cc=imv4bel@gmail$(echo .)com \
--cc=joey.gouly@arm$(echo .)com \
--cc=kvmarm@lists$(echo .)linux.dev \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=maz@kernel$(echo .)org \
--cc=seiden@linux$(echo .)ibm.com \
--cc=stable@vger$(echo .)kernel.org \
--cc=suzuki.poulose@arm$(echo .)com \
--cc=will@kernel$(echo .)org \
--cc=yuzenghui@huawei$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox