Subject: Re: [PATCH] pinctrl: meson: meson: Add of_node_put() before return

From: Neil Armstrong <[email-masked]>
Date: Wed, 21 Aug 2019 16:24:50 +0200

On 15/08/2019 08:07, Nishka Dasgupta wrote:
> Each iteration of for_each_child_of_node puts the previous node, but in
> the case of a return from the middle of the loop, there is no put, thus
> causing a memory leak. Hence add an of_node_put before the return.
> Issue found with Coccinelle.
> 
> Signed-off-by: Nishka Dasgupta <[email-masked]>
> ---
>  drivers/pinctrl/meson/pinctrl-meson.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/pinctrl/meson/pinctrl-meson.c b/drivers/pinctrl/meson/pinctrl-meson.c
> index 596786926209..8bba9d053d9f 100644
> --- a/drivers/pinctrl/meson/pinctrl-meson.c
> +++ b/drivers/pinctrl/meson/pinctrl-meson.c
> @@ -651,6 +651,7 @@ static int meson_pinctrl_parse_dt(struct meson_pinctrl *pc,
>  			continue;
>  		if (gpio_np) {
>  			dev_err(pc->dev, "multiple gpio nodes\n");
> +			of_node_put(np);
>  			return -EINVAL;
>  		}
>  		gpio_np = np;
> 

Reviewed-by: Neil Armstrong <[email-masked]>

_______________________________________________
linux-arm-kernel mailing list
[email-masked]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel