From: cpandya@codeaurora•org (Chintan Pandya)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3 2/3] arm64: Implement page table free interfaces
Date: Tue, 20 Mar 2018 12:36:10 +0530 [thread overview]
Message-ID: <be70a3da-be35-cdee-97a4-ca4e867ca7fb@codeaurora.org> (raw)
In-Reply-To: <1521487759.2693.224.camel@hpe.com>
On 3/20/2018 12:59 AM, Kani, Toshi wrote:
> On Mon, 2018-03-19 at 18:10 +0530, Chintan Pandya wrote:
>> Implement pud_free_pmd_page() and pmd_free_pte_page().
>>
>> Implementation requires,
>> 1) Freeing of the un-used next level page tables
>> 2) Clearing off the current pud/pmd entry
>> 3) Invalidate TLB which could have previously
>> valid but not stale entry
>>
>> Signed-off-by: Chintan Pandya <cpandya@codeaurora•org>
>> ---
>> arch/arm64/mm/mmu.c | 30 ++++++++++++++++++++++++++++--
>> 1 file changed, 28 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c
>> index da98828..c70f139 100644
>> --- a/arch/arm64/mm/mmu.c
>> +++ b/arch/arm64/mm/mmu.c
>> @@ -45,6 +45,7 @@
>> #include <asm/memblock.h>
>> #include <asm/mmu_context.h>
>> #include <asm/ptdump.h>
>> +#include <asm/tlbflush.h>
>>
>> #define NO_BLOCK_MAPPINGS BIT(0)
>> #define NO_CONT_MAPPINGS BIT(1)
>> @@ -975,10 +976,35 @@ int pmd_clear_huge(pmd_t *pmdp)
>>
>> int pud_free_pmd_page(pud_t *pud, unsigned long addr)
>> {
>> - return pud_none(*pud);
>> + pmd_t *pmd;
>> + int i;
>> +
>> + pmd = __va(pud_val(*pud));
>> + if (pud_val(*pud)) {
>> + for (i = 0; i < PTRS_PER_PMD; i++)
>> + pmd_free_pte_page(&pmd[i], addr + (i * PMD_SIZE));
>> +
>> + free_page((unsigned long) pmd);
>
> Why do you want to free this pmd page before clearing the pud entry on
> this arm64 version (as it seems you intentionally changed it from the
> x86 version)? It can be reused while being pointed by the pud. Same
> for pmd.
Noted.
>
>> + pud_clear(pud);
>> + flush_tlb_kernel_range(addr, addr + PUD_SIZE);
>
> Since you purge the entire pud range here, do you still need to call
> pmd_free_pte_page() to purge each pmd range? This looks very expensive.
> You may want to consider if calling internal __pmd_free_pte_page()
> without the purge operation works.
I completely missed that. Sure, will fix this.
I will upload v4 fixing all 4 comments.
>
> -Toshi
>
Chintan
--
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center,
Inc. is a member of the Code Aurora Forum, a Linux Foundation
Collaborative Project
next prev parent reply other threads:[~2018-03-20 7:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-19 12:40 [PATCH v3 0/3] Fix issues with huge mapping in ioremap for ARM64 Chintan Pandya
2018-03-19 12:40 ` [PATCH v3 1/3] ioremap: Update pgtable free interfaces with addr Chintan Pandya
2018-03-19 19:01 ` Kani, Toshi
2018-03-20 7:04 ` Chintan Pandya
2018-03-19 12:40 ` [PATCH v3 2/3] arm64: Implement page table free interfaces Chintan Pandya
2018-03-19 19:29 ` Kani, Toshi
2018-03-20 7:06 ` Chintan Pandya [this message]
2018-03-19 12:40 ` [PATCH v3 3/3] Revert "arm64: Enforce BBM for huge IO/VMAP mappings" Chintan Pandya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be70a3da-be35-cdee-97a4-ca4e867ca7fb@codeaurora.org \
--to=cpandya@codeaurora$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox