Subject: Re: [PATCH v17 12/24] KVM: x86/mmu: Rename .private_max_mapping_level() to .gmem_max_mapping_level()

From: David Hildenbrand <[email-masked]>
Date: Thu, 31 Jul 2025 10:29:34 +0200

On 31.07.25 10:15, Fuad Tabba wrote:
> On Tue, 29 Jul 2025 at 23:55, Sean Christopherson <[email-masked]> wrote:
>>
>> From: Ackerley Tng <[email-masked]>
>>
>> Rename kvm_x86_ops.private_max_mapping_level() to .gmem_max_mapping_level()
>> in anticipation of extending guest_memfd support to non-private memory.
>>
>> No functional change intended.
>>
>> Reviewed-by: Xiaoyao Li <[email-masked]>
>> Acked-by: David Hildenbrand <[email-masked]>
>> Signed-off-by: Ackerley Tng <[email-masked]>
>> Signed-off-by: Fuad Tabba <[email-masked]>
>> Co-developed-by: Sean Christopherson <[email-masked]>
>> Signed-off-by: Sean Christopherson <[email-masked]>
>> ---
> 
> nit: remove my "Signed-off-by", since I'm not a co-developer, and instead:

The patch went "through your hands", right? In that case, a SOB is the 
right thing to do.

"The Signed-off-by: tag indicates that the signer was involved in the
development of the patch, or that he/she was in the patch's delivery path."

-- 
Cheers,

David / dhildenb