From: Jason Wang <jasowang@redhat•com>
To: Hillf Danton <hdanton@sina•com>
Cc: aarcange@redhat•com, Christoph Hellwig <hch@infradead•org>,
linux-parisc@vger•kernel.org, kvm@vger•kernel.org,
mst@redhat•com, netdev@vger•kernel.org,
linux-kernel@vger•kernel.org,
virtualization@lists•linux-foundation.org,
James Bottomley <James.Bottomley@hansenpartnership•com>,
linux-mm@kvack•org, jglisse@redhat•com, jgg@mellanox•com,
David Miller <davem@davemloft•net>,
linux-arm-kernel@lists•infradead.org
Subject: Re: [PATCH 2/2] vhost: re-introducing metadata acceleration through kernel virtual address
Date: Fri, 6 Sep 2019 20:51:29 +0800 [thread overview]
Message-ID: <cd2ed116-4b19-73b2-a3f0-4377cc0f2db3@redhat.com> (raw)
In-Reply-To: <20190906032154.9376-1-hdanton@sina.com>
On 2019/9/6 上午11:21, Hillf Danton wrote:
> On Thu, 5 Sep 2019 20:27:36 +0800 From: Jason Wang <jasowang@redhat•com>
>> +static void vhost_set_map_dirty(struct vhost_virtqueue *vq,
>> + struct vhost_map *map, int index)
>> +{
>> + struct vhost_uaddr *uaddr = &vq->uaddrs[index];
>> + int i;
>> +
>> + if (uaddr->write) {
>> + for (i = 0; i < map->npages; i++)
>> + set_page_dirty(map->pages[i]);
>> + }
> Not sure need to set page dirty under page lock.
Just to make sure I understand the issue. Do you mean there's no need
for set_page_dirty() here? If yes, is there any other function that
already did this?
Thanks
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-09-06 12:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190905122736.19768-1-jasowang@redhat.com>
2019-09-05 12:27 ` [PATCH 2/2] vhost: re-introducing metadata acceleration through kernel virtual address Jason Wang
2019-09-08 11:05 ` Michael S. Tsirkin
2019-09-09 2:18 ` Jason Wang
2019-09-09 2:30 ` Jason Wang
2019-09-09 4:45 ` Michael S. Tsirkin
2019-09-09 7:23 ` Jason Wang
2019-09-06 3:21 ` Hillf Danton
2019-09-06 12:51 ` Jason Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd2ed116-4b19-73b2-a3f0-4377cc0f2db3@redhat.com \
--to=jasowang@redhat$(echo .)com \
--cc=James.Bottomley@hansenpartnership$(echo .)com \
--cc=aarcange@redhat$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=hch@infradead$(echo .)org \
--cc=hdanton@sina$(echo .)com \
--cc=jgg@mellanox$(echo .)com \
--cc=jglisse@redhat$(echo .)com \
--cc=kvm@vger$(echo .)kernel.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linux-parisc@vger$(echo .)kernel.org \
--cc=mst@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=virtualization@lists$(echo .)linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox