From: <Eugen.Hristev@microchip•com>
To: <wsa@the-dreams•de>
Cc: mark.rutland@arm•com, devicetree@vger•kernel.org,
alexandre.belloni@bootlin•com, linux-kernel@vger•kernel.org,
pierre-yves.mordret@st•com, Ludovic.Desroches@microchip•com,
robh+dt@kernel•org, linux-i2c@vger•kernel.org, peda@axentia•se,
linux-arm-kernel@lists•infradead.org
Subject: Re: [PATCH v3 5/9] i2c: at91: add support for digital filtering
Date: Mon, 2 Sep 2019 08:54:06 +0000 [thread overview]
Message-ID: <d461426b-50ac-bf6c-79e0-71e17a63400e@microchip.com> (raw)
In-Reply-To: <20190831121751.GC1032@ninjato>
On 31.08.2019 15:17, Wolfram Sang wrote:
>
>>> + dev->enable_dig_filt = of_property_read_bool(pdev->dev.of_node,
>>> + "i2c-dig-filter");
>>> +
>>
>> What do you think of the idea to introduce 'flags' to struct i2c_timings
>> and parse the bindings in the core, too? Then you'd have sth like:
>>
>> if (t->flags & I2C_TIMINGS_ANALOG_FILTER)
>>
>> Would that be useful for you?
>
> Forgot to say, we can also implement this incrementally to make sure
> your patches land in 5.4 in case you are currently busy with sth else.
>
Hi Wolfram,
Your idea looks good but I would prefer to have it as a separate
enhancement patch, after this series gets in.
As things are now, this series/patches do just the filtering part. We
can then move all the optional 'flags' as another change.
So yes, we can do this incrementally.
Thanks !
Eugen
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists•infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-09-02 8:54 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-09 13:19 [PATCH v3 0/9] i2c: add support for filters Eugen.Hristev
2019-07-09 13:19 ` [PATCH v3 1/9] dt-bindings: i2c: at91: add new compatible Eugen.Hristev
2019-07-24 20:22 ` Rob Herring
2019-07-09 13:19 ` [PATCH v3 2/9] dt-bindings: i2c: add bindings for i2c analog and digital filter Eugen.Hristev
2019-07-24 20:22 ` Rob Herring
2019-08-31 11:39 ` Wolfram Sang
2019-07-09 13:19 ` [PATCH v3 3/9] i2c: add support for filter-width-ns optional property Eugen.Hristev
2019-07-09 13:19 ` [PATCH v3 4/9] i2c: at91: add new platform support for sam9x60 Eugen.Hristev
2019-07-09 13:19 ` [PATCH v3 5/9] i2c: at91: add support for digital filtering Eugen.Hristev
2019-08-31 12:13 ` Wolfram Sang
2019-08-31 12:17 ` Wolfram Sang
2019-09-02 8:54 ` Eugen.Hristev [this message]
2019-07-09 13:19 ` [PATCH v3 6/9] i2c: at91: add support for advanced " Eugen.Hristev
2019-07-09 13:19 ` [PATCH v3 7/9] i2c: at91: add support for analog filtering Eugen.Hristev
2019-07-09 13:19 ` [PATCH v3 8/9] ARM: dts: at91: sama5d2_xplained: add analog and digital filter for i2c Eugen.Hristev
2019-07-09 13:19 ` [PATCH v3 9/9] ARM: dts: at91: sama5d4_xplained: add " Eugen.Hristev
2019-07-12 8:20 ` [PATCH v3 0/9] i2c: add support for filters Ludovic Desroches
2019-08-22 15:00 ` Eugen.Hristev
2019-08-29 20:28 ` Wolfram Sang
2019-08-31 12:19 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d461426b-50ac-bf6c-79e0-71e17a63400e@microchip.com \
--to=eugen.hristev@microchip$(echo .)com \
--cc=Ludovic.Desroches@microchip$(echo .)com \
--cc=alexandre.belloni@bootlin$(echo .)com \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-i2c@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=mark.rutland@arm$(echo .)com \
--cc=peda@axentia$(echo .)se \
--cc=pierre-yves.mordret@st$(echo .)com \
--cc=robh+dt@kernel$(echo .)org \
--cc=wsa@the-dreams$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox