From: Stefan Wahren <wahrenst@gmx•net>
To: Gregor Herburger <gregor.herburger@linutronix•de>,
Rob Herring <robh@kernel•org>,
Krzysztof Kozlowski <krzk+dt@kernel•org>,
Conor Dooley <conor+dt@kernel•org>,
Florian Fainelli <florian.fainelli@broadcom•com>,
Ray Jui <rjui@broadcom•com>,
Scott Branden <sbranden@broadcom•com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom•com>,
Eric Anholt <eric@anholt•net>,
Srinivas Kandagatla <srini@kernel•org>,
Kees Cook <kees@kernel•org>,
"Gustavo A. R. Silva" <gustavoars@kernel•org>
Cc: devicetree@vger•kernel.org, linux-rpi-kernel@lists•infradead.org,
linux-arm-kernel@lists•infradead.org,
linux-kernel@vger•kernel.org, linux-hardening@vger•kernel.org
Subject: Re: [PATCH v4 0/5] nvmem: Add Raspberry Pi OTP nvmem driver
Date: Tue, 19 May 2026 16:55:10 +0200 [thread overview]
Message-ID: <d9e3e10a-c346-4391-b133-4b60fbee5dc3@gmx.net> (raw)
In-Reply-To: <20260508-rpi-otp-driver-v4-0-cf8d725d8821@linutronix.de>
Hi Gregor,
Am 08.05.26 um 16:42 schrieb Gregor Herburger:
> Hi,
>
> This series adds support for the Raspberry Pis OTP registers. The
> Raspberry Pi has one or more OTP regions. These registers are accessible
> through the firmware. Add a driver for it and add updates the devicetree
> for the Raspberry Pi 5.
>
> ---
> Changes in v4:
> - Additional patch to drop unnecessary select schema
> - fix dt-bindings
> - use __counted_by_le
> - additional alignment check in read/write callbacks
> - Link to v3: https://patch.msgid.link/20260506-rpi-otp-driver-v3-0-294602663695@linutronix.de
>
> Changes in v3:
> - dts: add "raspberrypi,bcm2835-firmware" as fallback and fix dt-bindings
> - Fix Kconfig depends
> - Changed firmware data fields to __le32
> - Add MODULE_ALIAS
> - Link to v2: https://patch.msgid.link/20260505-rpi-otp-driver-v2-0-e9176ec72837@linutronix.de
>
> Changes in v2:
> - register nvmem driver from firmware driver and drop firmware sub nodes
> - Use struct_size and __counted_by for dynamic array
> - Drop unneeded comment in Kconfig
> - Use NVMEM_DEVID_NONE
> - Use kzalloc
> - Update module description
> - Link to v1: https://patch.msgid.link/20260408-rpi-otp-driver-v1-0-e02d1dbe6008@linutronix.de
>
> ---
> Gregor Herburger (5):
> dt-bindings: raspberrypi,bcm2835-firmware: Add bcm2712-firmware compatible
> nvmem: Add the Raspberry Pi OTP driver
> firmware: raspberrypi: register nvmem driver
> arm64: dts: broadcom: bcm2712: add raspberrypi,bcm2712-firmware compatible
> dt-bindings: raspberrypi,bcm2835-firmware: Drop unnecessary select
>
> .../arm/bcm/raspberrypi,bcm2835-firmware.yaml | 20 ++--
> .../boot/dts/broadcom/bcm2712-rpi-5-b-base.dtsi | 4 +-
> drivers/firmware/raspberrypi.c | 59 +++++++++-
> drivers/nvmem/Kconfig | 10 ++
> drivers/nvmem/Makefile | 1 +
> drivers/nvmem/raspberrypi-otp.c | 130 +++++++++++++++++++++
> include/soc/bcm2835/raspberrypi-firmware.h | 14 +++
> 7 files changed, 224 insertions(+), 14 deletions(-)
since you plan to submit a V5 of this series, could you please append
another patch to enable the driver as module for arm64/defconfig?
Thanks
next prev parent reply other threads:[~2026-05-19 14:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-08 14:42 [PATCH v4 0/5] nvmem: Add Raspberry Pi OTP nvmem driver Gregor Herburger
2026-05-08 14:42 ` [PATCH v4 1/5] dt-bindings: raspberrypi,bcm2835-firmware: Add bcm2712-firmware compatible Gregor Herburger
2026-05-08 14:58 ` Conor Dooley
2026-05-08 14:42 ` [PATCH v4 2/5] nvmem: Add the Raspberry Pi OTP driver Gregor Herburger
2026-05-10 9:37 ` Stefan Wahren
2026-05-19 9:14 ` Thomas Weißschuh
2026-05-19 10:20 ` Gregor Herburger
2026-05-19 10:47 ` Thomas Weißschuh
2026-05-19 14:42 ` Gregor Herburger
2026-05-08 14:42 ` [PATCH v4 3/5] firmware: raspberrypi: register nvmem driver Gregor Herburger
2026-05-19 9:15 ` Thomas Weißschuh
2026-05-19 10:21 ` Gregor Herburger
2026-05-08 14:42 ` [PATCH v4 4/5] arm64: dts: broadcom: bcm2712: add raspberrypi,bcm2712-firmware compatible Gregor Herburger
2026-05-10 9:29 ` Stefan Wahren
2026-05-08 14:42 ` [PATCH v4 5/5] dt-bindings: raspberrypi,bcm2835-firmware: Drop unnecessary select Gregor Herburger
2026-05-09 15:56 ` Conor Dooley
2026-05-19 14:55 ` Stefan Wahren [this message]
2026-05-19 15:20 ` [PATCH v4 0/5] nvmem: Add Raspberry Pi OTP nvmem driver Gregor Herburger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9e3e10a-c346-4391-b133-4b60fbee5dc3@gmx.net \
--to=wahrenst@gmx$(echo .)net \
--cc=bcm-kernel-feedback-list@broadcom$(echo .)com \
--cc=conor+dt@kernel$(echo .)org \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=eric@anholt$(echo .)net \
--cc=florian.fainelli@broadcom$(echo .)com \
--cc=gregor.herburger@linutronix$(echo .)de \
--cc=gustavoars@kernel$(echo .)org \
--cc=kees@kernel$(echo .)org \
--cc=krzk+dt@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-hardening@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-rpi-kernel@lists$(echo .)infradead.org \
--cc=rjui@broadcom$(echo .)com \
--cc=robh@kernel$(echo .)org \
--cc=sbranden@broadcom$(echo .)com \
--cc=srini@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox