From: Anshuman Khandual <anshuman.khandual@arm•com>
To: Vineet Gupta <Vineet.Gupta1@synopsys•com>,
"linux-mm@kvack•org" <linux-mm@kvack•org>,
Andrew Morton <akpm@linux-foundation•org>
Cc: Mark Rutland <mark.rutland@arm•com>,
"linux-ia64@vger•kernel.org" <linux-ia64@vger•kernel.org>,
"linux-sh@vger•kernel.org" <linux-sh@vger•kernel.org>,
Peter Zijlstra <peterz@infradead•org>,
James Hogan <jhogan@kernel•org>,
Heiko Carstens <heiko.carstens@de•ibm.com>,
Michal Hocko <mhocko@kernel•org>,
Dave Hansen <dave.hansen@intel•com>,
Paul Mackerras <paulus@samba•org>,
"sparclinux@vger•kernel.org" <sparclinux@vger•kernel.org>,
Dan Williams <dan.j.williams@intel•com>,
"linux-s390@vger•kernel.org" <linux-s390@vger•kernel.org>,
Jason Gunthorpe <jgg@ziepe•ca>,
Michael Ellerman <mpe@ellerman•id.au>,
"x86@kernel•org" <x86@kernel•org>,
Russell King - ARM Linux <linux@armlinux•org.uk>,
Matthew Wilcox <willy@infradead•org>,
Steven Price <Steven.Price@arm•com>,
Tetsuo Handa <penguin-kernel@i-love•sakura.ne.jp>,
Gerald Schaefer <gerald.schaefer@de•ibm.com>,
"linux-snps-arc@lists•infradead.org"
<linux-snps-arc@lists•infradead.org>,
"linux-arm-kernel@lists•infradead.org"
<linux-arm-kernel@lists•infradead.org>,
Ingo Molnar <mingo@kernel•org>, Kees Cook <keescook@chromium•org>,
Masahiro Yamada <yamada.masahiro@socionext•com>,
Mark Brown <broonie@kernel•org>,
"Kirill A . Shutemov" <kirill@shutemov•name>,
Thomas Gleixner <tglx@linutronix•de>,
Vlastimil Babka <vbabka@suse•cz>,
Christophe Leroy <christophe.leroy@c-s•fr>,
Sri Krishna chowdary <schowdary@nvidia•com>,
Ard Biesheuvel <ard.biesheuvel@linaro•org>,
Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
"linux-mips@vger•kernel.org" <linux-mips@vger•kernel.org>,
Ralf Baechle <ralf@linux-mips•org>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
Paul Burton <paul.burton@mips•com>,
Mike Rapoport <rppt@linux•vnet.ibm.com>,
Martin Schwidefsky <schwidefsky@de•ibm.com>,
"linuxppc-dev@lists•ozlabs.org" <linuxppc-dev@lists•ozlabs.org>,
"David S. Miller" <davem@davemloft•net>
Subject: Re: [PATCH V8] mm/debug: Add tests validating architecture page table helpers
Date: Thu, 7 Nov 2019 10:14:30 +0530 [thread overview]
Message-ID: <da665683-6946-b411-57f9-e1689d4b50fe@arm.com> (raw)
In-Reply-To: <b93ffe1f-b198-a042-ecd4-b0f2b0171f72@synopsys.com>
On 11/06/2019 11:37 PM, Vineet Gupta wrote:
> On 11/5/19 7:03 PM, Anshuman Khandual wrote:
>> But should not pfn_pmd() be encapsulated inside HAVE_ARCH_TRANSPARENT_HUGEPAGE
>> at the minimum (but I would say it should be available always, nonetheless) when
>> the platform subscribes to THP irrespective of whether THP is enabled or not.
>
> For ARC it was only introduced/needed when I added THP support so it is dependent
> in some way.
Right, it is dependent.
>
>> I could see in the file (arch/arc/include/asm/pgtable.h) that fetching pfn_pmd()
>> and all other basic PMD definitions is conditional on CONFIG_TRANSPARENT_HUGEPAGE.
>>
>> #ifdef CONFIG_TRANSPARENT_HUGEPAGE
>> #include <asm/hugepage.h>
>> #endif
>>
>> IIUC, CONFIG_TRANSPARENT_HUGEPAGE should only encapsulate PMD page table helpers
>> which are expected from generic THP code (pmd_trans_huge, pmdp_set_access_flags
>> etc) but not the basic PMD helpers like pmd_pfn, pmd_mkyoung, pmd_mkdirty,
>> pmd_mkclean etc.
>
> ARC only has 2 levels of paging, so these don't make any sense in general and
> needed only for THP case.
> I case of arch/arm you see it is only defined in pgtable-3level.h
There is no uniformity for all these across architectures. It has been bit
difficult to get some of these required helpers right (compile and run) on
different platforms.
>
>> Hence wondering will it be possible to accommodate following
>> code change on arc platform (not even compiled) in order to fix the problem ?
>
> I'm open to making changes in ARC code but lets do the right thing.
>
>> */
>> -#ifdef CONFIG_TRANSPARENT_HUGEPAGE
>> +#ifdef CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE
>> #include <asm/hugepage.h>
>> #endif
>
> This in wrong. CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE is a just a glue toggle,
> used only in Kconfig files (and not in any "C" code). It enables generic Kconfig
> code to allow visibility of CONFIG_TRANSPARENT_HUGEPAGE w/o every arch needing to
> do a me too.
>
> I think you need to use CONFIG_TRANSPARENT_HUGEPAGE to guard appropriate tests. I
> understand that it only
We can probably replace CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE wrapper with
CONFIG_TRANSPARENT_HUGEPAGE. But CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD
explicitly depends on CONFIG_TRANSPARENT_HUGEPAGE as a prerequisite. Could
you please confirm if the following change on this test will work on ARC
platform for both THP and !THP cases ? Thank you.
diff --git a/mm/debug_vm_pgtable.c b/mm/debug_vm_pgtable.c
index 621ac09..99ebc7c 100644
--- a/mm/debug_vm_pgtable.c
+++ b/mm/debug_vm_pgtable.c
@@ -67,7 +67,7 @@ static void __init pte_basic_tests(unsigned long pfn, pgprot_t prot)
WARN_ON(pte_write(pte_wrprotect(pte)));
}
-#ifdef CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE
+#ifdef CONFIG_TRANSPARENT_HUGEPAGE
static void __init pmd_basic_tests(unsigned long pfn, pgprot_t prot)
{
pmd_t pmd = pfn_pmd(pfn, prot);
@@ -85,9 +85,6 @@ static void __init pmd_basic_tests(unsigned long pfn, pgprot_t prot)
*/
WARN_ON(!pmd_bad(pmd_mkhuge(pmd)));
}
-#else
-static void __init pmd_basic_tests(unsigned long pfn, pgprot_t prot) { }
-#endif
#ifdef CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD
static void __init pud_basic_tests(unsigned long pfn, pgprot_t prot)
@@ -112,6 +109,10 @@ static void __init pud_basic_tests(unsigned long pfn, pgprot_t prot)
#else
static void __init pud_basic_tests(unsigned long pfn, pgprot_t prot) { }
#endif
+#else
+static void __init pmd_basic_tests(unsigned long pfn, pgprot_t prot) { }
+static void __init pud_basic_tests(unsigned long pfn, pgprot_t prot) { }
+#endif
static void __init p4d_basic_tests(unsigned long pfn, pgprot_t prot)
{
> -Vineet
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-11-07 4:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-28 5:29 [PATCH V8] mm/debug: Add tests validating architecture page table helpers Anshuman Khandual
2019-10-29 10:31 ` Qian Cai
2019-11-04 2:15 ` Anshuman Khandual
2019-11-05 0:00 ` Anshuman Khandual
2019-11-05 22:30 ` Vineet Gupta
2019-11-06 3:03 ` Anshuman Khandual
2019-11-06 18:07 ` Vineet Gupta
2019-11-07 4:44 ` Anshuman Khandual [this message]
2019-11-07 19:05 ` Vineet Gupta
2019-11-08 4:27 ` Anshuman Khandual
2019-11-11 19:06 ` Vineet Gupta
2019-11-05 0:30 ` Anshuman Khandual
2019-11-05 19:36 ` Gerald Schaefer
2019-11-06 3:10 ` Anshuman Khandual
2019-11-06 3:22 ` Anshuman Khandual
2019-11-06 6:41 ` Christophe Leroy
2019-11-06 7:34 ` Anshuman Khandual
2019-11-07 12:54 ` Michael Ellerman
2019-11-07 13:22 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da665683-6946-b411-57f9-e1689d4b50fe@arm.com \
--to=anshuman.khandual@arm$(echo .)com \
--cc=Steven.Price@arm$(echo .)com \
--cc=Vineet.Gupta1@synopsys$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=ard.biesheuvel@linaro$(echo .)org \
--cc=broonie@kernel$(echo .)org \
--cc=christophe.leroy@c-s$(echo .)fr \
--cc=dan.j.williams@intel$(echo .)com \
--cc=dave.hansen@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=gerald.schaefer@de$(echo .)ibm.com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=heiko.carstens@de$(echo .)ibm.com \
--cc=jgg@ziepe$(echo .)ca \
--cc=jhogan@kernel$(echo .)org \
--cc=keescook@chromium$(echo .)org \
--cc=kirill@shutemov$(echo .)name \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-ia64@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mips@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linux-sh@vger$(echo .)kernel.org \
--cc=linux-snps-arc@lists$(echo .)infradead.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mark.rutland@arm$(echo .)com \
--cc=mhocko@kernel$(echo .)org \
--cc=mingo@kernel$(echo .)org \
--cc=mpe@ellerman$(echo .)id.au \
--cc=paul.burton@mips$(echo .)com \
--cc=paulus@samba$(echo .)org \
--cc=penguin-kernel@i-love$(echo .)sakura.ne.jp \
--cc=peterz@infradead$(echo .)org \
--cc=ralf@linux-mips$(echo .)org \
--cc=rppt@linux$(echo .)vnet.ibm.com \
--cc=schowdary@nvidia$(echo .)com \
--cc=schwidefsky@de$(echo .)ibm.com \
--cc=sparclinux@vger$(echo .)kernel.org \
--cc=tglx@linutronix$(echo .)de \
--cc=vbabka@suse$(echo .)cz \
--cc=willy@infradead$(echo .)org \
--cc=x86@kernel$(echo .)org \
--cc=yamada.masahiro@socionext$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox