public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
From: Hanjie Lin <hanjie.lin@amlogic•com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail•com>
Cc: Rob Herring <robh@kernel•org>,
	Victor Wan <victor.wan@amlogic•com>,
	Jianxin Pan <jianxin.pan@amlogic•com>,
	Neil Armstrong <narmstrong@baylibre•com>,
	Stephen Boyd <sboyd@kernel•org>,
	Kevin Hilman <khilman@baylibre•com>,
	Michael Turquette <mturquette@baylibre•com>,
	linux-usb@vger•kernel.org, Yue Wang <yue.wang@amlogic•com>,
	Qiufang Dai <qiufang.dai@amlogic•com>,
	devicetree@vger•kernel.org, Liang Yang <liang.yang@amlogic•com>,
	Jian Hu <jian.hu@amlogic•com>,
	Xingyu Chen <xingyu.chen@amlogic•com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
	Carlo Caione <carlo@caione•org>,
	linux-amlogic@lists•infradead.org,
	linux-arm-kernel@lists•infradead.org,
	Jerome Brunet <jbrunet@baylibre•com>
Subject: Re: [PATCH v5 1/6] dt-bindings: phy: Add Amlogic A1 USB2 PHY Bindings
Date: Mon, 13 Jan 2020 09:13:52 +0800	[thread overview]
Message-ID: <da8f7d0b-7bf8-5a7a-53a6-be2bdc1ca4c4@amlogic.com> (raw)
In-Reply-To: <CAFBinCA-w6GnPzFCbmUFNrOY3PeW3=74+ToC9CvXoSAWoe+VLw@mail.gmail.com>



On 2020/1/12 4:54, Martin Blumenstingl wrote:
> Hi Hanjie,
> 
> On Fri, Jan 10, 2020 at 6:43 AM Hanjie Lin <hanjie.lin@amlogic•com> wrote:
>>
>> Add the Amlogic A1 Family USB2 PHY Bindings
>>
>> It supports Host mode only.
>>
>> Signed-off-by: Hanjie Lin <hanjie.lin@amlogic•com>
>> Signed-off-by: Yue Wang <yue.wang@amlogic•com>
>> ---
>>  .../bindings/phy/amlogic,meson-a1-usb2-phy.yaml    | 62 ++++++++++++++++++++++
>>  1 file changed, 62 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/phy/amlogic,meson-a1-usb2-phy.yaml
> there are only two differences to the existing
> amlogic,meson-g12a-usb2-phy.yaml binding:
> - different compatible string (the existing binding already has an
> enum, so that would be easy to extend)
> - new, mandatory power-domains property
> (Documentation/devicetree/bindings/sound/allwinner,sun4i-a10-codec.yaml
> has examples how to make properties mandatory based on the compatible
> string)
> 
> have you considered merging this with the existing
> amlogic,meson-g12a-usb2-phy.yaml binding?
> this is not a "must have" in my opinion, I still want to hear your
> opinion on this topic!
> 
> 
> Martin
> 
> .
> 


Hi Martin,

Thanks for your advice.

Of course, it should looks much better to have merging this into the existing
amlogic,meson-g12a-usb2-phy.yaml.
I will try to do it by following the examples.

thanks,
Hanjie

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-01-13  1:13 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-10  5:42 [PATCH v5 0/6] arm64: meson: Add support for USB on Amlogic A1 Hanjie Lin
2020-01-10  5:42 ` [PATCH v5 1/6] dt-bindings: phy: Add Amlogic A1 USB2 PHY Bindings Hanjie Lin
2020-01-11 20:54   ` Martin Blumenstingl
2020-01-13  1:13     ` Hanjie Lin [this message]
2020-01-10  5:42 ` [PATCH v5 2/6] dt-bindings: usb: dwc3: Add the Amlogic A1 Family DWC3 Glue Bindings Hanjie Lin
2020-01-11 20:50   ` Martin Blumenstingl
2020-01-13  1:23     ` Hanjie Lin
2020-01-14 20:10       ` Martin Blumenstingl
2020-01-10  5:42 ` [PATCH v5 3/6] phy: amlogic: Add Amlogic A1 USB2 PHY Driver Hanjie Lin
2020-01-11 20:36   ` Martin Blumenstingl
2020-01-15  8:01   ` Neil Armstrong
2020-01-10  5:42 ` [PATCH v5 4/6] usb: dwc3: Add Amlogic A1 DWC3 glue Hanjie Lin
2020-01-11 20:45   ` Martin Blumenstingl
2020-01-13  1:33     ` Hanjie Lin
2020-01-15  8:01     ` Neil Armstrong
2020-01-16  2:12       ` Hanjie Lin
2020-01-10  5:42 ` [PATCH v5 5/6] arm64: dts: meson: a1: Enable USB2 PHY Hanjie Lin
2020-01-10  5:42 ` [PATCH v5 6/6] arm64: dts: meson: a1: Enable DWC3 controller Hanjie Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=da8f7d0b-7bf8-5a7a-53a6-be2bdc1ca4c4@amlogic.com \
    --to=hanjie.lin@amlogic$(echo .)com \
    --cc=carlo@caione$(echo .)org \
    --cc=devicetree@vger$(echo .)kernel.org \
    --cc=gregkh@linuxfoundation$(echo .)org \
    --cc=jbrunet@baylibre$(echo .)com \
    --cc=jian.hu@amlogic$(echo .)com \
    --cc=jianxin.pan@amlogic$(echo .)com \
    --cc=khilman@baylibre$(echo .)com \
    --cc=liang.yang@amlogic$(echo .)com \
    --cc=linux-amlogic@lists$(echo .)infradead.org \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    --cc=linux-usb@vger$(echo .)kernel.org \
    --cc=martin.blumenstingl@googlemail$(echo .)com \
    --cc=mturquette@baylibre$(echo .)com \
    --cc=narmstrong@baylibre$(echo .)com \
    --cc=qiufang.dai@amlogic$(echo .)com \
    --cc=robh@kernel$(echo .)org \
    --cc=sboyd@kernel$(echo .)org \
    --cc=victor.wan@amlogic$(echo .)com \
    --cc=xingyu.chen@amlogic$(echo .)com \
    --cc=yue.wang@amlogic$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox