From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora•com>
To: Akari Tsuyukusa <akkun11.open@gmail•com>, matthias.bgg@gmail•com
Cc: james.lo@mediatek•com, linux-kernel@vger•kernel.org,
linux-arm-kernel@lists•infradead.org,
linux-mediatek@lists•infradead.org
Subject: Re: [PATCH] soc: mediatek: pwrap: Remove obsolete NEED CONFIRM comments
Date: Mon, 25 May 2026 10:46:01 +0200 [thread overview]
Message-ID: <dd1136db-1a78-4d32-a3ed-13691621c8ba@collabora.com> (raw)
In-Reply-To: <20260522134522.368073-1-akkun11.open@gmail.com>
On 5/22/26 15:45, Akari Tsuyukusa wrote:
> Remove the obsolete "/* NEED CONFIRM */" comments from the MT8196
s/mt8196/mt8195/g
> configuration. These values were previously confirmed during review,
> but the placeholder comments were accidentally left behind.
>
> Link: https://lore.kernel.org/all/2a117e5fe9fe0ece39e9165a463082ef42be973f.camel@mediatek.com/
> Signed-off-by: Akari Tsuyukusa <akkun11.open@gmail•com>
after which...
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora•com>
> ---
> drivers/soc/mediatek/mtk-pmic-wrap.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c
> index 0bcd85826375..87bcbfa2d5f1 100644
> --- a/drivers/soc/mediatek/mtk-pmic-wrap.c
> +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
> @@ -2396,8 +2396,8 @@ static const struct pmic_wrapper_type pwrap_mt8183 = {
> static const struct pmic_wrapper_type pwrap_mt8195 = {
> .regs = mt8195_regs,
> .type = PWRAP_MT8195,
> - .arb_en_all = 0x777f, /* NEED CONFIRM */
> - .int_en_all = 0x180000, /* NEED CONFIRM */
> + .arb_en_all = 0x777f,
> + .int_en_all = 0x180000,
> .int1_en_all = 0,
> .spi_w = PWRAP_MAN_CMD_SPI_WRITE,
> .wdt_src = PWRAP_WDT_SRC_MASK_ALL,
next prev parent reply other threads:[~2026-05-25 8:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-22 13:45 [PATCH] soc: mediatek: pwrap: Remove obsolete NEED CONFIRM comments Akari Tsuyukusa
2026-05-25 8:46 ` AngeloGioacchino Del Regno [this message]
2026-05-25 9:24 ` [PATCH v2] " Akari Tsuyukusa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd1136db-1a78-4d32-a3ed-13691621c8ba@collabora.com \
--to=angelogioacchino.delregno@collabora$(echo .)com \
--cc=akkun11.open@gmail$(echo .)com \
--cc=james.lo@mediatek$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mediatek@lists$(echo .)infradead.org \
--cc=matthias.bgg@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox