Subject: Re: [PATCH 01/15] irqchip: Allow to compile bcmstb on other platforms

From: Marc Zyngier <[email-masked]>
Date: Thu, 10 Dec 2020 17:59:09 +0000

Hi Maxime,

On 2020-12-10 13:46, Maxime Ripard wrote:
> The BCM2711 uses a number of instances of the bcmstb-l2 controller in 
> its
> display engine. Let's allow the driver to be enabled through KConfig.
> 
> Signed-off-by: Maxime Ripard <[email-masked]>
> ---
>  drivers/irqchip/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
> index c6098eee0c7c..f1e58de117dc 100644
> --- a/drivers/irqchip/Kconfig
> +++ b/drivers/irqchip/Kconfig
> @@ -131,7 +131,7 @@ config BCM7120_L2_IRQ
>  	select IRQ_DOMAIN
> 
>  config BRCMSTB_L2_IRQ
> -	bool
> +	bool "Broadcom STB L2 Interrupt Controller"
>  	select GENERIC_IRQ_CHIP
>  	select IRQ_DOMAIN

I'm always sceptical of making interrupt controllers user-selectable.
Who is going to know that they need to pick that one?

I'd be much more in favour of directly selecting this symbol
from DRM_VC4_HDMI_CEC, since there is an obvious dependency.

Thanks,

         M.
-- 
Jazz is not dead. It just smells funny...

_______________________________________________
linux-arm-kernel mailing list
[email-masked]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel