From: Andrey Ryabinin <aryabinin@virtuozzo•com>
To: Vlastimil Babka <vbabka@suse•cz>, Qian Cai <cai@lca•pw>,
Walter Wu <walter-zh.wu@mediatek•com>
Cc: wsd_upstream@mediatek•com, Arnd Bergmann <arnd@arndb•de>,
linux-mm@kvack•org, Andrey Konovalov <andreyknvl@google•com>,
linux-kernel@vger•kernel.org, kasan-dev@googlegroups•com,
Martin Schwidefsky <schwidefsky@de•ibm.com>,
Alexander Potapenko <glider@google•com>,
linux-arm-kernel@lists•infradead.org,
Matthias Brugger <matthias.bgg@gmail•com>,
linux-mediatek@lists•infradead.org,
Andrew Morton <akpm@linux-foundation•org>,
Dmitry Vyukov <dvyukov@google•com>
Subject: Re: [PATCH v3] mm/kasan: dump alloc and free stack for page allocator
Date: Thu, 12 Sep 2019 17:08:21 +0300 [thread overview]
Message-ID: <e4e23249-9f37-1d66-d411-7786b7aba36e@virtuozzo.com> (raw)
In-Reply-To: <c4d2518f-4813-c941-6f47-73897f420517@suse.cz>
On 9/12/19 4:53 PM, Vlastimil Babka wrote:
> On 9/11/19 5:19 PM, Qian Cai wrote:
>>
>> The new config looks redundant and confusing. It looks to me more of a document update
>> in Documentation/dev-tools/kasan.txt to educate developers to select PAGE_OWNER and
>> DEBUG_PAGEALLOC if needed.
>
> Agreed. But if you want it fully automatic, how about something
> like this (on top of mmotm/next)? If you agree I'll add changelog
> and send properly.
>
> ----8<----
>
> From a528d14c71d7fdf5872ca8ab3bd1b5bad26670c9 Mon Sep 17 00:00:00 2001
> From: Vlastimil Babka <vbabka@suse•cz>
> Date: Thu, 12 Sep 2019 15:51:23 +0200
> Subject: [PATCH] make KASAN enable page_owner with free stack capture
>
> ---
> include/linux/page_owner.h | 1 +
> lib/Kconfig.kasan | 4 ++++
> mm/Kconfig.debug | 5 +++++
> mm/page_alloc.c | 6 +++++-
> mm/page_owner.c | 37 ++++++++++++++++++++++++-------------
> 5 files changed, 39 insertions(+), 14 deletions(-)
>
Looks ok to me. This certainly better than full dependency on the DEBUG_PAGEALLOC which we don't need.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-09-12 14:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-11 8:39 [PATCH v3] mm/kasan: dump alloc and free stack for page allocator Walter Wu
2019-09-11 15:19 ` Qian Cai
2019-09-12 13:53 ` Vlastimil Babka
2019-09-12 14:08 ` Andrey Ryabinin [this message]
2019-09-12 14:08 ` Walter Wu
2019-09-12 14:31 ` Vlastimil Babka
2019-09-12 15:13 ` Walter Wu
2019-09-12 17:05 ` Andrey Ryabinin
2019-09-16 9:42 ` Vlastimil Babka
2019-09-16 15:57 ` Andrey Ryabinin
2019-09-17 8:19 ` Vlastimil Babka
2019-09-23 8:20 ` [PATCH] mm, debug, kasan: save and dump freeing stack trace for kasan Vlastimil Babka
2019-09-25 9:41 ` Andrey Ryabinin
2019-09-12 14:10 ` [PATCH v3] mm/kasan: dump alloc and free stack for page allocator Qian Cai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4e23249-9f37-1d66-d411-7786b7aba36e@virtuozzo.com \
--to=aryabinin@virtuozzo$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=andreyknvl@google$(echo .)com \
--cc=arnd@arndb$(echo .)de \
--cc=cai@lca$(echo .)pw \
--cc=dvyukov@google$(echo .)com \
--cc=glider@google$(echo .)com \
--cc=kasan-dev@googlegroups$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mediatek@lists$(echo .)infradead.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=matthias.bgg@gmail$(echo .)com \
--cc=schwidefsky@de$(echo .)ibm.com \
--cc=vbabka@suse$(echo .)cz \
--cc=walter-zh.wu@mediatek$(echo .)com \
--cc=wsd_upstream@mediatek$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox