Subject: Re: [PATCH 5/8] soc: ti: omap-prm: add omap4 PRM data

From: Suman Anna <[email-masked]>
Date: Tue, 20 Aug 2019 12:23:58 -0500

On 8/20/19 2:52 AM, Tero Kristo wrote:
> On 20.8.2019 2.08, Suman Anna wrote:
>> On 8/7/19 2:48 AM, Tero Kristo wrote:
>>> Add PRM data for omap4 family of SoCs.
>>>
>>> Signed-off-by: Tero Kristo <[email-masked]>
>>> ---
>>>   drivers/soc/ti/omap_prm.c | 20 ++++++++++++++++++++
>>>   1 file changed, 20 insertions(+)
>>>
>>> diff --git a/drivers/soc/ti/omap_prm.c b/drivers/soc/ti/omap_prm.c
>>> index 870515e3..9b8d5945 100644
>>> --- a/drivers/soc/ti/omap_prm.c
>>> +++ b/drivers/soc/ti/omap_prm.c
>>> @@ -54,7 +54,27 @@ struct omap_reset_data {
>>>     #define OMAP_PRM_NO_RSTST    BIT(0)
>>>   +struct omap_prm_data omap4_prm_data[] = {
>>
>> static const
> 
> Will fix this and rest of the similar comments.
> 
> -Tero
> 
>>
>> regards
>> Suman
>>
>>> +    { .name = "mpu", .base = 0x4a306300, .pwstst = 0x4 },
>>> +    { .name = "tesla", .base = 0x4a306400, .pwstst = 0x4, .rstctl =
>>> 0x10, .rstst = 0x14 },
>>> +    { .name = "abe", .base = 0x4a306500, .pwstst = 0x4 },
>>> +    { .name = "always_on_core", .base = 0x4a306600, .pwstst = 0x4 },
>>> +    { .name = "core", .base = 0x4a306700, .pwstst = 0x4, .rstctl =
>>> 0x210, .rstst = 0x214 },
>>> +    { .name = "ivahd", .base = 0x4a306f00, .pwstst = 0x4, .rstctl =
>>> 0x10, .rstst = 0x14 },
>>> +    { .name = "cam", .base = 0x4a307000, .pwstst = 0x4 },
>>> +    { .name = "dss", .base = 0x4a307100, .pwstst = 0x4 },
>>> +    { .name = "gfx", .base = 0x4a307200, .pwstst = 0x4 },
>>> +    { .name = "l3init", .base = 0x4a307300, .pwstst = 0x4 },
>>> +    { .name = "l4per", .base = 0x4a307400, .pwstst = 0x4 },
>>> +    { .name = "cefuse", .base = 0x4a307600, .pwstst = 0x4 },
>>> +    { .name = "wkup", .base = 0x4a307700, .pwstst = 0x4 },
>>> +    { .name = "emu", .base = 0x4a307900, .pwstst = 0x4 },
>>> +    { .name = "device", .base = 0x4a307b00, .rstctl = 0x0, .rstst =
>>> 0x4 },

So, looks like you are using pwstctrl as 0 by default, but some of them
will neither have pwstctrl or pwstst like "device" PRM here. Is the plan
to use -1 for the fields, or a flags field?

regards
Suman

>>> +    { },
>>> +};
>>> +
>>>   static const struct of_device_id omap_prm_id_table[] = {
>>> +    { .compatible = "ti,omap4-prm-inst", .data = omap4_prm_data },
>>>       { },
>>>   };
>>>  
>>
> 
> -- 
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

_______________________________________________
linux-arm-kernel mailing list
[email-masked]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel