From: robin <robin@protonic•nl>
To: Marco Felsch <m.felsch@pengutronix•de>
Cc: Mark Rutland <mark.rutland@arm•com>,
"devicetree @ vger . kernel . org" <devicetree@vger•kernel.org>,
Fabio Estevam <festevam@gmail•com>,
Adam Ford <aford173@gmail•com>,
Sascha Hauer <s.hauer@pengutronix•de>,
Dmitry Torokhov <dmitry.torokhov@gmail•com>,
"linux-kernel @ vger . kernel . org"
<linux-kernel@vger•kernel.org>, Rob Herring <robh+dt@kernel•org>,
dl-linux-imx <linux-imx@nxp•com>,
Pengutronix Kernel Team <kernel@pengutronix•de>,
"linux-input @ vger . kernel . org" <linux-input@vger•kernel.org>,
Robin Gong <yibin.gong@nxp•com>, Shawn Guo <shawnguo@kernel•org>,
"linux-arm-kernel @ lists . infradead . org"
<linux-arm-kernel@lists•infradead.org>
Subject: Re: [PATCH v2 1/2] input: keyboard: snvs_pwrkey: Send key events for i.MX6 S, DL and Q
Date: Thu, 29 Aug 2019 16:32:22 +0200 [thread overview]
Message-ID: <efbaeee1422412098076488fa494a42f@protonic.nl> (raw)
In-Reply-To: <20190829115052.s2m4jw4p3rknqoxb@pengutronix.de>
On 2019-08-29 13:50, Marco Felsch wrote:
> On 19-08-29 09:11, Robin Gong wrote:
>>
>> On 2019-08-29 16:17, Marco Felsch wrote:
>> > > > While reading the rm it seems that
>> > > > the snvs block has a dedicated version register. IMHO this could be
>> > > > a better way to apply the change also to existing devices with old
>> > > > firmware.
>> > >
>> > > I thought the same thing, and fully agree with you. However I do not
>> > > have a way to determine which versions are out there. Since I couldn't
>> > > find any documentation on this, and I only have i.MX6 S/DL, D/Q and UL
>> > laying around.
>> >
>> > @NXP Kernel Team
>> > Can we get some more information here?
>> Go ahead, please. That snvs version register SNVS_HPVIDR1 should work
>> as expect.
>> MINOR_REV checking is enough, none-zero means for soc after i.mx6sx,
>> but
>> Zero means i.mx6q/dl/sl elder soc.
>
> Thanks. Robin can you integrate that so we can drop the different
> dt-handling?
No problem, I'll post an updated patch tomorrow.
>
> Regards,
> Marco
>
>> >
>> > Regards,
>> > Marco
>> >
>> > > Regards,
>> > > Robin van der Gracht
>> > >
>> >
>> > --
>> > Pengutronix e.K. |
>> > |
>> > Industrial Linux Solutions |
>> > https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.p
>> > engutronix.de%2F&data=02%7C01%7Cyibin.gong%40nxp.com%7C8d4e1
>> > 0cd77bd4652f3eb08d72c594e76%7C686ea1d3bc2b4c6fa92cd99c5c301635%7
>> > C0%7C0%7C637026634390359345&sdata=mhXlUxmLWg8qtwhPQfkJZm
>> > VAn4QQ3YybLOSh83uf27E%3D&reserved=0 |
>> > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0
>> > |
>> > Amtsgericht Hildesheim, HRA 2686 | Fax:
>> > +49-5121-206917-5555 |
>>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-08-29 14:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-27 12:32 [PATCH v2 1/2] input: keyboard: snvs_pwrkey: Send key events for i.MX6 S, DL and Q Robin van der Gracht
2019-08-27 12:32 ` [PATCH v2 2/2] arm: dts: imx6qdl: snvs-pwrkey: Change compatible string Robin van der Gracht
2019-08-28 9:15 ` [PATCH v2 1/2] input: keyboard: snvs_pwrkey: Send key events for i.MX6 S, DL and Q Marco Felsch
2019-08-29 7:24 ` robin
2019-08-29 8:17 ` Marco Felsch
2019-08-29 9:11 ` Robin Gong
2019-08-29 11:50 ` Marco Felsch
2019-08-29 14:32 ` robin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=efbaeee1422412098076488fa494a42f@protonic.nl \
--to=robin@protonic$(echo .)nl \
--cc=aford173@gmail$(echo .)com \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=dmitry.torokhov@gmail$(echo .)com \
--cc=festevam@gmail$(echo .)com \
--cc=kernel@pengutronix$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-imx@nxp$(echo .)com \
--cc=linux-input@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=m.felsch@pengutronix$(echo .)de \
--cc=mark.rutland@arm$(echo .)com \
--cc=robh+dt@kernel$(echo .)org \
--cc=s.hauer@pengutronix$(echo .)de \
--cc=shawnguo@kernel$(echo .)org \
--cc=yibin.gong@nxp$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox