From: Xiaoyao Li <xiaoyao.li@intel•com>
To: Sean Christopherson <seanjc@google•com>,
Paolo Bonzini <pbonzini@redhat•com>,
Marc Zyngier <maz@kernel•org>,
Oliver Upton <oliver.upton@linux•dev>
Cc: kvm@vger•kernel.org, linux-arm-kernel@lists•infradead.org,
kvmarm@lists•linux.dev, linux-kernel@vger•kernel.org,
Ira Weiny <ira.weiny@intel•com>, Gavin Shan <gshan@redhat•com>,
Shivank Garg <shivankg@amd•com>, Vlastimil Babka <vbabka@suse•cz>,
David Hildenbrand <david@redhat•com>,
Fuad Tabba <tabba@google•com>,
Ackerley Tng <ackerleytng@google•com>,
Tao Chan <chentao@kylinos•cn>,
James Houghton <jthoughton@google•com>
Subject: Re: [PATCH v17 22/24] KVM: selftests: Do not use hardcoded page sizes in guest_memfd test
Date: Wed, 30 Jul 2025 19:04:29 +0800 [thread overview]
Message-ID: <f0378019-01d7-48df-bebf-d2a59e9d8582@intel.com> (raw)
In-Reply-To: <20250729225455.670324-23-seanjc@google.com>
On 7/30/2025 6:54 AM, Sean Christopherson wrote:
> From: Fuad Tabba <tabba@google•com>
>
> Update the guest_memfd_test selftest to use getpagesize() instead of
> hardcoded 4KB page size values.
>
> Using hardcoded page sizes can cause test failures on architectures or
> systems configured with larger page sizes, such as arm64 with 64KB
> pages. By dynamically querying the system's page size, the test becomes
> more portable and robust across different environments.
>
> Additionally, build the guest_memfd_test selftest for arm64.
>
> Reviewed-by: David Hildenbrand <david@redhat•com>
> Reviewed-by: Shivank Garg <shivankg@amd•com>
> Reviewed-by: Gavin Shan <gshan@redhat•com>
> Suggested-by: Gavin Shan <gshan@redhat•com>
> Signed-off-by: Fuad Tabba <tabba@google•com>
> Signed-off-by: Sean Christopherson <seanjc@google•com>
Reviewed-by: Xiaoyao Li <xiaoyao.li@intel•com>
> ---
> tools/testing/selftests/kvm/Makefile.kvm | 1 +
> tools/testing/selftests/kvm/guest_memfd_test.c | 11 ++++++-----
> 2 files changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/tools/testing/selftests/kvm/Makefile.kvm b/tools/testing/selftests/kvm/Makefile.kvm
> index 40920445bfbe..963687892bcb 100644
> --- a/tools/testing/selftests/kvm/Makefile.kvm
> +++ b/tools/testing/selftests/kvm/Makefile.kvm
> @@ -174,6 +174,7 @@ TEST_GEN_PROGS_arm64 += arch_timer
> TEST_GEN_PROGS_arm64 += coalesced_io_test
> TEST_GEN_PROGS_arm64 += dirty_log_perf_test
> TEST_GEN_PROGS_arm64 += get-reg-list
> +TEST_GEN_PROGS_arm64 += guest_memfd_test
> TEST_GEN_PROGS_arm64 += memslot_modification_stress_test
> TEST_GEN_PROGS_arm64 += memslot_perf_test
> TEST_GEN_PROGS_arm64 += mmu_stress_test
> diff --git a/tools/testing/selftests/kvm/guest_memfd_test.c b/tools/testing/selftests/kvm/guest_memfd_test.c
> index ce687f8d248f..341ba616cf55 100644
> --- a/tools/testing/selftests/kvm/guest_memfd_test.c
> +++ b/tools/testing/selftests/kvm/guest_memfd_test.c
> @@ -146,24 +146,25 @@ static void test_create_guest_memfd_multiple(struct kvm_vm *vm)
> {
> int fd1, fd2, ret;
> struct stat st1, st2;
> + size_t page_size = getpagesize();
>
> - fd1 = __vm_create_guest_memfd(vm, 4096, 0);
> + fd1 = __vm_create_guest_memfd(vm, page_size, 0);
> TEST_ASSERT(fd1 != -1, "memfd creation should succeed");
>
> ret = fstat(fd1, &st1);
> TEST_ASSERT(ret != -1, "memfd fstat should succeed");
> - TEST_ASSERT(st1.st_size == 4096, "memfd st_size should match requested size");
> + TEST_ASSERT(st1.st_size == page_size, "memfd st_size should match requested size");
>
> - fd2 = __vm_create_guest_memfd(vm, 8192, 0);
> + fd2 = __vm_create_guest_memfd(vm, page_size * 2, 0);
> TEST_ASSERT(fd2 != -1, "memfd creation should succeed");
>
> ret = fstat(fd2, &st2);
> TEST_ASSERT(ret != -1, "memfd fstat should succeed");
> - TEST_ASSERT(st2.st_size == 8192, "second memfd st_size should match requested size");
> + TEST_ASSERT(st2.st_size == page_size * 2, "second memfd st_size should match requested size");
>
> ret = fstat(fd1, &st1);
> TEST_ASSERT(ret != -1, "memfd fstat should succeed");
> - TEST_ASSERT(st1.st_size == 4096, "first memfd st_size should still match requested size");
> + TEST_ASSERT(st1.st_size == page_size, "first memfd st_size should still match requested size");
> TEST_ASSERT(st1.st_ino != st2.st_ino, "different memfd should have different inode numbers");
>
> close(fd2);
next prev parent reply other threads:[~2025-07-30 12:16 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-29 22:54 [PATCH v17 00/24] KVM: Enable mmap() for guest_memfd Sean Christopherson
2025-07-29 22:54 ` [PATCH v17 01/24] KVM: Rename CONFIG_KVM_PRIVATE_MEM to CONFIG_KVM_GUEST_MEMFD Sean Christopherson
2025-07-29 22:54 ` [PATCH v17 02/24] KVM: x86: Have all vendor neutral sub-configs depend on KVM_X86, not just KVM Sean Christopherson
2025-07-31 8:08 ` Fuad Tabba
2025-07-29 22:54 ` [PATCH v17 03/24] KVM: x86: Select KVM_GENERIC_PRIVATE_MEM directly from KVM_SW_PROTECTED_VM Sean Christopherson
2025-07-31 8:08 ` Fuad Tabba
2025-07-29 22:54 ` [PATCH v17 04/24] KVM: x86: Select TDX's KVM_GENERIC_xxx dependencies iff CONFIG_KVM_INTEL_TDX=y Sean Christopherson
2025-07-31 8:07 ` Fuad Tabba
2025-07-29 22:54 ` [PATCH v17 05/24] KVM: Rename CONFIG_KVM_GENERIC_PRIVATE_MEM to CONFIG_HAVE_KVM_ARCH_GMEM_POPULATE Sean Christopherson
2025-07-29 22:54 ` [PATCH v17 06/24] KVM: Rename kvm_slot_can_be_private() to kvm_slot_has_gmem() Sean Christopherson
2025-07-29 22:54 ` [PATCH v17 07/24] KVM: Fix comments that refer to slots_lock Sean Christopherson
2025-07-29 22:54 ` [PATCH v17 08/24] KVM: Fix comment that refers to kvm uapi header path Sean Christopherson
2025-07-29 22:54 ` [PATCH v17 09/24] KVM: x86: Enable KVM_GUEST_MEMFD for all 64-bit builds Sean Christopherson
2025-07-29 22:54 ` [PATCH v17 10/24] KVM: guest_memfd: Add plumbing to host to map guest_memfd pages Sean Christopherson
2025-07-29 22:54 ` [PATCH v17 11/24] KVM: guest_memfd: Track guest_memfd mmap support in memslot Sean Christopherson
2025-07-29 22:54 ` [PATCH v17 12/24] KVM: x86/mmu: Rename .private_max_mapping_level() to .gmem_max_mapping_level() Sean Christopherson
2025-07-31 8:15 ` Fuad Tabba
2025-07-31 8:29 ` David Hildenbrand
2025-07-31 8:33 ` Fuad Tabba
2025-07-29 22:54 ` [PATCH v17 13/24] KVM: x86/mmu: Hoist guest_memfd max level/order helpers "up" in mmu.c Sean Christopherson
2025-07-31 7:59 ` David Hildenbrand
2025-07-31 8:06 ` Fuad Tabba
2025-07-29 22:54 ` [PATCH v17 14/24] KVM: x86/mmu: Enforce guest_memfd's max order when recovering hugepages Sean Christopherson
2025-07-30 7:33 ` Xiaoyao Li
2025-07-31 8:06 ` David Hildenbrand
2025-07-31 8:10 ` Fuad Tabba
2025-07-29 22:54 ` [PATCH v17 15/24] KVM: x86/mmu: Extend guest_memfd's max mapping level to shared mappings Sean Christopherson
2025-07-30 7:36 ` Xiaoyao Li
2025-07-31 8:01 ` David Hildenbrand
2025-07-31 8:05 ` Fuad Tabba
2025-07-29 22:54 ` [PATCH v17 16/24] KVM: x86/mmu: Handle guest page faults for guest_memfd with shared memory Sean Christopherson
2025-07-30 7:37 ` Xiaoyao Li
2025-07-29 22:54 ` [PATCH v17 17/24] KVM: arm64: Refactor user_mem_abort() Sean Christopherson
2025-07-29 22:54 ` [PATCH v17 18/24] KVM: arm64: Handle guest_memfd-backed guest page faults Sean Christopherson
2025-07-29 22:54 ` [PATCH v17 19/24] KVM: arm64: nv: Handle VNCR_EL2-triggered faults backed by guest_memfd Sean Christopherson
2025-07-29 22:54 ` [PATCH v17 20/24] KVM: arm64: Enable support for guest_memfd backed memory Sean Christopherson
2025-07-29 22:54 ` [PATCH v17 21/24] KVM: Allow and advertise support for host mmap() on guest_memfd files Sean Christopherson
2025-07-29 22:54 ` [PATCH v17 22/24] KVM: selftests: Do not use hardcoded page sizes in guest_memfd test Sean Christopherson
2025-07-30 11:04 ` Xiaoyao Li [this message]
2025-07-29 22:54 ` [PATCH v17 23/24] KVM: selftests: guest_memfd mmap() test when mmap is supported Sean Christopherson
2025-07-30 11:39 ` Xiaoyao Li
2025-07-30 12:57 ` Sean Christopherson
2025-07-31 7:49 ` Xiaoyao Li
2025-08-07 8:12 ` Shivank Garg
2025-07-29 22:54 ` [PATCH v17 24/24] KVM: selftests: Add guest_memfd testcase to fault-in on !mmap()'d memory Sean Christopherson
2025-07-30 8:20 ` Xiaoyao Li
2025-07-30 15:51 ` Fuad Tabba
2026-03-30 6:21 ` Zenghui Yu
2026-04-17 16:47 ` Sean Christopherson
2026-05-12 7:28 ` Zenghui Yu
2026-05-12 15:53 ` Sean Christopherson
2025-07-30 21:34 ` [PATCH v17 00/24] KVM: Enable mmap() for guest_memfd Ackerley Tng
2025-07-30 22:44 ` Ackerley Tng
2025-08-27 8:43 ` Paolo Bonzini
2025-08-27 12:57 ` Sean Christopherson
2025-08-27 13:08 ` Marc Zyngier
2025-08-27 13:11 ` Paolo Bonzini
2025-08-27 13:14 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0378019-01d7-48df-bebf-d2a59e9d8582@intel.com \
--to=xiaoyao.li@intel$(echo .)com \
--cc=ackerleytng@google$(echo .)com \
--cc=chentao@kylinos$(echo .)cn \
--cc=david@redhat$(echo .)com \
--cc=gshan@redhat$(echo .)com \
--cc=ira.weiny@intel$(echo .)com \
--cc=jthoughton@google$(echo .)com \
--cc=kvm@vger$(echo .)kernel.org \
--cc=kvmarm@lists$(echo .)linux.dev \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=maz@kernel$(echo .)org \
--cc=oliver.upton@linux$(echo .)dev \
--cc=pbonzini@redhat$(echo .)com \
--cc=seanjc@google$(echo .)com \
--cc=shivankg@amd$(echo .)com \
--cc=tabba@google$(echo .)com \
--cc=vbabka@suse$(echo .)cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox