From: Florian Fainelli <f.fainelli@gmail•com>
To: Christoph Hellwig <hch@lst•de>,
Nicolas Saenz Julienne <nsaenzjulienne@suse•de>
Cc: mbrugger@suse•com, Scott Branden <sbranden@broadcom•com>,
Ray Jui <rjui@broadcom•com>, Russell King <linux@armlinux•org.uk>,
linux-kernel@vger•kernel.org, Eric Anholt <eric@anholt•net>,
bcm-kernel-feedback-list@broadcom•com,
Stefan Wahren <wahrenst@gmx•net>,
linux-arm-kernel@lists•infradead.org,
linux-rpi-kernel@lists•infradead.org
Subject: Re: [RFC] ARM: bcm2835: register dmabounce on devices hooked to main interconnect
Date: Sat, 27 Jul 2019 10:36:46 +0200 [thread overview]
Message-ID: <f15ef16e-8e5c-4e9b-1cb2-c6602b15a4ec@gmail.com> (raw)
In-Reply-To: <20190723163433.GA2234@lst.de>
On 7/23/2019 6:34 PM, Christoph Hellwig wrote:
>> +static int bcm2835_needs_bounce(struct device *dev, dma_addr_t dma_addr, size_t size)
>
> Too long line..
>
>> +void __init bcm2835_init_early(void)
>> +{
>> + if(of_machine_is_compatible("brcm,bcm2711"))
>
> Odd formatting.
>
> Otherwise this looks good to me.
Is this really the right way to solve this problem? First this is ARM
32-bit specific, and second, should not we have a way to indicate via
device tree that all peripherals behind the "soc" simple-bus parent node
are limited to 32-bit of DMA masks, but the specific memory map of the
BCM283x/BCM2711 makes it that only the last 1GB (0xC000_0000 -
0xffff_ffff) (which dma-ranges conveys already) is suitable for DMA into
the VPU uncached alias?
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-07-27 8:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-23 16:19 [RFC] ARM: bcm2835: register dmabounce on devices hooked to main interconnect Nicolas Saenz Julienne
2019-07-23 16:34 ` Christoph Hellwig
2019-07-27 8:36 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f15ef16e-8e5c-4e9b-1cb2-c6602b15a4ec@gmail.com \
--to=f.fainelli@gmail$(echo .)com \
--cc=bcm-kernel-feedback-list@broadcom$(echo .)com \
--cc=eric@anholt$(echo .)net \
--cc=hch@lst$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-rpi-kernel@lists$(echo .)infradead.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=mbrugger@suse$(echo .)com \
--cc=nsaenzjulienne@suse$(echo .)de \
--cc=rjui@broadcom$(echo .)com \
--cc=sbranden@broadcom$(echo .)com \
--cc=wahrenst@gmx$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox