From: <Claudiu.Beznea@microchip•com>
To: <alexandre.belloni@bootlin•com>
Cc: sboyd@kernel•org, mturquette@baylibre•com,
linux-kernel@vger•kernel.org, linux-clk@vger•kernel.org,
linux-arm-kernel@lists•infradead.org
Subject: Re: [PATCH] clk: at91: add compatible for sam9x60
Date: Wed, 9 Oct 2019 12:17:10 +0000 [thread overview]
Message-ID: <f8fabb4e-81be-6219-ec5c-8d236a8959e7@microchip.com> (raw)
In-Reply-To: <20191008165449.GA4254@piout.net>
Hi,
On 08.10.2019 19:54, Alexandre Belloni wrote:
> Hi,
>
> On 08/10/2019 19:46:26+0300, Claudiu Beznea wrote:
>> Add compatible for SAM9X60's PMC.
>
> I think the commit log could be clearer and mention why this is needed
> and the compatible string in sam9x60 is not sufficient.
I had issues with waking up from ULP1 without even having configuring
wakeup sources.
But, investigating more I discovered that this patch breaks other things
so please ignore it.
Sorry for the noise,
Claudiu Beznea
>
>>
>> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip•com>
>> ---
>> drivers/clk/at91/pmc.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/clk/at91/pmc.c b/drivers/clk/at91/pmc.c
>> index db24539d5740..24975bca608e 100644
>> --- a/drivers/clk/at91/pmc.c
>> +++ b/drivers/clk/at91/pmc.c
>> @@ -271,6 +271,7 @@ static struct syscore_ops pmc_syscore_ops = {
>>
>> static const struct of_device_id sama5d2_pmc_dt_ids[] = {
>
> Maybe rename the array?
>
>> { .compatible = "atmel,sama5d2-pmc" },
>> + { .compatible = "microchip,sam9x60-pmc" },
>> { /* sentinel */ }
>> };
>>
>> --
>> 2.7.4
>>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-10-09 12:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-08 16:46 [PATCH] clk: at91: add compatible for sam9x60 Claudiu Beznea
2019-10-08 16:54 ` Alexandre Belloni
2019-10-09 12:17 ` Claudiu.Beznea [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8fabb4e-81be-6219-ec5c-8d236a8959e7@microchip.com \
--to=claudiu.beznea@microchip$(echo .)com \
--cc=alexandre.belloni@bootlin$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-clk@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=mturquette@baylibre$(echo .)com \
--cc=sboyd@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox