From: Amelie DELAUNAY <amelie.delaunay@st•com>
To: Ben Dooks <ben.dooks@codethink•co.uk>,
<linux-kernel@lists•codethink.co.uk>
Cc: linux-arm-kernel@lists•infradead.org,
linux-stm32@st-md-mailman•stormreply.com,
linux-kernel@vger•kernel.org,
Maxime Coquelin <mcoquelin.stm32@gmail•com>,
Kishon Vijay Abraham I <kishon@ti•com>
Subject: Re: [Linux-stm32] [PATCH] phy: stm32: fix use of integer as pointer
Date: Tue, 15 Oct 2019 16:59:32 +0200 [thread overview]
Message-ID: <fc837347-c2da-5550-0027-99bd3328e83f@st.com> (raw)
In-Reply-To: <20191015135148.28508-1-ben.dooks@codethink.co.uk>
On 10/15/19 3:51 PM, Ben Dooks wrote:
> The calls devm_clk_get() and devm_reset_control_get()
> take pointers so change the 0 to NULl to fix the
> following sparse warnings:
>
> drivers/phy/st/phy-stm32-usbphyc.c:330:42: warning: Using plain integer as NULL pointer
> drivers/phy/st/phy-stm32-usbphyc.c:343:52: warning: Using plain integer as NULL pointer
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink•co.uk>
Reviewed-by: Amelie Delaunay <amelie.delaunay@st•com>
> ---
> Cc: Kishon Vijay Abraham I <kishon@ti•com>
> Cc: Maxime Coquelin <mcoquelin.stm32@gmail•com>
> Cc: Alexandre Torgue <alexandre.torgue@st•com>
> Cc: linux-kernel@vger•kernel.org
> Cc: linux-stm32@st-md-mailman•stormreply.com
> Cc: linux-arm-kernel@lists•infradead.org
> ---
> drivers/phy/st/phy-stm32-usbphyc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/phy/st/phy-stm32-usbphyc.c b/drivers/phy/st/phy-stm32-usbphyc.c
> index 56bdea4b0bd9..2b3639cba51a 100644
> --- a/drivers/phy/st/phy-stm32-usbphyc.c
> +++ b/drivers/phy/st/phy-stm32-usbphyc.c
> @@ -327,7 +327,7 @@ static int stm32_usbphyc_probe(struct platform_device *pdev)
> if (IS_ERR(usbphyc->base))
> return PTR_ERR(usbphyc->base);
>
> - usbphyc->clk = devm_clk_get(dev, 0);
> + usbphyc->clk = devm_clk_get(dev, NULL);
> if (IS_ERR(usbphyc->clk)) {
> ret = PTR_ERR(usbphyc->clk);
> dev_err(dev, "clk get failed: %d\n", ret);
> @@ -340,7 +340,7 @@ static int stm32_usbphyc_probe(struct platform_device *pdev)
> return ret;
> }
>
> - usbphyc->rst = devm_reset_control_get(dev, 0);
> + usbphyc->rst = devm_reset_control_get(dev, NULL);
> if (!IS_ERR(usbphyc->rst)) {
> reset_control_assert(usbphyc->rst);
> udelay(2);
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-10-15 14:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-15 13:51 [PATCH] phy: stm32: fix use of integer as pointer Ben Dooks
2019-10-15 14:59 ` Amelie DELAUNAY [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc837347-c2da-5550-0027-99bd3328e83f@st.com \
--to=amelie.delaunay@st$(echo .)com \
--cc=ben.dooks@codethink$(echo .)co.uk \
--cc=kishon@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@lists$(echo .)codethink.co.uk \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-stm32@st-md-mailman$(echo .)stormreply.com \
--cc=mcoquelin.stm32@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox