From: Florian Fainelli <f.fainelli@gmail•com>
To: Stefan Wahren <wahrenst@gmx•net>, Mark Brown <broonie@kernel•org>
Cc: Mark Rutland <mark.rutland@arm•com>,
Ulf Hansson <ulf.hansson@linaro•org>,
Florian Fainelli <f.fainelli@gmail•com>,
Scott Branden <sbranden@broadcom•com>,
Stephen Boyd <sboyd@kernel•org>, Ray Jui <rjui@broadcom•com>,
Linus Walleij <linus.walleij@linaro•org>,
Adrian Hunter <adrian.hunter@intel•com>,
Eric Anholt <eric@anholt•net>, Rob Herring <robh+dt@kernel•org>,
bcm-kernel-feedback-list@broadcom•com,
linux-arm-kernel@lists•infradead.org,
Martin Sperl <kernel@martin•sperl.org>,
Michael Turquette <mturquette@baylibre•com>,
Nicolas Saenz Julienne <nsaenzjulienne@suse•de>,
linux-rpi-kernel@lists•infradead.org
Subject: Re: [PATCH RFC 15/18] spi: bcm2835: enable shared interrupt support
Date: Thu, 18 Jul 2019 11:05:13 -0700 [thread overview]
Message-ID: <fdbdbc92-e6fc-4e88-ea8f-bb0bc3224b90@gmail.com> (raw)
In-Reply-To: <b23c7a5a-a432-5af6-a7dc-0a7dfbe57712@gmx.net>
On 7/18/19 10:53 AM, Stefan Wahren wrote:
> Hi Mark,
>
> Am 18.07.19 um 14:42 schrieb Mark Brown:
>> On Wed, Jul 17, 2019 at 11:16:01PM +0200, Stefan Wahren wrote:
>>
>>> + /* check if we got interrupt enabled */
>>> + if (!(bcm2835_rd(bs, BCM2835_SPI_CS) & BCM2835_SPI_CS_INTR))
>>> + return IRQ_NONE;
>>> +
>> Is that checking if the interrupt is enabled or if it is asserted?
>
> the BCM2835 doesn't provide a SPI register, which shows that the
> interrupt has been asserted.
>
> So i think, Martin tried to adapt the workaround from spi-bcm2835-aux
> which has the same problem.
I was about to submit a change to address that since we also have that
shared interrupt on BCM7211:
https://github.com/ffainelli/linux/commit/15d96d82bd42991dc71369128131312d5338f65c
Martin's patch is more efficient in terms of amount of register
accesses, but I am bit worried (based on the register description) that
the INTR bit is only asserted with the read FIFO crossing a certain
condition and that a TX only transfer may not be captured by that condition.
Maybe we can just check spi_controller::idling to determine if that
specific instance generated an interrupt?
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-07-18 18:05 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-17 21:16 [PATCH RFC 14/18] HACK: pinctrl: bcm2835: Implement legacy pull for BCM7211 Stefan Wahren
2019-07-17 21:16 ` [PATCH RFC 15/18] spi: bcm2835: enable shared interrupt support Stefan Wahren
2019-07-18 12:42 ` Mark Brown
2019-07-18 17:53 ` Stefan Wahren
2019-07-18 18:05 ` Florian Fainelli [this message]
2019-07-18 18:21 ` Stefan Wahren
2019-07-24 17:15 ` Mark Brown
2019-07-18 18:52 ` Mark Brown
2019-07-17 21:16 ` [PATCH RFC 16/18] dt-bindings: bcm: Add Raspberry Pi 4 B Stefan Wahren
2019-07-17 21:16 ` [PATCH RFC 17/18] ARM: bcm2835: Add bcm2838 compatible string Stefan Wahren
2019-07-17 21:16 ` [PATCH RFC 18/18] ARM: dts: Add minimal Raspberry Pi 4 support Stefan Wahren
2019-07-17 21:22 ` Florian Fainelli
2019-07-17 21:32 ` Stefan Wahren
2019-07-23 18:13 ` Marc Zyngier
2019-07-24 9:51 ` Vladimir Murzin
2019-07-24 10:41 ` Marc Zyngier
2019-07-24 12:36 ` Vladimir Murzin
2019-07-24 19:04 ` Stefan Wahren
2019-07-28 10:58 ` Stefan Wahren
2019-07-28 11:38 ` Marc Zyngier
2019-07-30 18:33 ` Stefan Wahren
2019-07-31 10:55 ` Marc Zyngier
2019-08-02 22:12 ` [PATCH RFC 14/18] HACK: pinctrl: bcm2835: Implement legacy pull for BCM7211 Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fdbdbc92-e6fc-4e88-ea8f-bb0bc3224b90@gmail.com \
--to=f.fainelli@gmail$(echo .)com \
--cc=adrian.hunter@intel$(echo .)com \
--cc=bcm-kernel-feedback-list@broadcom$(echo .)com \
--cc=broonie@kernel$(echo .)org \
--cc=eric@anholt$(echo .)net \
--cc=kernel@martin$(echo .)sperl.org \
--cc=linus.walleij@linaro$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-rpi-kernel@lists$(echo .)infradead.org \
--cc=mark.rutland@arm$(echo .)com \
--cc=mturquette@baylibre$(echo .)com \
--cc=nsaenzjulienne@suse$(echo .)de \
--cc=rjui@broadcom$(echo .)com \
--cc=robh+dt@kernel$(echo .)org \
--cc=sboyd@kernel$(echo .)org \
--cc=sbranden@broadcom$(echo .)com \
--cc=ulf.hansson@linaro$(echo .)org \
--cc=wahrenst@gmx$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox