From: Cristian Marussi <cristian.marussi@arm•com>
To: Andrey Konovalov <andreyknvl@google•com>, Will Deacon <will@kernel•org>
Cc: Mark Rutland <mark.rutland@arm•com>,
Catalin Marinas <catalin.marinas@arm•com>,
Will Deacon <will.deacon@arm•com>,
LKML <linux-kernel@vger•kernel.org>,
Kostya Serebryany <kcc@google•com>,
Dmitry Vyukov <dvyukov@google•com>,
Evgeniy Stepanov <eugenis@google•com>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger•kernel.org>,
Amit Kachhap <Amit.Kachhap@arm•com>,
Vincenzo Frascino <vincenzo.frascino@arm•com>,
Linux ARM <linux-arm-kernel@lists•infradead.org>
Subject: Re: [PATCH ARM64] selftests, arm64: add kernel headers path for tags_test
Date: Fri, 6 Sep 2019 15:21:49 +0100 [thread overview]
Message-ID: <febb420d-003a-0288-8636-7fd7878ef63b@arm.com> (raw)
In-Reply-To: <CAAeHK+zDZo6oaSDnJfiD_S1WYqAT13yEFP7hbehZ62C-BBp3rQ@mail.gmail.com>
On 06/09/2019 14:55, Andrey Konovalov wrote:
> On Fri, Sep 6, 2019 at 3:51 PM Will Deacon <will@kernel•org> wrote:
>>
>> On Wed, Sep 04, 2019 at 06:41:00PM +0200, Andrey Konovalov wrote:
>>> tags_test.c relies on PR_SET_TAGGED_ADDR_CTRL/PR_TAGGED_ADDR_ENABLE being
>>> present in system headers. When this is not the case the build of this
>>> test fails with undeclared identifier errors.
>>>
>>> Fix by providing the path to the KSFT installed kernel headers in CFLAGS.
>>>
>>> Reported-by: Cristian Marussi <cristian.marussi@arm•com>
>>> Suggested-by: Cristian Marussi <cristian.marussi@arm•com>
>>> Signed-off-by: Andrey Konovalov <andreyknvl@google•com>
>>> ---
>>> tools/testing/selftests/arm64/Makefile | 1 +
>>> 1 file changed, 1 insertion(+)
>>
>> Damn, I just tagged the arm64 queue for 5.4 and didn't spot this patch.
>>
>> I'll queue it at -rc1 instead, if that's ok? It doesn't look urgent.
>
> Sorry, I guess I should have pinged you directly.
>
> I think it should be fine to leave it for rc1. It might cause a build
> error in some kernel CI systems if they run kselftests though.
>
It won't be a big issue probably.
Cristian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-09-06 14:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-04 16:41 [PATCH ARM64] selftests, arm64: add kernel headers path for tags_test Andrey Konovalov
2019-09-06 13:51 ` Will Deacon
2019-09-06 13:55 ` Andrey Konovalov
2019-09-06 14:21 ` Cristian Marussi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=febb420d-003a-0288-8636-7fd7878ef63b@arm.com \
--to=cristian.marussi@arm$(echo .)com \
--cc=Amit.Kachhap@arm$(echo .)com \
--cc=andreyknvl@google$(echo .)com \
--cc=catalin.marinas@arm$(echo .)com \
--cc=dvyukov@google$(echo .)com \
--cc=eugenis@google$(echo .)com \
--cc=kcc@google$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-kselftest@vger$(echo .)kernel.org \
--cc=mark.rutland@arm$(echo .)com \
--cc=vincenzo.frascino@arm$(echo .)com \
--cc=will.deacon@arm$(echo .)com \
--cc=will@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox