From: Michal Simek <michal.simek@amd•com>
To: William Theesfeld <william@theesfeld•net>,
Michael Turquette <mturquette@baylibre•com>
Cc: Stephen Boyd <sboyd@kernel•org>,
Brian Masney <bmasney@redhat•com>,
linux-clk@vger•kernel.org, linux-arm-kernel@lists•infradead.org,
linux-kernel@vger•kernel.org
Subject: Re: [PATCH] clk: zynq: handle kasprintf() failure in periph_clk registration
Date: Tue, 2 Jun 2026 14:40:55 +0200 [thread overview]
Message-ID: <ff4666f8-cfe1-486e-8afa-aa54a59e2a13@amd.com> (raw)
In-Reply-To: <20260601203500.658135-1-william@theesfeld.net>
On 6/1/26 22:35, William Theesfeld wrote:
> zynq_clk_register_periph_clk() ignores the return value of the two
> kasprintf() calls used to build the mux and divider clock names, and
> passes the resulting (possibly NULL) pointers straight into
> clk_register_mux(), clk_register_divider() and clk_register_gate() as
> the clock '"'name'"' argument. On allocation failure that name later
> gets dereferenced by the clock framework (e.g. in debugfs name
> formatting), causing a NULL-pointer dereference.
>
> Check both kasprintf() returns. On failure unwind any allocated name
> buffer and the spinlock, then fall through to the existing err label
> which sets clks[] to ERR_PTR(-ENOMEM). Freeing the spinlock on the
> error path is correct here because no clk_register_*() call has had
> a chance to take ownership of it; the success path intentionally
> hands it off to the registered clocks.
>
> The neighbouring zynq_clk_register_fclk() in the same file already
> uses this per-allocation goto-label cleanup pattern; this change
> brings periph_clk into line with it.
>
> Signed-off-by: William Theesfeld <william@theesfeld•net>
Reviewed-by: Michal Simek <michal.simek@amd•com>
Thanks,
Michal
prev parent reply other threads:[~2026-06-02 12:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-01 20:35 [PATCH] clk: zynq: handle kasprintf() failure in periph_clk registration William Theesfeld
2026-06-02 12:40 ` Michal Simek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff4666f8-cfe1-486e-8afa-aa54a59e2a13@amd.com \
--to=michal.simek@amd$(echo .)com \
--cc=bmasney@redhat$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-clk@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=mturquette@baylibre$(echo .)com \
--cc=sboyd@kernel$(echo .)org \
--cc=william@theesfeld$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox