From: khilman@baylibre•com (Kevin Hilman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2.1 1/4] ARM: dts: davinci: da850: VPIF: add node and muxing
Date: Mon, 09 Jan 2017 11:32:35 -0800 [thread overview]
Message-ID: <m21swc81ws.fsf@baylibre.com> (raw)
In-Reply-To: <f3cdadf0-b0e9-9956-145a-9cc22024f6f9@ti.com> (Sekhar Nori's message of "Tue, 3 Jan 2017 11:05:00 +0530")
Sekhar Nori <nsekhar@ti•com> writes:
> Hi Kevin,
>
> On Thursday 08 December 2016 05:44 AM, Kevin Hilman wrote:
>> Add VPIF node an pins to da850 and enable on boards. VPIF has two input
>> channels described using the standard DT ports and enpoints.
>>
>> Signed-off-by: Kevin Hilman <khilman@baylibre•com>
>> ---
>> v2 -> v2.1: moved ports from SoC .dtsi to board .dts files.
>>
>> arch/arm/boot/dts/da850-evm.dts | 20 ++++++++++++++++++++
>> arch/arm/boot/dts/da850-lcdk.dts | 13 +++++++++++++
>> arch/arm/boot/dts/da850.dtsi | 27 ++++++++++++++++++++++++++-
>> 3 files changed, 59 insertions(+), 1 deletion(-)
>
> Can you split this patch to keep the SoC addition separate from board
> updates. Separating support addition for EVM and LCDK will be good also.
I don't understand why that matters, but OK.
>> diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi
>> index f79e1b91c680..5f0b40510b2b 100644
>> --- a/arch/arm/boot/dts/da850.dtsi
>> +++ b/arch/arm/boot/dts/da850.dtsi
>
>> @@ -399,7 +410,21 @@
>> <&edma0 0 1>;
>> dma-names = "tx", "rx";
>> };
>> +
>> + vpif: video at 217000 {
>> + compatible = "ti,da850-vpif";
>> + reg = <0x217000 0x1000>;
>> + interrupts = <92>;
>> + status = "disabled";
>> +
>> + /* VPIF capture port */
>> + port {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + };
>> + };
>
> Can you add this node just above mmc1? I am trying to keep the nodes
> sorted in the order of unit address instead of new ones getting added at
> the end. Unfortunately, it was not strictly enforced and we have many
> breakages. But lets add the new ones where they will eventually end up.
OK.
Kevin
next prev parent reply other threads:[~2017-01-09 19:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-07 19:31 [PATCH v2 0/4] ARM: davinci: da850: add/enable video capture Kevin Hilman
2016-12-07 19:31 ` [PATCH v2 1/4] ARM: dts: davinci: da850: VPIF: add node and muxing Kevin Hilman
2016-12-07 19:34 ` Laurent Pinchart
2016-12-07 23:15 ` Kevin Hilman
2016-12-08 0:14 ` [PATCH v2.1 " Kevin Hilman
2016-12-08 13:51 ` Laurent Pinchart
2017-01-03 5:35 ` Sekhar Nori
2017-01-09 19:32 ` Kevin Hilman [this message]
2016-12-07 19:31 ` [PATCH v2 2/4] ARM: davinci_all_defconfig: enable video capture as modules Kevin Hilman
2017-01-03 5:51 ` Sekhar Nori
2016-12-07 19:31 ` [PATCH v2 3/4] ARM: davinci: da8xx: add pdata-quirks, use for VPIF capture Kevin Hilman
2017-01-03 8:56 ` Sekhar Nori
2016-12-07 19:31 ` [PATCH v2 4/4] ARM: davinci: board-da850-evm: add I2C ID for VPIF Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m21swc81ws.fsf@baylibre.com \
--to=khilman@baylibre$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox