From: khilman@baylibre•com (Kevin Hilman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] ARM: davinci: enable PM for DT boot
Date: Fri, 28 Oct 2016 13:50:53 -0700 [thread overview]
Message-ID: <m260oc6vv6.fsf@baylibre.com> (raw)
In-Reply-To: <c3a69359-bcec-40fe-e25c-048b97bab726@ti.com> (Sekhar Nori's message of "Fri, 28 Oct 2016 17:40:10 +0530")
Sekhar Nori <nsekhar@ti•com> writes:
> Hi Kevin,
>
> On Wednesday 26 October 2016 03:17 AM, Kevin Hilman wrote:
>> Currently system PM is only enabled for legacy (non-DT) boot. Enable
>> for DT boot also.
>>
>> Tested on da850-lcdk using "rtcwake -m mem -s5 -d rtc0".
>>
>> Signed-off-by: Kevin Hilman <khilman@baylibre•com>
>> ---
>> arch/arm/mach-davinci/da8xx-dt.c | 18 ++++++++++++++++++
>> 1 file changed, 18 insertions(+)
>>
>> diff --git a/arch/arm/mach-davinci/da8xx-dt.c b/arch/arm/mach-davinci/da8xx-dt.c
>> index c9f7e9274aa8..a8089fa40d86 100644
>> --- a/arch/arm/mach-davinci/da8xx-dt.c
>> +++ b/arch/arm/mach-davinci/da8xx-dt.c
>> @@ -43,8 +43,26 @@ static struct of_dev_auxdata da850_auxdata_lookup[] __initdata = {
>>
>> #ifdef CONFIG_ARCH_DAVINCI_DA850
>>
>> +static struct davinci_pm_config da850_pm_pdata = {
>> + .sleepcount = 128,
>> +};
>> +
>> +static struct platform_device da850_pm_device = {
>> + .name = "pm-davinci",
>> + .dev = {
>> + .platform_data = &da850_pm_pdata,
>> + },
>> + .id = -1,
>> +};
>> +
>> static void __init da850_init_machine(void)
>> {
>> + int ret;
>> +
>> + ret = da850_register_pm(&da850_pm_device);
>
> I am not sure if it makes sense to keep the "pm device" around anymore.
> I think for both DT and non-DT boot, we can get rid of the fake PM
> device and combine da850_register_pm() and davinci_pm_probe() into a
> single davinci_init_suspend() function which can then be called both for
> DT and non-DT boot.
>
> This was we can also avoid replication of the platform data and platform
> device structures.
Great, that sounds much cleaner. Will re-spin.
Kevin
next prev parent reply other threads:[~2016-10-28 20:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-25 21:47 [PATCH] ARM: davinci: enable PM for DT boot Kevin Hilman
2016-10-28 12:10 ` Sekhar Nori
2016-10-28 20:50 ` Kevin Hilman [this message]
2016-11-08 18:13 ` Kevin Hilman
2016-11-11 11:02 ` Sekhar Nori
2016-11-11 16:36 ` Kevin Hilman
2016-11-14 9:25 ` Sekhar Nori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m260oc6vv6.fsf@baylibre.com \
--to=khilman@baylibre$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox