From: khilman@baylibre•com (Kevin Hilman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/2] ARM64: dts: meson-gxm: Add R-Box Pro
Date: Wed, 18 Jan 2017 14:18:39 -0800 [thread overview]
Message-ID: <m27f5sypts.fsf@baylibre.com> (raw)
In-Reply-To: <63fbfc68-917f-68b2-9e7d-e1834e2841d3@suse.de> ("Andreas Färber"'s message of "Tue, 17 Jan 2017 04:35:10 +0100")
Andreas F?rber <afaerber@suse•de> writes:
> Am 17.01.2017 um 04:06 schrieb Andreas F?rber:
>> + leds {
>> + compatible = "gpio-leds";
>> +
>> + blue {
>> + label = "rbox-pro:blue:on";
>> + gpios = <&gpio_ao GPIOAO_9 GPIO_ACTIVE_HIGH>;
>> + default-state = "on";
>> + };
>> +
>> + red {
>> + label = "rbox-pro:red:standby";
>> + gpios = <&gpio GPIODV_28 GPIO_ACTIVE_HIGH>;
>> + default-state = "off";
>> + retain-state-suspended;
>> + panic-indicator;
>> + };
>> + };
>
> The original property names for these two were led and red. If anyone
> has better label names than the above, please speak up. Ditto for
> vega-s95. On the odroidc2 it's called alive but uses heartbeat there.
>
> The vendor device tree had a third "mcu" GPIO in the sysled node,
> GPIOAO_6, which leads to immediate power-off. I tried using
> "gpio-poweroff" to configure this pin, but that driver fails to
> initialize because some pm callback is already registered - I assume
> from psci, which apparently succeeds to power-off the system, too. For
> comparison, the S905 based Vega S95 Telos has no such mcu property. Any
> thoughts?
>
> Also, any ideas how best to switch from blue to red for suspend? Add
> pinctrl properties above? systemd service doing echo from userspace? I
> assume in Android the Amlogic sysled driver handles all that logic -
> didn't find any suspend equivalent to gpio-poweroff.
in leds-gpio, when retain-state-suspended is not set, the LED is
automatically set to value 0. I wonder if leds-gpio should grow support
to make the suspend value configurable? Or a property like
"toggle-state-suspended" ?
Kevin
next prev parent reply other threads:[~2017-01-18 22:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-17 3:06 [PATCH 0/2] ARM64: meson-gxm: R-Box Pro enablement Andreas Färber
2017-01-17 3:06 ` [PATCH 1/2] ARM64: dts: meson-gxm: Add R-Box Pro Andreas Färber
2017-01-17 3:35 ` Andreas Färber
2017-01-18 22:18 ` Kevin Hilman [this message]
2017-01-17 22:54 ` [PATCH 1/3] Documentation: devicetree: Add Kingnovel vendor prefix Andreas Färber
2017-01-17 22:54 ` [PATCH 2/3] Documentation: devicetree: amlogic: Add R-Box Pro Andreas Färber
2017-01-18 9:35 ` Neil Armstrong
2017-01-18 22:38 ` Andreas Färber
2017-01-18 23:38 ` Kevin Hilman
2017-01-21 20:02 ` Rob Herring
2017-01-17 22:54 ` [PATCH 3/3] ARM64: dts: meson-gxm-rbox-pro: Add board compatible string Andreas Färber
2017-01-23 18:21 ` Kevin Hilman
2017-01-23 18:32 ` Andreas Färber
2017-01-21 20:01 ` [PATCH 1/3] Documentation: devicetree: Add Kingnovel vendor prefix Rob Herring
2017-01-17 23:06 ` [PATCH 1/2] ARM64: dts: meson-gxm: Add R-Box Pro Andreas Färber
2017-01-18 22:27 ` Kevin Hilman
2017-01-19 8:10 ` Neil Armstrong
2017-01-17 3:06 ` [PATCH 2/2] ARM64: dts: meson-gxm-rbox-pro: Enable Bluetooth Andreas Färber
2017-01-18 22:29 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m27f5sypts.fsf@baylibre.com \
--to=khilman@baylibre$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox