From: khilman@baylibre•com (Kevin Hilman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v5 3/5] [media] davinci: vpif_capture: fix start/stop streaming locking
Date: Wed, 07 Dec 2016 09:22:48 -0800 [thread overview]
Message-ID: <m2eg1jejrr.fsf@baylibre.com> (raw)
In-Reply-To: <5753609.tAY8Gxp3ld@avalon> (Laurent Pinchart's message of "Wed, 07 Dec 2016 16:47:34 +0200")
Laurent Pinchart <laurent.pinchart@ideasonboard•com> writes:
> Hi Kevin,
>
> Thank you for the patch.
>
> On Tuesday 06 Dec 2016 21:08:24 Kevin Hilman wrote:
>> Video capture subdevs may be over I2C and may sleep during xfer, so we
>> cannot do IRQ-disabled locking when calling the subdev.
>>
>> The IRQ-disabled locking is meant to protect the DMA queue list
>> throughout the rest of the driver, so update the locking in
>> [start|stop]_streaming to protect just this list.
>>
>> Suggested-by: Laurent Pinchart <laurent.pinchart@ideasonboard•com>
>> Signed-off-by: Kevin Hilman <khilman@baylibre•com>
>
> I would also add a comment to document the irqlock field as protecting the
> dma_queue list only. Something like
>
> - /* Used in video-buf */
> + /* Protects the dma_queue field */
> spinlock_t irqlock;
>
> With that,
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard•com>
OK, will update the comment. Thanks for the review,
Kevin
next prev parent reply other threads:[~2016-12-07 17:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-07 5:08 [PATCH v5 0/5] davinci: VPIF: add DT support Kevin Hilman
2016-12-07 5:08 ` [PATCH v5 1/5] [media] davinci: VPIF: fix module loading, init errors Kevin Hilman
2016-12-07 5:08 ` [PATCH v5 2/5] [media] davinci: vpif_capture: remove hard-coded I2C adapter id Kevin Hilman
2016-12-07 5:08 ` [PATCH v5 3/5] [media] davinci: vpif_capture: fix start/stop streaming locking Kevin Hilman
2016-12-07 14:47 ` Laurent Pinchart
2016-12-07 17:22 ` Kevin Hilman [this message]
2016-12-07 5:08 ` [PATCH v5 4/5] [media] dt-bindings: add TI VPIF documentation Kevin Hilman
2016-12-07 15:17 ` Laurent Pinchart
2016-12-07 17:28 ` Kevin Hilman
2016-12-07 5:08 ` [PATCH v5 5/5] [media] davinci: VPIF: add basic support for DT init Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2eg1jejrr.fsf@baylibre.com \
--to=khilman@baylibre$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox