From: Waqar Hameed <waqar.hameed@axis•com>
To: Vinod Koul <vkoul@kernel•org>,
Kishon Vijay Abraham I <kishon@kernel•org>,
Krzysztof Kozlowski <krzk@kernel•org>,
Alim Akhtar <alim.akhtar@samsung•com>
Cc: <kernel@axis•com>, <linux-phy@lists•infradead.org>,
<linux-arm-kernel@lists•infradead.org>,
<linux-samsung-soc@vger•kernel.org>,
<linux-kernel@vger•kernel.org>
Subject: [PATCH v2] phy: exynos5-usbdrd: Remove error print for devm_add_action_or_reset()
Date: Tue, 5 Aug 2025 11:33:35 +0200 [thread overview]
Message-ID: <pnd34a6m7tc.a.out@axis.com> (raw)
When `devm_add_action_or_reset()` fails, it is due to a failed memory
allocation and will thus return `-ENOMEM`. `dev_err_probe()` doesn't do
anything when error is `-ENOMEM`. Therefore, remove the useless call to
`dev_err_probe()` when `devm_add_action_or_reset()` fails, and just
return the value instead.
Signed-off-by: Waqar Hameed <waqar.hameed@axis•com>
---
Changes in v2:
* Split the patch to one seperate patch for each sub-system.
Link to v1: https://lore.kernel.org/all/pnd7c0s6ji2.fsf@axis.com/
drivers/phy/samsung/phy-exynos5-usbdrd.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/phy/samsung/phy-exynos5-usbdrd.c b/drivers/phy/samsung/phy-exynos5-usbdrd.c
index 917a76d584f0..28ba11e42823 100644
--- a/drivers/phy/samsung/phy-exynos5-usbdrd.c
+++ b/drivers/phy/samsung/phy-exynos5-usbdrd.c
@@ -1859,8 +1859,7 @@ static int exynos5_usbdrd_setup_notifiers(struct exynos5_usbdrd_phy *phy_drd)
exynos5_usbdrd_orien_switch_unregister,
phy_drd);
if (ret)
- return dev_err_probe(phy_drd->dev, ret,
- "Failed to register TypeC orientation devm action\n");
+ return ret;
}
return 0;
base-commit: 260f6f4fda93c8485c8037865c941b42b9cba5d2
--
2.39.5
next reply other threads:[~2025-08-05 9:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-05 9:33 Waqar Hameed [this message]
2025-10-10 13:39 ` [PATCH v2] phy: exynos5-usbdrd: Remove error print for devm_add_action_or_reset() Waqar Hameed
2026-05-20 14:58 ` Waqar Hameed
2026-05-20 17:06 ` Tudor Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pnd34a6m7tc.a.out@axis.com \
--to=waqar.hameed@axis$(echo .)com \
--cc=alim.akhtar@samsung$(echo .)com \
--cc=kernel@axis$(echo .)com \
--cc=kishon@kernel$(echo .)org \
--cc=krzk@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-phy@lists$(echo .)infradead.org \
--cc=linux-samsung-soc@vger$(echo .)kernel.org \
--cc=vkoul@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox