From: mitchelh@codeaurora•org (Mitchel Humpherys)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v4 4/6] arm64/dma-mapping: Implement DMA_ATTR_PRIVILEGED
Date: Wed, 27 Jul 2016 16:39:39 -0700 [thread overview]
Message-ID: <vnkweg6e6478.fsf@codeaurora.org> (raw)
In-Reply-To: <f6fa75a9-ce70-e6c5-fd51-2af502bc2f67@arm.com> (Robin Murphy's message of "Tue, 26 Jul 2016 16:05:17 +0100")
On Tue, Jul 26 2016 at 04:05:17 PM, Robin Murphy <robin.murphy@arm•com> wrote:
> + if (attrs & DMA_ATTR_PRIVILEGED)
> + prot |= IOMMU_PRIV;
> +
>
> then drop the rest of the changes to the switch statement below. It's
> taken me an embarrassingly long time to work out why things were blowing
> up in __iommu_sync_single_for_device() all with a VA of phys_to_virt(0) ;)
Ah yes, that is much nicer! Nice catch...
> With that change, for the whole series:
>
> Reviewed-by: Robin Murphy <robin.murphy@arm•com>
> Tested-by: Robin Murphy <robin.murphy@arm•com>
>
> I guess at this point it may be worth waiting to repost based on -rc1.
> Be sure to CC patch 5 to Vinod as the current dmaengine maintainer, as
> it's his ack we'll need on that.
Thanks for the review and test. I'll go ahead and send a v5 series
since I'm actually leaving QuIC this Friday and so I won't be around to
send it next week...
-Mitch
--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-07-27 23:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-25 19:16 [PATCH v4 0/6] Add support for privileged mappings Mitchel Humpherys
2016-07-25 19:16 ` [PATCH v4 1/6] iommu: add IOMMU_PRIV attribute Mitchel Humpherys
2016-07-25 19:16 ` [PATCH v4 2/6] iommu/io-pgtable-arm: add support for the IOMMU_PRIV flag Mitchel Humpherys
2016-07-25 19:16 ` [PATCH v4 3/6] common: DMA-mapping: add DMA_ATTR_PRIVILEGED attribute Mitchel Humpherys
2016-07-25 19:16 ` [PATCH v4 4/6] arm64/dma-mapping: Implement DMA_ATTR_PRIVILEGED Mitchel Humpherys
2016-07-26 15:05 ` Robin Murphy
2016-07-27 23:39 ` Mitchel Humpherys [this message]
2016-07-25 19:16 ` [PATCH v4 5/6] dmaengine: pl330: Make sure microcode is privileged Mitchel Humpherys
2016-07-25 19:16 ` [PATCH v4 6/6] Revert "iommu/arm-smmu: Treat all device transactions as unprivileged" Mitchel Humpherys
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vnkweg6e6478.fsf@codeaurora.org \
--to=mitchelh@codeaurora$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox