From: martin.petersen@oracle•com (Martin K. Petersen)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] scsi: fas216: fix sense buffer initialization
Date: Thu, 18 Jan 2018 21:43:59 -0500 [thread overview]
Message-ID: <yq13732o9e8.fsf@oracle.com> (raw)
In-Reply-To: <20180118131650.893849-1-arnd@arndb.de> (Arnd Bergmann's message of "Thu, 18 Jan 2018 14:16:38 +0100")
Arnd,
> While testing with the ARM specific memset() macro removed, I ran
> into a compiler warning that shows an old bug:
>
> drivers/scsi/arm/fas216.c: In function 'fas216_rq_sns_done':
> drivers/scsi/arm/fas216.c:2014:40: error: argument to 'sizeof' in 'memset' call is the same expression as the destination; did you mean to provide an explicit length? [-Werror=sizeof-pointer-memaccess]
>
> It turns out that the definition of the scsi_cmd structure changed back
> in linux-2.6.25, so now we clear only four bytes (sizeof(pointer)) instead
> of 96 (SCSI_SENSE_BUFFERSIZE). I did not check whether we actually need
> to initialize the buffer here, but it's clear that if we do it, we
> should use the correct size.
Applied to 4.16/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2018-01-19 2:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-18 13:16 [PATCH] scsi: fas216: fix sense buffer initialization Arnd Bergmann
2018-01-19 2:43 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq13732o9e8.fsf@oracle.com \
--to=martin.petersen@oracle$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox