Subject: Re: [PATCH net-next] net: dsa: tag_sja1105: Select CONFIG_PACKING

From: Randy Dunlap <[email-masked]>
Date: Tue, 11 Jun 2019 18:56:13 -0700

On 6/11/19 11:47 AM, Vladimir Oltean wrote:
> The packing facility is needed to decode Ethernet meta frames containing
> source port and RX timestamping information.
> 
> The DSA driver selects CONFIG_PACKING, but the tagger did not, and since
> taggers can be now compiled as modules independently from the drivers
> themselves, this is an issue now, as CONFIG_PACKING is disabled by
> default on all architectures.
> 
> Fixes: e53e18a6fe4d ("net: dsa: sja1105: Receive and decode meta frames")
> Signed-off-by: Vladimir Oltean <[email-masked]>
> Reported-by: Randy Dunlap <[email-masked]>

Acked-by: Randy Dunlap <[email-masked]> # build-tested

Thanks.

> ---
>  net/dsa/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/net/dsa/Kconfig b/net/dsa/Kconfig
> index d449f78c1bd0..6e942dda1bcd 100644
> --- a/net/dsa/Kconfig
> +++ b/net/dsa/Kconfig
> @@ -106,6 +106,7 @@ config NET_DSA_TAG_LAN9303
>  config NET_DSA_TAG_SJA1105
>  	tristate "Tag driver for NXP SJA1105 switches"
>  	select NET_DSA_TAG_8021Q
> +	select PACKING
>  	help
>  	  Say Y or M if you want to enable support for tagging frames with the
>  	  NXP SJA1105 switch family. Both the native tagging protocol (which
> 

-- 
~Randy