From: "Guan Xuetao" <guanxuetao@mprc•pku.edu.cn>
To: 'Paul Mundt' <lethal@linux-sh•org>
Cc: sfr@canb•auug.org.au, 'Arnd Bergmann' <arnd@arndb•de>,
gregkh@suse•de, jbarnes@virtuousgeek•org,
dmitry.torokhov@gmail•com, dtor@mail•ru, rubini@cvml•unipv.it,
linux-arch@vger•kernel.org, linux-kernel@vger•kernel.org,
linux-fbdev@vger•kernel.org, linux-next@vger•kernel.org
Subject: RE: Request for unicore32 architecture codes to merge into linux-next
Date: Tue, 18 Jan 2011 17:07:41 +0800 [thread overview]
Message-ID: <01b501cbb6ef$3299f2a0$97cdd7e0$@mprc.pku.edu.cn> (raw)
In-Reply-To: <20110118043323.GF2122@linux-sh.org>
> -----Original Message-----
> From: Paul Mundt [mailto:lethal@linux-sh•org]
> Sent: Tuesday, January 18, 2011 12:33 PM
> To: Guan Xuetao
> Cc: sfr@canb•auug.org.au; Arnd Bergmann; gregkh@suse•de; jbarnes@virtuousgeek•org; dmitry.torokhov@gmail•com; dtor@mail•ru;
> rubini@cvml•unipv.it; linux-arch@vger•kernel.org; linux-kernel@vger•kernel.org; linux-fbdev@vger•kernel.org; linux-
> next@vger•kernel.org
> Subject: Re: Request for unicore32 architecture codes to merge into linux-next
>
> On Sun, Jan 16, 2011 at 01:00:31AM +0800, Guan Xuetao wrote:
> > drivers/staging/puv3/Kconfig | 125 ++
> > drivers/staging/puv3/Makefile | 22 +
> > drivers/staging/puv3/TODO | 7 +
> > drivers/staging/puv3/i8042-ucio.h | 89 ++
> > drivers/staging/puv3/puv3-atkbd.h | 43 +
> > drivers/staging/puv3/puv3_ac97.c | 369 +++++
> > drivers/staging/puv3/puv3_i2c.c | 309 ++++
> > drivers/staging/puv3/puv3_pcm.c | 435 ++++++
> > drivers/staging/puv3/puv3_pcm.h | 28 +
> > drivers/staging/puv3/puv3_umal.c | 2069 +++++++++++++++++++++++++
> > drivers/staging/puv3/puv3_unifb.c | 965 ++++++++++++
>
> Staging is not a shortcut around having things reviewed or broken out
> logically. It's of course fine to merge the bulk of things in one go for
> when a new architecture is going on, but logically disparate parts still
> need to be broken out and sent to the proper places for review. It's
> obvious you haven't done this for any of the non-arch bits and hiding
> things under staging is not going to make this step any less necessary.
>
> If you want your framebuffer driver reviewed, then split it out and
> submit it to the linux-fbdev list for review. Once that's had a going
> over and been Acked then of course it can be merged through whatever tree
> you like, and there's even a good chance that you don't need to bother
> with staging at all.
>
> Using staging as a review circumvention measure however is just not going
> to fly.
I understand.
IMO, the whole architecture specific codes need to be merged first, and only some
necessary drivers are included under staging. Then, I could split the staging drivers
into corresponding mail-list, and then, additional drivers.
Otherwise, there are no architecture basic for drivers review.
Thanks
Guan Xuetao
next prev parent reply other threads:[~2011-01-18 9:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-15 17:00 Request for unicore32 architecture codes to merge into linux-next Guan Xuetao
2011-01-15 22:08 ` Dmitry Torokhov
2011-01-16 15:35 ` Guan Xuetao
2011-01-18 4:33 ` Paul Mundt
2011-01-18 9:07 ` Guan Xuetao [this message]
2011-01-18 9:10 ` Paul Mundt
2011-01-18 9:33 ` Guan Xuetao
2011-01-18 9:53 ` Paul Mundt
2011-01-18 18:33 ` Konrad Rzeszutek Wilk
2011-01-19 2:20 ` Guan Xuetao
2011-01-20 19:42 ` Jesse Barnes
2011-01-22 2:17 ` Guan Xuetao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='01b501cbb6ef$3299f2a0$97cdd7e0$@mprc.pku.edu.cn' \
--to=guanxuetao@mprc$(echo .)pku.edu.cn \
--cc=arnd@arndb$(echo .)de \
--cc=dmitry.torokhov@gmail$(echo .)com \
--cc=dtor@mail$(echo .)ru \
--cc=gregkh@suse$(echo .)de \
--cc=jbarnes@virtuousgeek$(echo .)org \
--cc=lethal@linux-sh$(echo .)org \
--cc=linux-arch@vger$(echo .)kernel.org \
--cc=linux-fbdev@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=rubini@cvml$(echo .)unipv.it \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox