From: Mark Brown <broonie@kernel•org>
To: Leon Romanovsky <leonro@nvidia•com>
Cc: Jason Gunthorpe <jgg@nvidia•com>,
linux-kernel@vger•kernel.org, linux-next@vger•kernel.org
Subject: Re: Missing signoff in the rdma tree
Date: Mon, 9 Mar 2026 12:43:16 +0000 [thread overview]
Message-ID: <091dbc25-06d6-4847-af50-6349f1acbf17@sirena.org.uk> (raw)
In-Reply-To: <20260309115226.GV12611@unreal>
[-- Attachment #1: Type: text/plain, Size: 724 bytes --]
On Mon, Mar 09, 2026 at 01:52:26PM +0200, Leon Romanovsky wrote:
> On Mon, Mar 09, 2026 at 11:46:07AM +0000, Mark Brown wrote:
> > No, I see signoffs from Sriharsha and Jason but not you and it's you who
> > actually did the commit (see above, git show --pretty=fuller). Did you
> > by any chance rebase a branch where you'd pulled something from Jason
> > (or which Jason had pushed to)?
> Jason applied, but I rebased that branch to drop patch which was taken
> by mistake.
Right, if you do that you need to add your signoff to the rebased
commits since they get rewritten during the rebase making you the
committer. Nothing looking at history can tell a rebase happened. git
rebase has a --signoff option for this.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-03-09 12:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-09 11:10 Missing signoff in the rdma tree Mark Brown
2026-03-09 11:40 ` Leon Romanovsky
2026-03-09 11:46 ` Mark Brown
2026-03-09 11:52 ` Leon Romanovsky
2026-03-09 12:43 ` Mark Brown [this message]
2026-03-09 12:48 ` Jason Gunthorpe
2026-04-06 16:38 ` Mark Brown
2026-04-06 17:30 ` Jason Gunthorpe
-- strict thread matches above, loose matches on Subject: below --
2026-03-23 13:25 Mark Brown
2026-03-30 22:10 ` Mark Brown
2026-03-31 4:59 ` Leon Romanovsky
2026-05-18 8:23 Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=091dbc25-06d6-4847-af50-6349f1acbf17@sirena.org.uk \
--to=broonie@kernel$(echo .)org \
--cc=jgg@nvidia$(echo .)com \
--cc=leonro@nvidia$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox