From: Geert Uytterhoeven <geert@linux-m68k•org>
To: Randy Dunlap <randy.dunlap@oracle•com>
Cc: Stephen Rothwell <sfr@canb•auug.org.au>,
linux-next@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>,
herbert@gondor•apana.org.au, David Miller <davem@davemloft•net>,
linux-crypto@vger•kernel.org
Subject: Re: linux-next: Tree for March 10 (crypto & NLATTR)
Date: Tue, 10 Mar 2009 20:56:59 +0100 [thread overview]
Message-ID: <10f740e80903101256v2cfe08a8g410c297e019d8693@mail.gmail.com> (raw)
In-Reply-To: <49B6B821.5050302@oracle.com>
On Tue, Mar 10, 2009 at 19:57, Randy Dunlap <randy.dunlap@oracle•com> wrote:
> Stephen Rothwell wrote:
>> Changes since 20090306:
>>
>>
>> The driver-core tree gained a build failure due to a conflict with the
>> crypto tree. I have applied a patch to the crypto tree for today.
>
> I had several (4 of 50) randconfig builds fail with:
>
> lib/built-in.o: In function `__nla_reserve_nohdr':
> (.text+0xd08d): undefined reference to `skb_put'
> lib/built-in.o: In function `__nla_reserve':
> (.text+0xd121): undefined reference to `skb_put'
> lib/built-in.o: In function `nla_append':
> (.text+0xd493): undefined reference to `skb_put'
>
> which happens with CONFIG_NET=n, CONFIG_CRYPTO=y, CONFIG_CRYPTO_ZLIB=[my].
>
> CRYPTO_ZLIB selects NLATTR, but obviously the build of nlattr.c fails
> when CONFIG_NET=n. Should CRYPTO_ZLIB depend on NET?
> Please don't say that CRYPTO_ZLIB should select NET.
Bummer, my fault (commit e9cc8bddaea3944fabfebb968bc88d603239beed,
netlink: Move netlink attribute parsing support to lib).
Obviously I was only worried about crypto/zlib.c needing nlattr.c
without pulling in the whole networking code, not about nlattr.c
itself needing networking functionality. But still, how could I have
missed this compile failure?
Does it sound sane to protect the routines that do call skb_put() by
#ifdef CONFIG_NET?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k•org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2009-03-10 19:57 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-10 8:55 linux-next: Tree for March 10 Stephen Rothwell
2009-03-10 9:33 ` Wim Van Sebroeck
2009-03-10 11:07 ` Stephen Rothwell
2009-03-10 14:12 ` Next 10: Badness at mm/allocpercpu.c:123 Sachin P. Sant
2009-03-11 4:16 ` Sachin P. Sant
2009-03-11 5:53 ` [GIT PATCH tj-percpu] percpu: fix spurious alignment WARN in legacy SMP percpu allocator Tejun Heo
2009-03-11 5:54 ` [RESEND GIT " Tejun Heo
2009-03-11 6:48 ` Sachin P. Sant
2009-03-11 9:31 ` Ingo Molnar
2009-03-11 8:50 ` Next 10: Badness at mm/allocpercpu.c:123 AA
2009-03-11 8:53 ` where should I map 0x8000,0000 ~ 0xfc00,0000 to ? AA
2009-03-10 18:57 ` linux-next: Tree for March 10 (crypto & NLATTR) Randy Dunlap
2009-03-10 19:56 ` Geert Uytterhoeven [this message]
2009-03-10 20:08 ` Randy Dunlap
2009-03-10 20:17 ` David Miller
2009-03-11 1:07 ` Herbert Xu
2009-03-11 12:25 ` Geert Uytterhoeven
2009-03-11 16:55 ` Randy Dunlap
2009-03-10 18:59 ` [PATCH -next] staging/p9auth: fix dependency/build error Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10f740e80903101256v2cfe08a8g410c297e019d8693@mail.gmail.com \
--to=geert@linux-m68k$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=linux-crypto@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=randy.dunlap@oracle$(echo .)com \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox